* [meta-fsl-arm-extra][PATCH] broadcom-nvram-config: Add compatible machine setting
@ 2013-03-25 12:51 Otavio Salvador
2013-03-25 15:34 ` John Weber
0 siblings, 1 reply; 4+ messages in thread
From: Otavio Salvador @ 2013-03-25 12:51 UTC (permalink / raw)
To: meta-freescale Mailing List; +Cc: Otavio Salvador
This avoid a warning, during recipe parsing of bitbake, due an
incompatible machine as the nvram.txt is not available as no know
default one is suitable for every board so a specific one is need.
Change-Id: I409a1310c6f37975a46d79cdbd84665daa381e0d
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
index 0afd374..85f56d2 100644
--- a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
+++ b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
@@ -26,3 +26,4 @@ BROADCOM_FIRMWARE_wandboard-dual = "bcm4329"
RDEPENDS_${PN} = "linux-firmware-${BROADCOM_FIRMWARE}"
+COMPATIBLE_MACHINE = "(wandboard-dual)"
--
1.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] broadcom-nvram-config: Add compatible machine setting
2013-03-25 12:51 [meta-fsl-arm-extra][PATCH] broadcom-nvram-config: Add compatible machine setting Otavio Salvador
@ 2013-03-25 15:34 ` John Weber
2013-03-25 17:31 ` Otavio Salvador
0 siblings, 1 reply; 4+ messages in thread
From: John Weber @ 2013-03-25 15:34 UTC (permalink / raw)
To: meta-freescale
Otavio -
I thought the point of setting:
BROADCOM_FIRMWARE = "INVALID"
was to throw an error on purpose in case someone added the package to their
machine and did not modify the recipe to provide a corresponding nvram file for
their machine?
Doesn't adding COMPATIBLE_MACHINE remove that error?
John
On 3/25/13 7:51 AM, Otavio Salvador wrote:
> This avoid a warning, during recipe parsing of bitbake, due an
> incompatible machine as the nvram.txt is not available as no know
> default one is suitable for every board so a specific one is need.
>
> Change-Id: I409a1310c6f37975a46d79cdbd84665daa381e0d
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
> index 0afd374..85f56d2 100644
> --- a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
> +++ b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
> @@ -26,3 +26,4 @@ BROADCOM_FIRMWARE_wandboard-dual = "bcm4329"
>
> RDEPENDS_${PN} = "linux-firmware-${BROADCOM_FIRMWARE}"
>
> +COMPATIBLE_MACHINE = "(wandboard-dual)"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] broadcom-nvram-config: Add compatible machine setting
2013-03-25 15:34 ` John Weber
@ 2013-03-25 17:31 ` Otavio Salvador
2013-03-25 18:27 ` John Weber
0 siblings, 1 reply; 4+ messages in thread
From: Otavio Salvador @ 2013-03-25 17:31 UTC (permalink / raw)
To: John Weber; +Cc: meta-freescale
On Mon, Mar 25, 2013 at 12:34 PM, John Weber <rjohnweber@gmail.com> wrote:
> Otavio -
>
> I thought the point of setting:
>
> BROADCOM_FIRMWARE = "INVALID"
>
> was to throw an error on purpose in case someone added the package to their
> machine and did not modify the recipe to provide a corresponding nvram file
> for their machine?
It will do in rootfs generation as linux-firmware-INVALID won't be instalable.
> Doesn't adding COMPATIBLE_MACHINE remove that error?
Yes but the reason I added it is because bitbake try to checksum a
nvram.txt file which does not exist to other machines and then do a
warning during recipe parsing.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH] broadcom-nvram-config: Add compatible machine setting
2013-03-25 17:31 ` Otavio Salvador
@ 2013-03-25 18:27 ` John Weber
0 siblings, 0 replies; 4+ messages in thread
From: John Weber @ 2013-03-25 18:27 UTC (permalink / raw)
To: Otavio Salvador; +Cc: meta-freescale
OK. I understand now. Sounds good.
On 3/25/13 12:31 PM, Otavio Salvador wrote:
> On Mon, Mar 25, 2013 at 12:34 PM, John Weber <rjohnweber@gmail.com> wrote:
>> Otavio -
>>
>> I thought the point of setting:
>>
>> BROADCOM_FIRMWARE = "INVALID"
>>
>> was to throw an error on purpose in case someone added the package to their
>> machine and did not modify the recipe to provide a corresponding nvram file
>> for their machine?
>
> It will do in rootfs generation as linux-firmware-INVALID won't be instalable.
>
>> Doesn't adding COMPATIBLE_MACHINE remove that error?
>
> Yes but the reason I added it is because bitbake try to checksum a
> nvram.txt file which does not exist to other machines and then do a
> warning during recipe parsing.
>
> --
> Otavio Salvador O.S. Systems
> E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
> Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-25 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-25 12:51 [meta-fsl-arm-extra][PATCH] broadcom-nvram-config: Add compatible machine setting Otavio Salvador
2013-03-25 15:34 ` John Weber
2013-03-25 17:31 ` Otavio Salvador
2013-03-25 18:27 ` John Weber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.