[PATCH 0/3] Add DP related DT and Display-timing Node to exynos5250 based Arndale Board

[PATCH 0/3] Add DP related DT and Display-timing Node to exynos5250 based Arndale Board

[Vikas Sajjan]

This patch series adds support for DP on Exynos5250 based Arndale Board

Is based on branch "for-next"
http://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

Vikas Sajjan (3):
  ARM: dts: Add DT node for DP controller for Arndale Board
  ARM: dts: Add clock provider information for DP controller in
    Exynos5250 SoC
  ARM: dts: Add display timing node to exynos5250-arndale.dts

 arch/arm/boot/dts/exynos5250-arndale.dts |   26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos5250.dtsi        |    2 ++
 2 files changed, 28 insertions(+)

-- 
1.7.9.5

[PATCH 1/3] ARM: dts: Add DT node for DP controller for Arndale Board

[Vikas Sajjan]

Add DT node for DP controller to exynos5250 based Arndale Board

Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
 arch/arm/boot/dts/exynos5250-arndale.dts |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 02cfc76..f68b820 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -449,4 +449,14 @@
 			clock-frequency = <24000000>;
 		};
 	};
+
+	dp-controller {
+		samsung,color-space = <0>;
+		samsung,dynamic-range = <0>;
+		samsung,ycbcr-coeff = <0>;
+		samsung,color-depth = <1>;
+		samsung,link-rate = <0x0a>;
+		samsung,lane-count = <4>;
+	};
+
 };
-- 
1.7.9.5

Re: [PATCH 1/3] ARM: dts: Add DT node for DP controller for Arndale Board

[Jingoo Han]

On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
> 
> Add DT node for DP controller to exynos5250 based Arndale Board
> 
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>

Hi Vikas Sajjan,

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  arch/arm/boot/dts/exynos5250-arndale.dts |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> index 02cfc76..f68b820 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -449,4 +449,14 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +
> +	dp-controller {
> +		samsung,color-space = <0>;
> +		samsung,dynamic-range = <0>;
> +		samsung,ycbcr-coeff = <0>;
> +		samsung,color-depth = <1>;
> +		samsung,link-rate = <0x0a>;
> +		samsung,lane-count = <4>;
> +	};
> +
>  };
> --
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/3] ARM: dts: Add DT node for DP controller for Arndale Board

[Kukjin Kim]

Jingoo Han wrote:
> 
> On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
> >
> > Add DT node for DP controller to exynos5250 based Arndale Board
> >
> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> 
> Hi Vikas Sajjan,
> 
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> 
Applied, thanks.

- Kukjin

> Best regards,
> Jingoo Han
> 
> > ---
> >  arch/arm/boot/dts/exynos5250-arndale.dts |   10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> b/arch/arm/boot/dts/exynos5250-arndale.dts
> > index 02cfc76..f68b820 100644
> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> > @@ -449,4 +449,14 @@
> >  			clock-frequency = <24000000>;
> >  		};
> >  	};
> > +
> > +	dp-controller {
> > +		samsung,color-space = <0>;
> > +		samsung,dynamic-range = <0>;
> > +		samsung,ycbcr-coeff = <0>;
> > +		samsung,color-depth = <1>;
> > +		samsung,link-rate = <0x0a>;
> > +		samsung,lane-count = <4>;
> > +	};
> > +
> >  };
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-samsung-
> soc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/3] ARM: dts: Add DT node for DP controller for Arndale Board

[Kukjin Kim]

Kukjin Kim wrote:
> 
> Jingoo Han wrote:
> >
> > On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
> > >
> > > Add DT node for DP controller to exynos5250 based Arndale Board
> > >
> > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> >
> > Hi Vikas Sajjan,
> >
> > Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> >
> Applied, thanks.
> 
Ooops, already v2 series in my tree :-(

> - Kukjin
> 
> > Best regards,
> > Jingoo Han
> >
> > > ---
> > >  arch/arm/boot/dts/exynos5250-arndale.dts |   10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> > b/arch/arm/boot/dts/exynos5250-arndale.dts
> > > index 02cfc76..f68b820 100644
> > > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> > > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> > > @@ -449,4 +449,14 @@
> > >  			clock-frequency = <24000000>;
> > >  		};
> > >  	};
> > > +
> > > +	dp-controller {
> > > +		samsung,color-space = <0>;
> > > +		samsung,dynamic-range = <0>;
> > > +		samsung,ycbcr-coeff = <0>;
> > > +		samsung,color-depth = <1>;
> > > +		samsung,link-rate = <0x0a>;
> > > +		samsung,lane-count = <4>;
> > > +	};
> > > +
> > >  };
> > > --
> > > 1.7.9.5
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-
> samsung-
> > soc" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] ARM: dts: Add clock provider information for DP controller in Exynos5250 SoC

[Vikas Sajjan]

Adds clock provider information for DP controller required by CCF.

Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 4bd9e9c..2773d22 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -651,6 +651,8 @@
 		reg = <0x145b0000 0x1000>;
 		interrupts = <10 3>;
 		interrupt-parent = <&combiner>;
+		clocks = <&clock 342>;
+		clock-names = "dp";
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-- 
1.7.9.5

Re: [PATCH 2/3] ARM: dts: Add clock provider information for DP controller in Exynos5250 SoC

[Jingoo Han]

On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
> 
> Adds clock provider information for DP controller required by CCF.
> 
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>

Hi Vikas Sajjan,

Acked-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  arch/arm/boot/dts/exynos5250.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 4bd9e9c..2773d22 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -651,6 +651,8 @@
>  		reg = <0x145b0000 0x1000>;
>  		interrupts = <10 3>;
>  		interrupt-parent = <&combiner>;
> +		clocks = <&clock 342>;
> +		clock-names = "dp";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> 
> --
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/3] ARM: dts: Add clock provider information for DP controller in Exynos5250 SoC

[Kukjin Kim]

Jingoo Han wrote:
> 
> On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote:
> >
> > Adds clock provider information for DP controller required by CCF.
> >
> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> > Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> 
> Hi Vikas Sajjan,
> 
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> 
Applied, thanks.

- Kukjin


> Best regards,
> Jingoo Han
> 
> > ---
> >  arch/arm/boot/dts/exynos5250.dtsi |    2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> > index 4bd9e9c..2773d22 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -651,6 +651,8 @@
> >  		reg = <0x145b0000 0x1000>;
> >  		interrupts = <10 3>;
> >  		interrupt-parent = <&combiner>;
> > +		clocks = <&clock 342>;
> > +		clock-names = "dp";
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> >
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-samsung-
> soc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

Adds display timing node for a DP panel to Arndale Board DTS file

Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
 arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index f68b820..c831a5c 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -459,4 +459,20 @@
 		samsung,lane-count = <4>;
 	};
 
+	display-timings {
+		native-mode = <&timing0>;
+		timing0: timing@0 {
+			/* 2560x1600 DP panel */
+			clock-frequency = <50000>;
+			hactive = <2560>;
+			vactive = <1600>;
+			hfront-porch = <48>;
+			hback-porch = <80>;
+			hsync-len = <32>;
+			vback-porch = <16>;
+			vfront-porch = <8>;
+			vsync-len = <6>;
+		};
+	};
+
 };
-- 
1.7.9.5

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Tomasz Figa]

Hi Vikas,

On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> Adds display timing node for a DP panel to Arndale Board DTS file
> 
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
>  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
> 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -459,4 +459,20 @@
>  		samsung,lane-count = <4>;
>  	};
> 
> +	display-timings {
> +		native-mode = <&timing0>;
> +		timing0: timing@0 {
> +			/* 2560x1600 DP panel */
> +			clock-frequency = <50000>;
> +			hactive = <2560>;
> +			vactive = <1600>;
> +			hfront-porch = <48>;
> +			hback-porch = <80>;
> +			hsync-len = <32>;
> +			vback-porch = <16>;
> +			vfront-porch = <8>;
> +			vsync-len = <6>;
> +		};
> +	};

What display are those timings used for? Shouldn't they be placed inside 
node of that display?

Best regards,
Tomasz

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

[-- Attachment #1.1: Type: text/plain, Size: 2218 bytes --]

Hi Tomasz,


On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> Hi Vikas,
>
> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> > Adds display timing node for a DP panel to Arndale Board DTS file
> >
> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
> > 100644
> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> > @@ -459,4 +459,20 @@
> >               samsung,lane-count = <4>;
> >       };
> >
> > +     display-timings {
> > +             native-mode = <&timing0>;
> > +             timing0: timing@0 {
> > +                     /* 2560x1600 DP panel */
> > +                     clock-frequency = <50000>;
> > +                     hactive = <2560>;
> > +                     vactive = <1600>;
> > +                     hfront-porch = <48>;
> > +                     hback-porch = <80>;
> > +                     hsync-len = <32>;
> > +                     vback-porch = <16>;
> > +                     vfront-porch = <8>;
> > +                     vsync-len = <6>;
> > +             };
> > +     };
>
> What display are those timings used for? Shouldn't they be placed inside
> node of that display?
>
>
This timing information will be used parsed by the FIMD probe with the help
of "Video Helper function"  as done in this link

https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0

Please refer to this patch which is used for exynos4412-origen and
exynos5250-smdk5250 respectively in similar way

https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338

https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c



Best regards,
> Tomasz
>
>


-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 3629 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

[-- Attachment #1.1: Type: text/plain, Size: 2544 bytes --]

Hi Tomasz,

On 10 May 2013 08:25, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:

> Hi Tomasz,
>
>
> On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> Hi Vikas,
>>
>> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
>> > Adds display timing node for a DP panel to Arndale Board DTS file
>> >
>> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> > ---
>> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
>> >  1 file changed, 16 insertions(+)
>> >
>> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
>> > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
>> > 100644
>> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> > @@ -459,4 +459,20 @@
>> >               samsung,lane-count = <4>;
>> >       };
>> >
>> > +     display-timings {
>> > +             native-mode = <&timing0>;
>> > +             timing0: timing@0 {
>> > +                     /* 2560x1600 DP panel */
>> > +                     clock-frequency = <50000>;
>> > +                     hactive = <2560>;
>> > +                     vactive = <1600>;
>> > +                     hfront-porch = <48>;
>> > +                     hback-porch = <80>;
>> > +                     hsync-len = <32>;
>> > +                     vback-porch = <16>;
>> > +                     vfront-porch = <8>;
>> > +                     vsync-len = <6>;
>> > +             };
>> > +     };
>>
>> What display are those timings used for? Shouldn't they be placed inside
>> node of that display?
>>
>> This timing information will be used parsed by the FIMD probe with the
> help of "Video Helper function"  as done in this link
>
>
> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
>
> Please refer to this patch which is used for exynos4412-origen and
> exynos5250-smdk5250 respectively in similar way
>
>
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338
>
>
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c
>
> And also you can refer to
> Documentation/devicetree/bindings/video/display-timing.txt
>


>
> Best regards,
>> Tomasz
>>
>>
>
>
> --
> Thanks and Regards
>  Vikas Sajjan
>



-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 4687 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Olof Johansson]

On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> Hi Tomasz,
>
>
> On 10 May 2013 05:35, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>>
>> Hi Vikas,
>>
>> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
>> > Adds display timing node for a DP panel to Arndale Board DTS file
>> >
>> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> > ---
>> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
>> >  1 file changed, 16 insertions(+)
>> >
>> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
>> > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
>> > 100644
>> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> > @@ -459,4 +459,20 @@
>> >               samsung,lane-count = <4>;
>> >       };
>> >
>> > +     display-timings {
>> > +             native-mode = <&timing0>;
>> > +             timing0: timing@0 {
>> > +                     /* 2560x1600 DP panel */
>> > +                     clock-frequency = <50000>;
>> > +                     hactive = <2560>;
>> > +                     vactive = <1600>;
>> > +                     hfront-porch = <48>;
>> > +                     hback-porch = <80>;
>> > +                     hsync-len = <32>;
>> > +                     vback-porch = <16>;
>> > +                     vfront-porch = <8>;
>> > +                     vsync-len = <6>;
>> > +             };
>> > +     };
>>
>> What display are those timings used for? Shouldn't they be placed inside
>> node of that display?
>>
>
> This timing information will be used parsed by the FIMD probe with the help
> of "Video Helper function"  as done in this link
>
> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0

That function passes in a device node pointer to the FIMD device node,
and only looks for a display-timings node under there. Tomasz is
right, as far as I can tell.

Placing display timings at the root of the device tree seems completely wrong.

> Please refer to this patch which is used for exynos4412-origen and
> exynos5250-smdk5250 respectively in similar way
>
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338
>
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c

That needs to be fixed up as well, thanks for pointing it out.


-Olof

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

[-- Attachment #1.1: Type: text/plain, Size: 2925 bytes --]

Hi Olof,


On 10 May 2013 11:08, Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> wrote:

> On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> wrote:
> > Hi Tomasz,
> >
> >
> > On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >>
> >> Hi Vikas,
> >>
> >> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> >> > Adds display timing node for a DP panel to Arndale Board DTS file
> >> >
> >> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >> > ---
> >> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
> >> >  1 file changed, 16 insertions(+)
> >> >
> >> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> >> > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
> >> > 100644
> >> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> >> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> >> > @@ -459,4 +459,20 @@
> >> >               samsung,lane-count = <4>;
> >> >       };
> >> >
> >> > +     display-timings {
> >> > +             native-mode = <&timing0>;
> >> > +             timing0: timing@0 {
> >> > +                     /* 2560x1600 DP panel */
> >> > +                     clock-frequency = <50000>;
> >> > +                     hactive = <2560>;
> >> > +                     vactive = <1600>;
> >> > +                     hfront-porch = <48>;
> >> > +                     hback-porch = <80>;
> >> > +                     hsync-len = <32>;
> >> > +                     vback-porch = <16>;
> >> > +                     vfront-porch = <8>;
> >> > +                     vsync-len = <6>;
> >> > +             };
> >> > +     };
> >>
> >> What display are those timings used for? Shouldn't they be placed inside
> >> node of that display?
> >>
> >
> > This timing information will be used parsed by the FIMD probe with the
> help
> > of "Video Helper function"  as done in this link
> >
> >
> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
>
> That function passes in a device node pointer to the FIMD device node,
> and only looks for a display-timings node under there. Tomasz is
> right, as far as I can tell.
>
> Placing display timings at the root of the device tree seems completely
> wrong.
>
>

> > Please refer to this patch which is used for exynos4412-origen and
> > exynos5250-smdk5250 respectively in similar way
> >
> >
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338
> >
> >
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c
>
> That needs to be fixed up as well, thanks for pointing it out.
>
>
> -Olof
>



-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 4891 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

[-- Attachment #1.1: Type: text/plain, Size: 3447 bytes --]

Hi Olof,


On 10 May 2013 11:51, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:

> Hi Olof,
>
>
> On 10 May 2013 11:08, Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> wrote:
>
>> On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> wrote:
>> > Hi Tomasz,
>> >
>> >
>> > On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> >>
>> >> Hi Vikas,
>> >>
>> >> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
>> >> > Adds display timing node for a DP panel to Arndale Board DTS file
>> >> >
>> >> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> >> > ---
>> >> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
>> >> >  1 file changed, 16 insertions(+)
>> >> >
>> >> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
>> >> > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
>> >> > 100644
>> >> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>> >> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> >> > @@ -459,4 +459,20 @@
>> >> >               samsung,lane-count = <4>;
>> >> >       };
>> >> >
>> >> > +     display-timings {
>> >> > +             native-mode = <&timing0>;
>> >> > +             timing0: timing@0 {
>> >> > +                     /* 2560x1600 DP panel */
>> >> > +                     clock-frequency = <50000>;
>> >> > +                     hactive = <2560>;
>> >> > +                     vactive = <1600>;
>> >> > +                     hfront-porch = <48>;
>> >> > +                     hback-porch = <80>;
>> >> > +                     hsync-len = <32>;
>> >> > +                     vback-porch = <16>;
>> >> > +                     vfront-porch = <8>;
>> >> > +                     vsync-len = <6>;
>> >> > +             };
>> >> > +     };
>> >>
>> >> What display are those timings used for? Shouldn't they be placed
>> inside
>> >> node of that display?
>> >>
>> >
>> > This timing information will be used parsed by the FIMD probe with the
>> help
>> > of "Video Helper function"  as done in this link
>> >
>> >
>> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
>>
>> That function passes in a device node pointer to the FIMD device node,
>> and only looks for a display-timings node under there. Tomasz is
>> right, as far as I can tell.
>>
>> Placing display timings at the root of the device tree seems completely
>> wrong.
>>
>>         I referred this "
Documentation/devicetree/bindings/video/display-timing.txt" for example

            here it dosen't mention about whether display timings node can
be placed at the root of the device tree or NOT.
 Not sure how we should be placing the node then.


>
>
>> > Please refer to this patch which is used for exynos4412-origen and
>> > exynos5250-smdk5250 respectively in similar way
>> >
>> >
>> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338
>> >
>> >
>> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c
>>
>> That needs to be fixed up as well, thanks for pointing it out.
>>
>>
>> -Olof
>>
>
>
>
> --
> Thanks and Regards
>  Vikas Sajjan
>



-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 6271 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Tomasz Figa]

On Friday 10 of May 2013 11:57:34 Vikas Sajjan wrote:
> Hi Olof,
> 
> On 10 May 2013 11:51, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> > Hi Olof,
> > 
> > On 10 May 2013 11:08, Olof Johansson <olof@lixom.net> wrote:
> >> On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan
> >> <vikas.sajjan@linaro.org>
> >> 
> >> wrote:
> >> > Hi Tomasz,
> >> > 
> >> > On 10 May 2013 05:35, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >> >> Hi Vikas,
> >> >> 
> >> >> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> >> >> > Adds display timing node for a DP panel to Arndale Board DTS
> >> >> > file
> >> >> > 
> >> >> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> >> >> > ---
> >> >> > 
> >> >> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16
> >> >> >  ++++++++++++++++
> >> >> >  1 file changed, 16 insertions(+)
> >> >> > 
> >> >> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> >> >> > b/arch/arm/boot/dts/exynos5250-arndale.dts index
> >> >> > f68b820..c831a5c
> >> >> > 100644
> >> >> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> >> >> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> >> >> > @@ -459,4 +459,20 @@
> >> >> > 
> >> >> >               samsung,lane-count = <4>;
> >> >> >       
> >> >> >       };
> >> >> > 
> >> >> > +     display-timings {
> >> >> > +             native-mode = <&timing0>;
> >> >> > +             timing0: timing@0 {
> >> >> > +                     /* 2560x1600 DP panel */
> >> >> > +                     clock-frequency = <50000>;
> >> >> > +                     hactive = <2560>;
> >> >> > +                     vactive = <1600>;
> >> >> > +                     hfront-porch = <48>;
> >> >> > +                     hback-porch = <80>;
> >> >> > +                     hsync-len = <32>;
> >> >> > +                     vback-porch = <16>;
> >> >> > +                     vfront-porch = <8>;
> >> >> > +                     vsync-len = <6>;
> >> >> > +             };
> >> >> > +     };
> >> >> 
> >> >> What display are those timings used for? Shouldn't they be placed
> >> 
> >> inside
> >> 
> >> >> node of that display?
> >> > 
> >> > This timing information will be used parsed by the FIMD probe with
> >> > the
> >> 
> >> help
> >> 
> >> > of "Video Helper function"  as done in this link
> >> 
> >> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/c
> >> ommit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
> >> 
> >> That function passes in a device node pointer to the FIMD device
> >> node,
> >> and only looks for a display-timings node under there. Tomasz is
> >> right, as far as I can tell.
> >> 
> >> Placing display timings at the root of the device tree seems
> >> completely
> >> wrong.
> >> 
> >>         I referred this "
> 
> Documentation/devicetree/bindings/video/display-timing.txt" for example
> 
>             here it dosen't mention about whether display timings node
> can be placed at the root of the device tree or NOT.
>  Not sure how we should be placing the node then.

I think this is pretty obvious.

Imagine a bit more complex case: a board has two video outputs (let's say 
FIMD0 and FIMD1), each connected to a completely different display. This 
means that each display needs different timings.

How would you know which timings to use if all of them were be placed 
under the root node?

Best regards,
Tomasz

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

[-- Attachment #1.1: Type: text/plain, Size: 3923 bytes --]

HI Tomasz,


On 10 May 2013 13:03, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Friday 10 of May 2013 11:57:34 Vikas Sajjan wrote:
> > Hi Olof,
> >
> > On 10 May 2013 11:51, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > > Hi Olof,
> > >
> > > On 10 May 2013 11:08, Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> wrote:
> > >> On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan
> > >> <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > >>
> > >> wrote:
> > >> > Hi Tomasz,
> > >> >
> > >> > On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > >> >> Hi Vikas,
> > >> >>
> > >> >> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> > >> >> > Adds display timing node for a DP panel to Arndale Board DTS
> > >> >> > file
> > >> >> >
> > >> >> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > >> >> > ---
> > >> >> >
> > >> >> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16
> > >> >> >  ++++++++++++++++
> > >> >> >  1 file changed, 16 insertions(+)
> > >> >> >
> > >> >> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> > >> >> > b/arch/arm/boot/dts/exynos5250-arndale.dts index
> > >> >> > f68b820..c831a5c
> > >> >> > 100644
> > >> >> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> > >> >> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> > >> >> > @@ -459,4 +459,20 @@
> > >> >> >
> > >> >> >               samsung,lane-count = <4>;
> > >> >> >
> > >> >> >       };
> > >> >> >
> > >> >> > +     display-timings {
> > >> >> > +             native-mode = <&timing0>;
> > >> >> > +             timing0: timing@0 {
> > >> >> > +                     /* 2560x1600 DP panel */
> > >> >> > +                     clock-frequency = <50000>;
> > >> >> > +                     hactive = <2560>;
> > >> >> > +                     vactive = <1600>;
> > >> >> > +                     hfront-porch = <48>;
> > >> >> > +                     hback-porch = <80>;
> > >> >> > +                     hsync-len = <32>;
> > >> >> > +                     vback-porch = <16>;
> > >> >> > +                     vfront-porch = <8>;
> > >> >> > +                     vsync-len = <6>;
> > >> >> > +             };
> > >> >> > +     };
> > >> >>
> > >> >> What display are those timings used for? Shouldn't they be placed
> > >>
> > >> inside
> > >>
> > >> >> node of that display?
> > >> >
> > >> > This timing information will be used parsed by the FIMD probe with
> > >> > the
> > >>
> > >> help
> > >>
> > >> > of "Video Helper function"  as done in this link
> > >>
> > >> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/c
> > >> ommit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
> > >>
> > >> That function passes in a device node pointer to the FIMD device
> > >> node,
> > >> and only looks for a display-timings node under there. Tomasz is
> > >> right, as far as I can tell.
> > >>
> > >> Placing display timings at the root of the device tree seems
> > >> completely
> > >> wrong.
> > >>
> > >>         I referred this "
> >
> > Documentation/devicetree/bindings/video/display-timing.txt" for example
> >
> >             here it dosen't mention about whether display timings node
> > can be placed at the root of the device tree or NOT.
> >  Not sure how we should be placing the node then.
>
> I think this is pretty obvious.
>
> Imagine a bit more complex case: a board has two video outputs (let's say
> FIMD0 and FIMD1), each connected to a completely different display. This
> means that each display needs different timings.
>
> How would you know which timings to use if all of them were be placed
> under the root node?
>
>     so what do you think, how  should we modify this patch so that it
belongs to a specific video outputs.

Best regards,
> Tomasz
>
>


-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 6391 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

[-- Attachment #1.1: Type: text/plain, Size: 4439 bytes --]

Hi Steffen Trumtrar and Sascha Hauer,

Olof and Tomasz Figa have a concern in putting "display-timings"  as root
node in device tree file.


On 10 May 2013 13:45, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:

> HI Tomasz,
>
>
> On 10 May 2013 13:03, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> On Friday 10 of May 2013 11:57:34 Vikas Sajjan wrote:
>> > Hi Olof,
>> >
>> > On 10 May 2013 11:51, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> > > Hi Olof,
>> > >
>> > > On 10 May 2013 11:08, Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> wrote:
>> > >> On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan
>> > >> <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> > >>
>> > >> wrote:
>> > >> > Hi Tomasz,
>> > >> >
>> > >> > On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> > >> >> Hi Vikas,
>> > >> >>
>> > >> >> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
>> > >> >> > Adds display timing node for a DP panel to Arndale Board DTS
>> > >> >> > file
>> > >> >> >
>> > >> >> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> > >> >> > ---
>> > >> >> >
>> > >> >> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16
>> > >> >> >  ++++++++++++++++
>> > >> >> >  1 file changed, 16 insertions(+)
>> > >> >> >
>> > >> >> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
>> > >> >> > b/arch/arm/boot/dts/exynos5250-arndale.dts index
>> > >> >> > f68b820..c831a5c
>> > >> >> > 100644
>> > >> >> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>> > >> >> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> > >> >> > @@ -459,4 +459,20 @@
>> > >> >> >
>> > >> >> >               samsung,lane-count = <4>;
>> > >> >> >
>> > >> >> >       };
>> > >> >> >
>> > >> >> > +     display-timings {
>> > >> >> > +             native-mode = <&timing0>;
>> > >> >> > +             timing0: timing@0 {
>> > >> >> > +                     /* 2560x1600 DP panel */
>> > >> >> > +                     clock-frequency = <50000>;
>> > >> >> > +                     hactive = <2560>;
>> > >> >> > +                     vactive = <1600>;
>> > >> >> > +                     hfront-porch = <48>;
>> > >> >> > +                     hback-porch = <80>;
>> > >> >> > +                     hsync-len = <32>;
>> > >> >> > +                     vback-porch = <16>;
>> > >> >> > +                     vfront-porch = <8>;
>> > >> >> > +                     vsync-len = <6>;
>> > >> >> > +             };
>> > >> >> > +     };
>> > >> >>
>> > >> >> What display are those timings used for? Shouldn't they be placed
>> > >>
>> > >> inside
>> > >>
>> > >> >> node of that display?
>> > >> >
>> > >> > This timing information will be used parsed by the FIMD probe with
>> > >> > the
>> > >>
>> > >> help
>> > >>
>> > >> > of "Video Helper function"  as done in this link
>> > >>
>> > >>
>> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/c
>> > >> ommit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
>> > >>
>> > >> That function passes in a device node pointer to the FIMD device
>> > >> node,
>> > >> and only looks for a display-timings node under there. Tomasz is
>> > >> right, as far as I can tell.
>> > >>
>> > >> Placing display timings at the root of the device tree seems
>> > >> completely
>> > >> wrong.
>> > >>
>> > >>         I referred this "
>> >
>> > Documentation/devicetree/bindings/video/display-timing.txt" for example
>> >
>> >             here it dosen't mention about whether display timings node
>> > can be placed at the root of the device tree or NOT.
>> >  Not sure how we should be placing the node then.
>>
>> I think this is pretty obvious.
>>
>> Imagine a bit more complex case: a board has two video outputs (let's say
>> FIMD0 and FIMD1), each connected to a completely different display. This
>> means that each display needs different timings.
>>
>> How would you know which timings to use if all of them were be placed
>> under the root node?
>>
>>     so what do you think, how  should we modify this patch so that it
> belongs to a specific video outputs.
>
>

  So what do you think, how should we modify this patch so that it belongs
to a specific video outputs.




>  Best regards,
>> Tomasz
>>
>>
>
>
> --
> Thanks and Regards
>  Vikas Sajjan
>



-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 7657 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Steffen Trumtrar]

Hi!

On Tue, May 14, 2013 at 06:40:00PM +0530, Vikas Sajjan wrote:
> Hi Steffen Trumtrar and Sascha Hauer,
> 
> Olof and Tomasz Figa have a concern in putting "display-timings"  as root
> node in device tree file.
> 
> 
> On 10 May 2013 13:45, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> 
> > HI Tomasz,
> >
> >
> > On 10 May 2013 13:03, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >
> >> On Friday 10 of May 2013 11:57:34 Vikas Sajjan wrote:
> >> > Hi Olof,
> >> >
> >> > On 10 May 2013 11:51, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> >> > > Hi Olof,
> >> > >
> >> > > On 10 May 2013 11:08, Olof Johansson <olof@lixom.net> wrote:
> >> > >> On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan
> >> > >> <vikas.sajjan@linaro.org>
> >> > >>
> >> > >> wrote:
> >> > >> > Hi Tomasz,
> >> > >> >
> >> > >> > On 10 May 2013 05:35, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >> > >> >> Hi Vikas,
> >> > >> >>
> >> > >> >> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> >> > >> >> > Adds display timing node for a DP panel to Arndale Board DTS
> >> > >> >> > file
> >> > >> >> >
> >> > >> >> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> >> > >> >> > ---
> >> > >> >> >
> >> > >> >> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16
> >> > >> >> >  ++++++++++++++++
> >> > >> >> >  1 file changed, 16 insertions(+)
> >> > >> >> >
> >> > >> >> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> >> > >> >> > b/arch/arm/boot/dts/exynos5250-arndale.dts index
> >> > >> >> > f68b820..c831a5c
> >> > >> >> > 100644
> >> > >> >> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> >> > >> >> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> >> > >> >> > @@ -459,4 +459,20 @@
> >> > >> >> >
> >> > >> >> >               samsung,lane-count = <4>;
> >> > >> >> >
> >> > >> >> >       };
> >> > >> >> >
> >> > >> >> > +     display-timings {
> >> > >> >> > +             native-mode = <&timing0>;
> >> > >> >> > +             timing0: timing@0 {
> >> > >> >> > +                     /* 2560x1600 DP panel */
> >> > >> >> > +                     clock-frequency = <50000>;
> >> > >> >> > +                     hactive = <2560>;
> >> > >> >> > +                     vactive = <1600>;
> >> > >> >> > +                     hfront-porch = <48>;
> >> > >> >> > +                     hback-porch = <80>;
> >> > >> >> > +                     hsync-len = <32>;
> >> > >> >> > +                     vback-porch = <16>;
> >> > >> >> > +                     vfront-porch = <8>;
> >> > >> >> > +                     vsync-len = <6>;
> >> > >> >> > +             };
> >> > >> >> > +     };
> >> > >> >>
> >> > >> >> What display are those timings used for? Shouldn't they be placed
> >> > >>
> >> > >> inside
> >> > >>
> >> > >> >> node of that display?
> >> > >> >
> >> > >> > This timing information will be used parsed by the FIMD probe with
> >> > >> > the
> >> > >>
> >> > >> help
> >> > >>
> >> > >> > of "Video Helper function"  as done in this link
> >> > >>
> >> > >>
> >> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/c
> >> > >> ommit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
> >> > >>
> >> > >> That function passes in a device node pointer to the FIMD device
> >> > >> node,
> >> > >> and only looks for a display-timings node under there. Tomasz is
> >> > >> right, as far as I can tell.
> >> > >>
> >> > >> Placing display timings at the root of the device tree seems
> >> > >> completely
> >> > >> wrong.
> >> > >>
> >> > >>         I referred this "
> >> >
> >> > Documentation/devicetree/bindings/video/display-timing.txt" for example
> >> >
> >> >             here it dosen't mention about whether display timings node
> >> > can be placed at the root of the device tree or NOT.
> >> >  Not sure how we should be placing the node then.
> >>
> >> I think this is pretty obvious.
> >>
> >> Imagine a bit more complex case: a board has two video outputs (let's say
> >> FIMD0 and FIMD1), each connected to a completely different display. This
> >> means that each display needs different timings.
> >>
> >> How would you know which timings to use if all of them were be placed
> >> under the root node?
> >>
> >>     so what do you think, how  should we modify this patch so that it
> > belongs to a specific video outputs.
> >
> >
> 
>   So what do you think, how should we modify this patch so that it belongs
> to a specific video outputs.
> 
 Something like

	&fimd {
		display-timings {
			timing0: timing@0 {
				/* 2560x1600 DP panel */
				clock-frequency = <50000>;
				hactive = <2560>;
				vactive = <1600>;
				hfront-porch = <48>;
				(...)
			};
		};
	};

Would be correct, if fimd is the output on which the display is connected.
The fimd driver than has to utilize of_get_display_timings, of_get_fb_videomode
or something like that.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

[Vikas Sajjan]

[-- Attachment #1.1: Type: text/plain, Size: 6088 bytes --]

Thanks, we test and resend v2 patchset.


On 14 May 2013 18:55, Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:

> Hi!
>
> On Tue, May 14, 2013 at 06:40:00PM +0530, Vikas Sajjan wrote:
> > Hi Steffen Trumtrar and Sascha Hauer,
> >
> > Olof and Tomasz Figa have a concern in putting "display-timings"  as root
> > node in device tree file.
> >
> >
> > On 10 May 2013 13:45, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> >
> > > HI Tomasz,
> > >
> > >
> > > On 10 May 2013 13:03, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > >
> > >> On Friday 10 of May 2013 11:57:34 Vikas Sajjan wrote:
> > >> > Hi Olof,
> > >> >
> > >> > On 10 May 2013 11:51, Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > >> > > Hi Olof,
> > >> > >
> > >> > > On 10 May 2013 11:08, Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> wrote:
> > >> > >> On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan
> > >> > >> <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > >> > >>
> > >> > >> wrote:
> > >> > >> > Hi Tomasz,
> > >> > >> >
> > >> > >> > On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> wrote:
> > >> > >> >> Hi Vikas,
> > >> > >> >>
> > >> > >> >> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> > >> > >> >> > Adds display timing node for a DP panel to Arndale Board DTS
> > >> > >> >> > file
> > >> > >> >> >
> > >> > >> >> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > >> > >> >> > ---
> > >> > >> >> >
> > >> > >> >> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16
> > >> > >> >> >  ++++++++++++++++
> > >> > >> >> >  1 file changed, 16 insertions(+)
> > >> > >> >> >
> > >> > >> >> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> > >> > >> >> > b/arch/arm/boot/dts/exynos5250-arndale.dts index
> > >> > >> >> > f68b820..c831a5c
> > >> > >> >> > 100644
> > >> > >> >> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> > >> > >> >> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> > >> > >> >> > @@ -459,4 +459,20 @@
> > >> > >> >> >
> > >> > >> >> >               samsung,lane-count = <4>;
> > >> > >> >> >
> > >> > >> >> >       };
> > >> > >> >> >
> > >> > >> >> > +     display-timings {
> > >> > >> >> > +             native-mode = <&timing0>;
> > >> > >> >> > +             timing0: timing@0 {
> > >> > >> >> > +                     /* 2560x1600 DP panel */
> > >> > >> >> > +                     clock-frequency = <50000>;
> > >> > >> >> > +                     hactive = <2560>;
> > >> > >> >> > +                     vactive = <1600>;
> > >> > >> >> > +                     hfront-porch = <48>;
> > >> > >> >> > +                     hback-porch = <80>;
> > >> > >> >> > +                     hsync-len = <32>;
> > >> > >> >> > +                     vback-porch = <16>;
> > >> > >> >> > +                     vfront-porch = <8>;
> > >> > >> >> > +                     vsync-len = <6>;
> > >> > >> >> > +             };
> > >> > >> >> > +     };
> > >> > >> >>
> > >> > >> >> What display are those timings used for? Shouldn't they be
> placed
> > >> > >>
> > >> > >> inside
> > >> > >>
> > >> > >> >> node of that display?
> > >> > >> >
> > >> > >> > This timing information will be used parsed by the FIMD probe
> with
> > >> > >> > the
> > >> > >>
> > >> > >> help
> > >> > >>
> > >> > >> > of "Video Helper function"  as done in this link
> > >> > >>
> > >> > >>
> > >> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/c
> > >> > >>
> ommit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0
> > >> > >>
> > >> > >> That function passes in a device node pointer to the FIMD device
> > >> > >> node,
> > >> > >> and only looks for a display-timings node under there. Tomasz is
> > >> > >> right, as far as I can tell.
> > >> > >>
> > >> > >> Placing display timings at the root of the device tree seems
> > >> > >> completely
> > >> > >> wrong.
> > >> > >>
> > >> > >>         I referred this "
> > >> >
> > >> > Documentation/devicetree/bindings/video/display-timing.txt" for
> example
> > >> >
> > >> >             here it dosen't mention about whether display timings
> node
> > >> > can be placed at the root of the device tree or NOT.
> > >> >  Not sure how we should be placing the node then.
> > >>
> > >> I think this is pretty obvious.
> > >>
> > >> Imagine a bit more complex case: a board has two video outputs (let's
> say
> > >> FIMD0 and FIMD1), each connected to a completely different display.
> This
> > >> means that each display needs different timings.
> > >>
> > >> How would you know which timings to use if all of them were be placed
> > >> under the root node?
> > >>
> > >>     so what do you think, how  should we modify this patch so that it
> > > belongs to a specific video outputs.
> > >
> > >
> >
> >   So what do you think, how should we modify this patch so that it
> belongs
> > to a specific video outputs.
> >
>  Something like
>
>         &fimd {
>                 display-timings {
>                         timing0: timing@0 {
>                                 /* 2560x1600 DP panel */
>                                 clock-frequency = <50000>;
>                                 hactive = <2560>;
>                                 vactive = <1600>;
>                                 hfront-porch = <48>;
>                                 (...)
>                         };
>                 };
>         };
>
> Would be correct, if fimd is the output on which the display is connected.
> The fimd driver than has to utilize of_get_display_timings,
> of_get_fb_videomode
> or something like that.
>
> Regards,
> Steffen
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>



-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 9870 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss