* [PATCH net-next 0/2] Xen network: split event channels support
@ 2013-05-20 23:02 Wei Liu
0 siblings, 0 replies; 12+ messages in thread
From: Wei Liu @ 2013-05-20 23:02 UTC (permalink / raw)
To: xen-devel, netdev; +Cc: Wei Liu, ian.campbell, konrad.wilk
This series adds a new feature called split event channels.
In the original implementation, only one event channel is setup between
frontend and backend. This is not ideal as TX notification interferes with RX
notification. Using dedicated event channels for TX and RX solves this issue.
Wei Liu (2):
xen-netback: split event channels feature support
xen-netfront: split event channels feature support
drivers/net/xen-netback/common.h | 11 ++-
drivers/net/xen-netback/interface.c | 87 ++++++++++++++---
drivers/net/xen-netback/netback.c | 7 +-
drivers/net/xen-netback/xenbus.c | 40 ++++++--
drivers/net/xen-netfront.c | 181 +++++++++++++++++++++++++++++------
5 files changed, 269 insertions(+), 57 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH net-next 0/2] Xen network: split event channels support
@ 2013-05-20 23:02 Wei Liu
2013-05-21 6:27 ` David Miller
2013-05-21 6:27 ` David Miller
0 siblings, 2 replies; 12+ messages in thread
From: Wei Liu @ 2013-05-20 23:02 UTC (permalink / raw)
To: xen-devel, netdev; +Cc: ian.campbell, konrad.wilk, Wei Liu
This series adds a new feature called split event channels.
In the original implementation, only one event channel is setup between
frontend and backend. This is not ideal as TX notification interferes with RX
notification. Using dedicated event channels for TX and RX solves this issue.
Wei Liu (2):
xen-netback: split event channels feature support
xen-netfront: split event channels feature support
drivers/net/xen-netback/common.h | 11 ++-
drivers/net/xen-netback/interface.c | 87 ++++++++++++++---
drivers/net/xen-netback/netback.c | 7 +-
drivers/net/xen-netback/xenbus.c | 40 ++++++--
drivers/net/xen-netfront.c | 181 +++++++++++++++++++++++++++++------
5 files changed, 269 insertions(+), 57 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-20 23:02 Wei Liu
@ 2013-05-21 6:27 ` David Miller
2013-05-21 6:27 ` David Miller
1 sibling, 0 replies; 12+ messages in thread
From: David Miller @ 2013-05-21 6:27 UTC (permalink / raw)
To: wei.liu2; +Cc: netdev, konrad.wilk, ian.campbell, xen-devel
If you use the same exact subject line in all of your patches in the
series, nobody reading the shortlog can tell what's different about
them.
You absolutely must resubmit this with more descriptive subject lines
which more accurately describe what each patch uniquely does.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-20 23:02 Wei Liu
2013-05-21 6:27 ` David Miller
@ 2013-05-21 6:27 ` David Miller
2013-05-21 8:00 ` Wei Liu
2013-05-21 8:00 ` Wei Liu
1 sibling, 2 replies; 12+ messages in thread
From: David Miller @ 2013-05-21 6:27 UTC (permalink / raw)
To: wei.liu2; +Cc: xen-devel, netdev, ian.campbell, konrad.wilk
If you use the same exact subject line in all of your patches in the
series, nobody reading the shortlog can tell what's different about
them.
You absolutely must resubmit this with more descriptive subject lines
which more accurately describe what each patch uniquely does.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 6:27 ` David Miller
@ 2013-05-21 8:00 ` Wei Liu
2013-05-21 8:13 ` David Miller
` (3 more replies)
2013-05-21 8:00 ` Wei Liu
1 sibling, 4 replies; 12+ messages in thread
From: Wei Liu @ 2013-05-21 8:00 UTC (permalink / raw)
To: David Miller; +Cc: wei.liu2, xen-devel, netdev, ian.campbell, konrad.wilk
On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote:
>
> If you use the same exact subject line in all of your patches in the
> series, nobody reading the shortlog can tell what's different about
> them.
>
> You absolutely must resubmit this with more descriptive subject lines
> which more accurately describe what each patch uniquely does.
I'm not sure I get what you mean. Their subject lines look alike, but
not exactly the same.
So this patch set adds a new feature to Xen network device, which is
called split event channels. The subject lines of two patches, one for
frontend and one for backend, speak for themselves.
No matter how I change the subject lines, they will probably still look
alike except for the leading "xen-netfront / xen-netback". I can squash
them into one changeset if that better suits your workflow, but it is
better to leave them separate IMHO so that we can test them separately.
Advice welcomed.
Thanks
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 8:00 ` Wei Liu
@ 2013-05-21 8:13 ` David Miller
2013-05-21 8:13 ` David Miller
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2013-05-21 8:13 UTC (permalink / raw)
To: wei.liu2; +Cc: netdev, konrad.wilk, ian.campbell, xen-devel
From: Wei Liu <wei.liu2@citrix.com>
Date: Tue, 21 May 2013 09:00:40 +0100
> I'm not sure I get what you mean. Their subject lines look alike, but
> not exactly the same.
I see, the prefix is different, sorry about that.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 8:00 ` Wei Liu
2013-05-21 8:13 ` David Miller
@ 2013-05-21 8:13 ` David Miller
2013-05-21 8:17 ` Ian Campbell
2013-05-21 8:17 ` Ian Campbell
3 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2013-05-21 8:13 UTC (permalink / raw)
To: wei.liu2; +Cc: xen-devel, netdev, ian.campbell, konrad.wilk
From: Wei Liu <wei.liu2@citrix.com>
Date: Tue, 21 May 2013 09:00:40 +0100
> I'm not sure I get what you mean. Their subject lines look alike, but
> not exactly the same.
I see, the prefix is different, sorry about that.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 8:00 ` Wei Liu
2013-05-21 8:13 ` David Miller
2013-05-21 8:13 ` David Miller
@ 2013-05-21 8:17 ` Ian Campbell
2013-05-21 8:34 ` Wei Liu
2013-05-21 8:34 ` Wei Liu
2013-05-21 8:17 ` Ian Campbell
3 siblings, 2 replies; 12+ messages in thread
From: Ian Campbell @ 2013-05-21 8:17 UTC (permalink / raw)
To: Wei Liu; +Cc: David Miller, xen-devel, netdev, konrad.wilk
On Tue, 2013-05-21 at 09:00 +0100, Wei Liu wrote:
> On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote:
> >
> > If you use the same exact subject line in all of your patches in the
> > series, nobody reading the shortlog can tell what's different about
> > them.
> >
> > You absolutely must resubmit this with more descriptive subject lines
> > which more accurately describe what each patch uniquely does.
>
> I'm not sure I get what you mean. Their subject lines look alike, but
> not exactly the same.
>
> So this patch set adds a new feature to Xen network device, which is
> called split event channels. The subject lines of two patches, one for
> frontend and one for backend, speak for themselves.
This is true, but I wonder if peoples eyes tend to skip over the initial
prefix.
> No matter how I change the subject lines, they will probably still look
> alike except for the leading "xen-netfront / xen-netback". I can squash
> them into one changeset if that better suits your workflow, but it is
> better to leave them separate IMHO so that we can test them separately.
>
> Advice welcomed.
How about "xen-netback: Split event channel support for Xen Backend
driver" and the equivalent for frontend?
I'd prefer to keep it as two changesets if possible.
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 8:17 ` Ian Campbell
@ 2013-05-21 8:34 ` Wei Liu
2013-05-21 8:34 ` Wei Liu
1 sibling, 0 replies; 12+ messages in thread
From: Wei Liu @ 2013-05-21 8:34 UTC (permalink / raw)
To: Ian Campbell; +Cc: Wei Liu, David Miller, xen-devel, netdev, konrad.wilk
On Tue, May 21, 2013 at 09:17:35AM +0100, Ian Campbell wrote:
[...]
>
> How about "xen-netback: Split event channel support for Xen Backend
> driver" and the equivalent for frontend?
>
Sure, this can avoid future confusion.
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 8:17 ` Ian Campbell
2013-05-21 8:34 ` Wei Liu
@ 2013-05-21 8:34 ` Wei Liu
1 sibling, 0 replies; 12+ messages in thread
From: Wei Liu @ 2013-05-21 8:34 UTC (permalink / raw)
To: Ian Campbell; +Cc: netdev, konrad.wilk, Wei Liu, David Miller, xen-devel
On Tue, May 21, 2013 at 09:17:35AM +0100, Ian Campbell wrote:
[...]
>
> How about "xen-netback: Split event channel support for Xen Backend
> driver" and the equivalent for frontend?
>
Sure, this can avoid future confusion.
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 8:00 ` Wei Liu
` (2 preceding siblings ...)
2013-05-21 8:17 ` Ian Campbell
@ 2013-05-21 8:17 ` Ian Campbell
3 siblings, 0 replies; 12+ messages in thread
From: Ian Campbell @ 2013-05-21 8:17 UTC (permalink / raw)
To: Wei Liu; +Cc: netdev, konrad.wilk, David Miller, xen-devel
On Tue, 2013-05-21 at 09:00 +0100, Wei Liu wrote:
> On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote:
> >
> > If you use the same exact subject line in all of your patches in the
> > series, nobody reading the shortlog can tell what's different about
> > them.
> >
> > You absolutely must resubmit this with more descriptive subject lines
> > which more accurately describe what each patch uniquely does.
>
> I'm not sure I get what you mean. Their subject lines look alike, but
> not exactly the same.
>
> So this patch set adds a new feature to Xen network device, which is
> called split event channels. The subject lines of two patches, one for
> frontend and one for backend, speak for themselves.
This is true, but I wonder if peoples eyes tend to skip over the initial
prefix.
> No matter how I change the subject lines, they will probably still look
> alike except for the leading "xen-netfront / xen-netback". I can squash
> them into one changeset if that better suits your workflow, but it is
> better to leave them separate IMHO so that we can test them separately.
>
> Advice welcomed.
How about "xen-netback: Split event channel support for Xen Backend
driver" and the equivalent for frontend?
I'd prefer to keep it as two changesets if possible.
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net-next 0/2] Xen network: split event channels support
2013-05-21 6:27 ` David Miller
2013-05-21 8:00 ` Wei Liu
@ 2013-05-21 8:00 ` Wei Liu
1 sibling, 0 replies; 12+ messages in thread
From: Wei Liu @ 2013-05-21 8:00 UTC (permalink / raw)
To: David Miller; +Cc: netdev, konrad.wilk, wei.liu2, ian.campbell, xen-devel
On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote:
>
> If you use the same exact subject line in all of your patches in the
> series, nobody reading the shortlog can tell what's different about
> them.
>
> You absolutely must resubmit this with more descriptive subject lines
> which more accurately describe what each patch uniquely does.
I'm not sure I get what you mean. Their subject lines look alike, but
not exactly the same.
So this patch set adds a new feature to Xen network device, which is
called split event channels. The subject lines of two patches, one for
frontend and one for backend, speak for themselves.
No matter how I change the subject lines, they will probably still look
alike except for the leading "xen-netfront / xen-netback". I can squash
them into one changeset if that better suits your workflow, but it is
better to leave them separate IMHO so that we can test them separately.
Advice welcomed.
Thanks
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-05-21 8:34 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-20 23:02 [PATCH net-next 0/2] Xen network: split event channels support Wei Liu
2013-05-20 23:02 Wei Liu
2013-05-21 6:27 ` David Miller
2013-05-21 6:27 ` David Miller
2013-05-21 8:00 ` Wei Liu
2013-05-21 8:13 ` David Miller
2013-05-21 8:13 ` David Miller
2013-05-21 8:17 ` Ian Campbell
2013-05-21 8:34 ` Wei Liu
2013-05-21 8:34 ` Wei Liu
2013-05-21 8:17 ` Ian Campbell
2013-05-21 8:00 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.