From: Michal Hocko <mhocko@suse.cz> To: Johannes Weiner <hannes@cmpxchg.org> Cc: Andrew Morton <akpm@linux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Ying Han <yinghan@google.com>, Hugh Dickins <hughd@google.com>, Glauber Costa <glommer@parallels.com>, Michel Lespinasse <walken@google.com>, Greg Thelen <gthelen@google.com>, Tejun Heo <tj@kernel.org>, Balbir Singh <bsingharora@gmail.com>, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/3] memcg, vmscan: Do not attempt soft limit reclaim if it would not scan anything Date: Mon, 27 May 2013 19:13:10 +0200 [thread overview] Message-ID: <1369674791-13861-3-git-send-email-mhocko@suse.cz> (raw) In-Reply-To: <1369674791-13861-1-git-send-email-mhocko@suse.cz> mem_cgroup_should_soft_reclaim controls whether soft reclaim pass is done and it always says yes currently. Memcg iterators are clever to skip nodes that are not soft reclaimable quite efficiently but mem_cgroup_should_soft_reclaim can be more clever and do not start the soft reclaim pass at all if it knows that nothing would be scanned anyway. In order to do that, simply reuse mem_cgroup_soft_reclaim_eligible for the target group of the reclaim and allow the pass only if the whole subtree wouldn't be skipped. TODO - should mem_cgroup_soft_reclaim_eligible check for NULL root/memcg so that we do not export root_mem_cgroup? Signed-off-by: Michal Hocko <mhocko@suse.cz> --- include/linux/memcontrol.h | 2 ++ mm/memcontrol.c | 2 +- mm/vmscan.c | 5 ++++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 811967a..909bb6b 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -51,6 +51,8 @@ typedef enum mem_cgroup_filter_t (*mem_cgroup_iter_filter)(struct mem_cgroup *memcg, struct mem_cgroup *root); #ifdef CONFIG_MEMCG +extern struct mem_cgroup *root_mem_cgroup; + /* * All "charge" functions with gfp_mask should use GFP_KERNEL or * (gfp_mask & GFP_RECLAIM_MASK). In current implementatin, memcg doesn't diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 60b48bc..592df10 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -66,7 +66,7 @@ struct cgroup_subsys mem_cgroup_subsys __read_mostly; EXPORT_SYMBOL(mem_cgroup_subsys); #define MEM_CGROUP_RECLAIM_RETRIES 5 -static struct mem_cgroup *root_mem_cgroup __read_mostly; +struct mem_cgroup *root_mem_cgroup __read_mostly; #ifdef CONFIG_MEMCG_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ diff --git a/mm/vmscan.c b/mm/vmscan.c index 49878dd..22c1278 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -142,7 +142,10 @@ static bool global_reclaim(struct scan_control *sc) static bool mem_cgroup_should_soft_reclaim(struct scan_control *sc) { - return true; + struct mem_cgroup *root = sc->target_mem_cgroup; + if (!root) + root = root_mem_cgroup; + return mem_cgroup_soft_reclaim_eligible(root, root) != SKIP_TREE; } #else static bool global_reclaim(struct scan_control *sc) -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz> To: Johannes Weiner <hannes@cmpxchg.org> Cc: Andrew Morton <akpm@linux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Ying Han <yinghan@google.com>, Hugh Dickins <hughd@google.com>, Glauber Costa <glommer@parallels.com>, Michel Lespinasse <walken@google.com>, Greg Thelen <gthelen@google.com>, Tejun Heo <tj@kernel.org>, Balbir Singh <bsingharora@gmail.com>, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/3] memcg, vmscan: Do not attempt soft limit reclaim if it would not scan anything Date: Mon, 27 May 2013 19:13:10 +0200 [thread overview] Message-ID: <1369674791-13861-3-git-send-email-mhocko@suse.cz> (raw) In-Reply-To: <1369674791-13861-1-git-send-email-mhocko@suse.cz> mem_cgroup_should_soft_reclaim controls whether soft reclaim pass is done and it always says yes currently. Memcg iterators are clever to skip nodes that are not soft reclaimable quite efficiently but mem_cgroup_should_soft_reclaim can be more clever and do not start the soft reclaim pass at all if it knows that nothing would be scanned anyway. In order to do that, simply reuse mem_cgroup_soft_reclaim_eligible for the target group of the reclaim and allow the pass only if the whole subtree wouldn't be skipped. TODO - should mem_cgroup_soft_reclaim_eligible check for NULL root/memcg so that we do not export root_mem_cgroup? Signed-off-by: Michal Hocko <mhocko@suse.cz> --- include/linux/memcontrol.h | 2 ++ mm/memcontrol.c | 2 +- mm/vmscan.c | 5 ++++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 811967a..909bb6b 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -51,6 +51,8 @@ typedef enum mem_cgroup_filter_t (*mem_cgroup_iter_filter)(struct mem_cgroup *memcg, struct mem_cgroup *root); #ifdef CONFIG_MEMCG +extern struct mem_cgroup *root_mem_cgroup; + /* * All "charge" functions with gfp_mask should use GFP_KERNEL or * (gfp_mask & GFP_RECLAIM_MASK). In current implementatin, memcg doesn't diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 60b48bc..592df10 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -66,7 +66,7 @@ struct cgroup_subsys mem_cgroup_subsys __read_mostly; EXPORT_SYMBOL(mem_cgroup_subsys); #define MEM_CGROUP_RECLAIM_RETRIES 5 -static struct mem_cgroup *root_mem_cgroup __read_mostly; +struct mem_cgroup *root_mem_cgroup __read_mostly; #ifdef CONFIG_MEMCG_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ diff --git a/mm/vmscan.c b/mm/vmscan.c index 49878dd..22c1278 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -142,7 +142,10 @@ static bool global_reclaim(struct scan_control *sc) static bool mem_cgroup_should_soft_reclaim(struct scan_control *sc) { - return true; + struct mem_cgroup *root = sc->target_mem_cgroup; + if (!root) + root = root_mem_cgroup; + return mem_cgroup_soft_reclaim_eligible(root, root) != SKIP_TREE; } #else static bool global_reclaim(struct scan_control *sc) -- 1.7.10.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-27 17:14 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-13 7:46 [patch v3 0/3 -mm] Soft limit rework Michal Hocko 2013-05-13 7:46 ` Michal Hocko 2013-05-13 7:46 ` Michal Hocko 2013-05-13 7:46 ` [patch v3 -mm 1/3] memcg: integrate soft reclaim tighter with zone shrinking code Michal Hocko 2013-05-13 7:46 ` Michal Hocko 2013-05-15 8:34 ` Glauber Costa 2013-05-15 8:34 ` Glauber Costa 2013-05-16 22:12 ` Tejun Heo 2013-05-16 22:12 ` Tejun Heo 2013-05-16 22:12 ` Tejun Heo 2013-05-16 22:15 ` Tejun Heo 2013-05-16 22:15 ` Tejun Heo 2013-05-17 7:16 ` Michal Hocko 2013-05-17 7:16 ` Michal Hocko 2013-05-17 7:16 ` Michal Hocko 2013-05-17 7:12 ` Michal Hocko 2013-05-17 7:12 ` Michal Hocko 2013-05-17 16:02 ` Johannes Weiner 2013-05-17 16:02 ` Johannes Weiner 2013-05-17 16:57 ` Tejun Heo 2013-05-17 16:57 ` Tejun Heo 2013-05-17 17:27 ` Johannes Weiner 2013-05-17 17:27 ` Johannes Weiner 2013-05-17 17:45 ` Tejun Heo 2013-05-17 17:45 ` Tejun Heo 2013-05-17 17:45 ` Tejun Heo 2013-05-20 14:44 ` Michal Hocko 2013-05-20 14:44 ` Michal Hocko 2013-05-20 14:44 ` Michal Hocko 2013-05-21 6:53 ` Michal Hocko 2013-05-21 6:53 ` Michal Hocko 2013-05-27 17:13 ` Michal Hocko 2013-05-27 17:13 ` Michal Hocko 2013-05-27 17:13 ` Michal Hocko 2013-05-27 17:13 ` [PATCH 1/3] memcg: track children in soft limit excess to improve soft limit Michal Hocko 2013-05-27 17:13 ` Michal Hocko 2013-05-27 17:13 ` Michal Hocko [this message] 2013-05-27 17:13 ` [PATCH 2/3] memcg, vmscan: Do not attempt soft limit reclaim if it would not scan anything Michal Hocko 2013-05-27 17:13 ` [PATCH 3/3] memcg: Track all children over limit in the root Michal Hocko 2013-05-27 17:13 ` Michal Hocko 2013-05-27 17:20 ` [PATCH] memcg: enhance memcg iterator to support predicates Michal Hocko 2013-05-27 17:20 ` Michal Hocko 2013-05-27 17:20 ` Michal Hocko 2013-05-29 13:05 ` [patch v3 -mm 1/3] memcg: integrate soft reclaim tighter with zone shrinking code Michal Hocko 2013-05-29 13:05 ` Michal Hocko 2013-05-29 13:05 ` Michal Hocko 2013-05-29 15:57 ` Michal Hocko 2013-05-29 15:57 ` Michal Hocko 2013-05-29 20:01 ` Johannes Weiner 2013-05-29 20:01 ` Johannes Weiner 2013-05-30 8:45 ` Michal Hocko 2013-05-30 8:45 ` Michal Hocko 2013-05-29 14:54 ` Michal Hocko 2013-05-29 14:54 ` Michal Hocko 2013-05-30 8:36 ` Michal Hocko 2013-05-30 8:36 ` Michal Hocko 2013-05-13 7:46 ` [patch v3 -mm 2/3] memcg: Get rid of soft-limit tree infrastructure Michal Hocko 2013-05-13 7:46 ` Michal Hocko 2013-05-15 8:38 ` Glauber Costa 2013-05-15 8:38 ` Glauber Costa 2013-05-16 22:16 ` Tejun Heo 2013-05-16 22:16 ` Tejun Heo 2013-05-13 7:46 ` [patch v3 -mm 3/3] vmscan, memcg: Do softlimit reclaim also for targeted reclaim Michal Hocko 2013-05-13 7:46 ` Michal Hocko 2013-05-13 7:46 ` Michal Hocko 2013-05-15 8:42 ` Glauber Costa 2013-05-15 8:42 ` Glauber Costa 2013-05-17 7:50 ` Michal Hocko 2013-05-17 7:50 ` Michal Hocko 2013-05-17 7:50 ` Michal Hocko 2013-05-16 23:12 ` Tejun Heo 2013-05-16 23:12 ` Tejun Heo 2013-05-17 7:34 ` Michal Hocko 2013-05-17 7:34 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1369674791-13861-3-git-send-email-mhocko@suse.cz \ --to=mhocko@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=bsingharora@gmail.com \ --cc=cgroups@vger.kernel.org \ --cc=glommer@parallels.com \ --cc=gthelen@google.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=tj@kernel.org \ --cc=walken@google.com \ --cc=yinghan@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.