From: Rob Landley <rob@landley.net>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Simon Horman <horms@verge.net.au>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>,
Zhang Yanfei <zhangyanfei.yes@gmail.com>
Subject: Re: [PATCH v2 2/7] Documentation/devices.txt: Mark /dev/oldmem obsolete
Date: Tue, 28 May 2013 12:26:06 -0500 [thread overview]
Message-ID: <1369761966.2776.39@driftwood> (raw)
In-Reply-To: <51A44DD5.5050301@cn.fujitsu.com> (from zhangyanfei@cn.fujitsu.com on Tue May 28 01:25:25 2013)
On 05/28/2013 01:25:25 AM, Zhang Yanfei wrote:
> On 05/28/2013 02:17 PM, Rob Landley wrote:
> > On 05/26/2013 08:54:19 PM, Zhang Yanfei wrote:
> >> 于 2013年05月27日 09:46, HATAYAMA Daisuke 写道:
> >> > (2013/05/26 15:36), Zhang Yanfei wrote:
> >> >> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> >> >>
> >> >> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> >> >> Cc: Dave Jones <davej@redhat.com>
> >> >> ---
> >> >> Documentation/devices.txt | 3 +--
> >> >> 1 files changed, 1 insertions(+), 2 deletions(-)
> >> >>
> >> >> diff --git a/Documentation/devices.txt
> b/Documentation/devices.txt
> >> >> index 08f01e7..c8e4002 100644
> >> >> --- a/Documentation/devices.txt
> >> >> +++ b/Documentation/devices.txt
> >> >> @@ -100,8 +100,7 @@ Your cooperation is appreciated.
> >> >> 10 = /dev/aio Asynchronous I/O notification
> interface
> >> >> 11 = /dev/kmsg Writes to this come out as
> printk's, reads
> >> >> export the buffered printk records.
> >> >> - 12 = /dev/oldmem Used by crashdump kernels to
> access
> >> >> - the memory of the kernel that crashed.
> >> >> + 12 = /dev/oldmem OBSOLETE
> >> >>
> >> >> 1 block RAM disk
> >> >> 0 = /dev/ram0 First RAM disk
> >> >>
> >> >
> >> > This is the new patch. Looking at other parts of devices.txt,
> obsolete is
> >> > sometimes used together with unused. I guess obsolete means this
> is old interface so
> >> > don't use it as much as possible and unused means this is not
> used at all now.
> >> > You remove old memory interface completely in this patch set, so
> is it better to add
> >> > unused, too?
> >> >
> >>
> >> Does obsolete also mean "not used anymore"? I don't know. I think
> we can wait for some native
> >> English speakers to comment on this.
> >
> > Obsolete implies that it shouldn't be used anymore. There are
> exceptions to everything, of course...
> >
> > (Unused means nothing is using it. If there's still code using it,
> it's not unused. So yeah unused would imply removed.)
> >
>
> So, could I just use UNSED to replace OBSOLETE here? Or use
> "OBSOLETE/UNUSED"?
Obsolete is fine.
Obsolete means it was used at some point, and thus reusing it might
confuse or conflcit with legacy software. Unused could just mean that
we left a gap for some reason, it doesn't imply it ever was used.
Explicitly documenting "unused" is kind of silly: all the ones we
_don't_ document are presumably unused. Obsolete carries with it a very
mild warning about legacy software, which is presumably why we still
bother to mention it at all instead of just removing the entry.
(Then again the point was that nothing ever used this interface in the
first place. Personally I'd just have removed the entry...)
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Landley <rob@landley.net>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Simon Horman <horms@verge.net.au>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>,
Zhang Yanfei <zhangyanfei.yes@gmail.com>
Subject: Re: [PATCH v2 2/7] Documentation/devices.txt: Mark /dev/oldmem obsolete
Date: Tue, 28 May 2013 12:26:06 -0500 [thread overview]
Message-ID: <1369761966.2776.39@driftwood> (raw)
In-Reply-To: <51A44DD5.5050301@cn.fujitsu.com> (from zhangyanfei@cn.fujitsu.com on Tue May 28 01:25:25 2013)
On 05/28/2013 01:25:25 AM, Zhang Yanfei wrote:
> On 05/28/2013 02:17 PM, Rob Landley wrote:
> > On 05/26/2013 08:54:19 PM, Zhang Yanfei wrote:
> >> 于 2013年05月27日 09:46, HATAYAMA Daisuke 写道:
> >> > (2013/05/26 15:36), Zhang Yanfei wrote:
> >> >> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> >> >>
> >> >> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> >> >> Cc: Dave Jones <davej@redhat.com>
> >> >> ---
> >> >> Documentation/devices.txt | 3 +--
> >> >> 1 files changed, 1 insertions(+), 2 deletions(-)
> >> >>
> >> >> diff --git a/Documentation/devices.txt
> b/Documentation/devices.txt
> >> >> index 08f01e7..c8e4002 100644
> >> >> --- a/Documentation/devices.txt
> >> >> +++ b/Documentation/devices.txt
> >> >> @@ -100,8 +100,7 @@ Your cooperation is appreciated.
> >> >> 10 = /dev/aio Asynchronous I/O notification
> interface
> >> >> 11 = /dev/kmsg Writes to this come out as
> printk's, reads
> >> >> export the buffered printk records.
> >> >> - 12 = /dev/oldmem Used by crashdump kernels to
> access
> >> >> - the memory of the kernel that crashed.
> >> >> + 12 = /dev/oldmem OBSOLETE
> >> >>
> >> >> 1 block RAM disk
> >> >> 0 = /dev/ram0 First RAM disk
> >> >>
> >> >
> >> > This is the new patch. Looking at other parts of devices.txt,
> obsolete is
> >> > sometimes used together with unused. I guess obsolete means this
> is old interface so
> >> > don't use it as much as possible and unused means this is not
> used at all now.
> >> > You remove old memory interface completely in this patch set, so
> is it better to add
> >> > unused, too?
> >> >
> >>
> >> Does obsolete also mean "not used anymore"? I don't know. I think
> we can wait for some native
> >> English speakers to comment on this.
> >
> > Obsolete implies that it shouldn't be used anymore. There are
> exceptions to everything, of course...
> >
> > (Unused means nothing is using it. If there's still code using it,
> it's not unused. So yeah unused would imply removed.)
> >
>
> So, could I just use UNSED to replace OBSOLETE here? Or use
> "OBSOLETE/UNUSED"?
Obsolete is fine.
Obsolete means it was used at some point, and thus reusing it might
confuse or conflcit with legacy software. Unused could just mean that
we left a gap for some reason, it doesn't imply it ever was used.
Explicitly documenting "unused" is kind of silly: all the ones we
_don't_ document are presumably unused. Obsolete carries with it a very
mild warning about legacy software, which is presumably why we still
bother to mention it at all instead of just removing the entry.
(Then again the point was that nothing ever used this interface in the
first place. Personally I'd just have removed the entry...)
Rob
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-05-28 17:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 6:31 [PATCH v2 0/7] Remove unused /dev/oldmem interface Zhang Yanfei
2013-05-26 6:31 ` Zhang Yanfei
2013-05-26 6:34 ` [PATCH v2 1/7] /dev/oldmem: Remove the interface Zhang Yanfei
2013-05-26 6:34 ` Zhang Yanfei
2013-05-26 6:36 ` [PATCH v2 2/7] Documentation/devices.txt: Mark /dev/oldmem obsolete Zhang Yanfei
2013-05-26 6:36 ` Zhang Yanfei
2013-05-27 1:46 ` HATAYAMA Daisuke
2013-05-27 1:46 ` HATAYAMA Daisuke
2013-05-27 1:54 ` Zhang Yanfei
2013-05-27 1:54 ` Zhang Yanfei
2013-05-27 2:16 ` HATAYAMA Daisuke
2013-05-27 2:16 ` HATAYAMA Daisuke
2013-05-28 6:17 ` Rob Landley
2013-05-28 6:17 ` Rob Landley
2013-05-28 6:25 ` Zhang Yanfei
2013-05-28 6:25 ` Zhang Yanfei
2013-05-28 17:26 ` Rob Landley [this message]
2013-05-28 17:26 ` Rob Landley
2013-05-28 17:35 ` H. Peter Anvin
2013-05-28 17:35 ` H. Peter Anvin
2013-05-28 22:29 ` Eric W. Biederman
2013-05-28 22:29 ` Eric W. Biederman
2013-05-29 7:45 ` Zhang Yanfei
2013-05-29 7:45 ` Zhang Yanfei
2013-05-26 6:38 ` [PATCH v2 3/7] Documentation/kdump/kdump.txt: Remove /dev/oldmem description Zhang Yanfei
2013-05-26 6:38 ` Zhang Yanfei
2013-05-26 6:40 ` [PATCH v2 4/7] mips: Remove savemaxmem parameter setup Zhang Yanfei
2013-05-26 6:40 ` Zhang Yanfei
2013-05-26 6:42 ` [PATCH v2 5/7] powerpc: " Zhang Yanfei
2013-05-26 6:42 ` Zhang Yanfei
2013-05-26 6:44 ` [PATCH v2 6/7] ia64: Remove setting for saved_max_pfn Zhang Yanfei
2013-05-26 6:44 ` Zhang Yanfei
2013-05-26 6:45 ` [PATCH v2 7/7] s390: " Zhang Yanfei
2013-05-26 6:45 ` Zhang Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369761966.2776.39@driftwood \
--to=rob@landley.net \
--cc=akpm@linux-foundation.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=zhangyanfei.yes@gmail.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.