All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Myklebust, Trond" <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
To: Steve Dickson <SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Schumaker,
	Bryan" <Bryan.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Cc: "David P. Quigley"
	<dpquigl-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>,
	Linux NFS list
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux FS devel list
	<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Security List
	<linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	SELinux List <selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
Subject: Re: [PATCH 00/13] lnfs: 3.10-rc2 release
Date: Thu, 30 May 2013 19:53:30 +0000	[thread overview]
Message-ID: <1369943609.3111.4.camel@leira.trondhjem.org> (raw)
In-Reply-To: <1369241446-7680-1-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Wed, 2013-05-22 at 12:50 -0400, Steve Dickson wrote:
> From: Steve Dickson <steved-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> 
> Here is the next release the label NFS patches ported to 
> linux-3-10.rc2 release.
> 
> The changes made in this release:
> 
> * Add new Ack-by's 
> 
> * Fixed typo in v4.2 section of Kconfig
> 
> * Removed all the label points that are no longer needed in linux/nfs_xdr.h
> 
> * Move NFS4_MAXLABELLEN to linux/nfs4.h
> 
> * Move the label processing out of nfs_post_op_update_inode() and
>   nfs_refresh_inode(), putting it around them. 
> 
> * Removed the state processing from set security label code.
> 
> * Added a new decode_getfattr_label() routine which is by 
>   ops that process labels. 
> 
> * Removed the select from the Kconfig file
> 
> 
> David Quigley (9):
>   Security: Add Hook to test if the particular xattr is part of a MAC
>     model.
>   LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount
>     data.
>   SELinux: Add new labeling type native labels
>   NFSv4: Add label recommended attribute and NFSv4 flags
>   NFSv4: Extend fattr bitmaps to support all 3 words
>   NFS:Add labels to client function prototypes
>   NFS: Add label lifecycle management
>   NFS: Client implementation of Labeled-NFS
>   NFS: Extend NFS xattr handlers to accept the security namespace
> 
> Steve Dickson (4):
>   Security: Add hook to calculate context based on a negative dentry.
>   NFSv4.2: Added NFS v4.2 support to the NFS client
>   NFSv4: Introduce new label structure
>   Kconfig: Add Kconfig entry for Labeled NFS V4 client
> 
>  fs/nfs/Kconfig                      |  28 ++
>  fs/nfs/callback.c                   |   1 +
>  fs/nfs/callback_xdr.c               |   6 +-
>  fs/nfs/client.c                     |   2 +-
>  fs/nfs/dir.c                        |  49 +++-
>  fs/nfs/getroot.c                    |   2 +-
>  fs/nfs/inode.c                      | 109 +++++++-
>  fs/nfs/namespace.c                  |   2 +-
>  fs/nfs/nfs3proc.c                   |   7 +-
>  fs/nfs/nfs4_fs.h                    |   6 +-
>  fs/nfs/nfs4client.c                 |   5 +
>  fs/nfs/nfs4proc.c                   | 518 ++++++++++++++++++++++++++++++++----
>  fs/nfs/nfs4xdr.c                    | 174 +++++++++---
>  fs/nfs/proc.c                       |  13 +-
>  fs/nfs/super.c                      |  24 +-
>  include/linux/nfs4.h                |  13 +
>  include/linux/nfs_fs.h              |  26 +-
>  include/linux/nfs_fs_sb.h           |   8 +-
>  include/linux/nfs_xdr.h             |  20 +-
>  include/linux/security.h            |  57 +++-
>  security/capability.c               |  19 +-
>  security/security.c                 |  24 +-
>  security/selinux/hooks.c            |  92 ++++++-
>  security/selinux/include/security.h |   2 +
>  security/selinux/ss/policydb.c      |   5 +-
>  security/smack/smack_lsm.c          |  11 +
>  26 files changed, 1066 insertions(+), 157 deletions(-)
> 
Hi Steve,

Bryan found a problem with the NFSv4.2 enabling patch above: the
callback channel needs to recognise minor version 2 CB_COMPOUND. There
are several places in the current callback code where people have hacked
the hard coded value '1' for the minor version field... :-(

Bryan is working on a fix for us that I will just apply on top of the
existing labeled NFS branch.

Cheers,
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Steve Dickson <SteveD@redhat.com>,
	"Schumaker, Bryan" <Bryan.Schumaker@netapp.com>
Cc: "David P. Quigley" <dpquigl@tycho.nsa.gov>,
	Linux NFS list <linux-nfs@vger.kernel.org>,
	Linux FS devel list <linux-fsdevel@vger.kernel.org>,
	Linux Security List <linux-security-module@vger.kernel.org>,
	SELinux List <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 00/13] lnfs: 3.10-rc2 release
Date: Thu, 30 May 2013 19:53:30 +0000	[thread overview]
Message-ID: <1369943609.3111.4.camel@leira.trondhjem.org> (raw)
In-Reply-To: <1369241446-7680-1-git-send-email-SteveD@redhat.com>

On Wed, 2013-05-22 at 12:50 -0400, Steve Dickson wrote:
> From: Steve Dickson <steved@redhat.com>
> 
> Here is the next release the label NFS patches ported to 
> linux-3-10.rc2 release.
> 
> The changes made in this release:
> 
> * Add new Ack-by's 
> 
> * Fixed typo in v4.2 section of Kconfig
> 
> * Removed all the label points that are no longer needed in linux/nfs_xdr.h
> 
> * Move NFS4_MAXLABELLEN to linux/nfs4.h
> 
> * Move the label processing out of nfs_post_op_update_inode() and
>   nfs_refresh_inode(), putting it around them. 
> 
> * Removed the state processing from set security label code.
> 
> * Added a new decode_getfattr_label() routine which is by 
>   ops that process labels. 
> 
> * Removed the select from the Kconfig file
> 
> 
> David Quigley (9):
>   Security: Add Hook to test if the particular xattr is part of a MAC
>     model.
>   LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount
>     data.
>   SELinux: Add new labeling type native labels
>   NFSv4: Add label recommended attribute and NFSv4 flags
>   NFSv4: Extend fattr bitmaps to support all 3 words
>   NFS:Add labels to client function prototypes
>   NFS: Add label lifecycle management
>   NFS: Client implementation of Labeled-NFS
>   NFS: Extend NFS xattr handlers to accept the security namespace
> 
> Steve Dickson (4):
>   Security: Add hook to calculate context based on a negative dentry.
>   NFSv4.2: Added NFS v4.2 support to the NFS client
>   NFSv4: Introduce new label structure
>   Kconfig: Add Kconfig entry for Labeled NFS V4 client
> 
>  fs/nfs/Kconfig                      |  28 ++
>  fs/nfs/callback.c                   |   1 +
>  fs/nfs/callback_xdr.c               |   6 +-
>  fs/nfs/client.c                     |   2 +-
>  fs/nfs/dir.c                        |  49 +++-
>  fs/nfs/getroot.c                    |   2 +-
>  fs/nfs/inode.c                      | 109 +++++++-
>  fs/nfs/namespace.c                  |   2 +-
>  fs/nfs/nfs3proc.c                   |   7 +-
>  fs/nfs/nfs4_fs.h                    |   6 +-
>  fs/nfs/nfs4client.c                 |   5 +
>  fs/nfs/nfs4proc.c                   | 518 ++++++++++++++++++++++++++++++++----
>  fs/nfs/nfs4xdr.c                    | 174 +++++++++---
>  fs/nfs/proc.c                       |  13 +-
>  fs/nfs/super.c                      |  24 +-
>  include/linux/nfs4.h                |  13 +
>  include/linux/nfs_fs.h              |  26 +-
>  include/linux/nfs_fs_sb.h           |   8 +-
>  include/linux/nfs_xdr.h             |  20 +-
>  include/linux/security.h            |  57 +++-
>  security/capability.c               |  19 +-
>  security/security.c                 |  24 +-
>  security/selinux/hooks.c            |  92 ++++++-
>  security/selinux/include/security.h |   2 +
>  security/selinux/ss/policydb.c      |   5 +-
>  security/smack/smack_lsm.c          |  11 +
>  26 files changed, 1066 insertions(+), 157 deletions(-)
> 
Hi Steve,

Bryan found a problem with the NFSv4.2 enabling patch above: the
callback channel needs to recognise minor version 2 CB_COMPOUND. There
are several places in the current callback code where people have hacked
the hard coded value '1' for the minor version field... :-(

Bryan is working on a fix for us that I will just apply on top of the
existing labeled NFS branch.

Cheers,
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

  parent reply	other threads:[~2013-05-30 19:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 16:50 [PATCH 00/13] lnfs: 3.10-rc2 release Steve Dickson
     [not found] ` <1369241446-7680-1-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-22 16:50   ` [PATCH 01/13] Security: Add hook to calculate context based on a negative dentry Steve Dickson
2013-05-22 16:50     ` Steve Dickson
2013-05-22 16:50   ` [PATCH 04/13] SELinux: Add new labeling type native labels Steve Dickson
2013-05-22 16:50     ` Steve Dickson
2013-05-22 16:50   ` [PATCH 07/13] NFSv4: Introduce new label structure Steve Dickson
2013-05-22 16:50     ` Steve Dickson
2013-05-22 16:50   ` [PATCH 08/13] NFSv4: Extend fattr bitmaps to support all 3 words Steve Dickson
2013-05-22 16:50     ` Steve Dickson
2013-05-22 16:50   ` [PATCH 12/13] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson
2013-05-22 16:50     ` Steve Dickson
2013-05-30 19:53   ` Myklebust, Trond [this message]
2013-05-30 19:53     ` [PATCH 00/13] lnfs: 3.10-rc2 release Myklebust, Trond
     [not found]     ` <1369943609.3111.4.camel-5lNtUQgoD8Pfa3cDbr2K10B+6BGkLq7r@public.gmane.org>
2013-05-31 21:11       ` Steve Dickson
2013-05-31 21:11         ` Steve Dickson
2013-05-22 16:50 ` [PATCH 02/13] Security: Add Hook to test if the particular xattr is part of a MAC model Steve Dickson
2013-05-22 16:50 ` [PATCH 03/13] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-05-22 16:50 ` [PATCH 05/13] NFSv4.2: Added NFS v4.2 support to the NFS client Steve Dickson
2013-05-22 16:50 ` [PATCH 06/13] NFSv4: Add label recommended attribute and NFSv4 flags Steve Dickson
2013-05-22 16:50 ` [PATCH 09/13] NFS:Add labels to client function prototypes Steve Dickson
2013-05-22 16:50 ` [PATCH 10/13] NFS: Add label lifecycle management Steve Dickson
2013-05-22 16:50 ` [PATCH 11/13] NFS: Client implementation of Labeled-NFS Steve Dickson
2013-05-22 16:50 ` [PATCH 13/13] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369943609.3111.4.camel@leira.trondhjem.org \
    --to=trond.myklebust-hgovqubeegtqt0dzr+alfa@public.gmane.org \
    --cc=Bryan.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
    --cc=SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dpquigl-+05T5uksL2qpZYMLLGbcSA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.