From: Matthew Garrett <matthew.garrett@nebula.com> To: Matt Fleming <matt.fleming@intel.com> Cc: "rja@sgi.com" <rja@sgi.com>, "mingo@kernel.org" <mingo@kernel.org>, "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>, "bp@alien8.de" <bp@alien8.de>, "jkosina@suse.cz" <jkosina@suse.cz>, "jlee@suse.com" <jlee@suse.com>, "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "hpa@linux.intel.com" <hpa@linux.intel.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org> Subject: Re: [PATCH] Modify UEFI anti-bricking code Date: Mon, 3 Jun 2013 14:58:50 +0000 [thread overview] Message-ID: <1370271528.6315.5.camel@x230.lan> (raw) In-Reply-To: <51AC8974.4010102@intel.com> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1156 bytes --] On Mon, 2013-06-03 at 13:17 +0100, Matt Fleming wrote: > Do we really want to drop this hunk? The point of this code was to > inform firmware vendors that their implementation is returning funky > results, and that they should look into why it's doing that. We're not doing anything with that information now, and I don't think we can do anything meaningful with it - some implementations report the maximum size as the maximum supported by the implementation, and some report it as the maximum that can be written given the amount of space currently available. So yeah, it's against the spec to report 0 here, but any other value is equally useless to us, so it seems like something we'd be complaining about for no reason. > What's the origin of this guid? And should we be adding it to > include/linux/efi.h? It's a scratch guid that's randomly generated to avoid colliding with any other guid - we want to avoid this ever being a real variable. -- Matthew Garrett | mjg59@srcf.ucam.org ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com> To: Matt Fleming <matt.fleming@intel.com> Cc: "rja@sgi.com" <rja@sgi.com>, "mingo@kernel.org" <mingo@kernel.org>, "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>, "bp@alien8.de" <bp@alien8.de>, "jkosina@suse.cz" <jkosina@suse.cz>, "jlee@suse.com" <jlee@suse.com>, "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "hpa@linux.intel.com" <hpa@linux.intel.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org> Subject: Re: [PATCH] Modify UEFI anti-bricking code Date: Mon, 3 Jun 2013 14:58:50 +0000 [thread overview] Message-ID: <1370271528.6315.5.camel@x230.lan> (raw) In-Reply-To: <51AC8974.4010102@intel.com> On Mon, 2013-06-03 at 13:17 +0100, Matt Fleming wrote: > Do we really want to drop this hunk? The point of this code was to > inform firmware vendors that their implementation is returning funky > results, and that they should look into why it's doing that. We're not doing anything with that information now, and I don't think we can do anything meaningful with it - some implementations report the maximum size as the maximum supported by the implementation, and some report it as the maximum that can be written given the amount of space currently available. So yeah, it's against the spec to report 0 here, but any other value is equally useless to us, so it seems like something we'd be complaining about for no reason. > What's the origin of this guid? And should we be adding it to > include/linux/efi.h? It's a scratch guid that's randomly generated to avoid colliding with any other guid - we want to avoid this ever being a real variable. -- Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-06-03 14:59 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-01 20:06 [PATCH] Modify UEFI anti-bricking code Matthew Garrett 2013-06-01 20:06 ` Matthew Garrett 2013-06-02 15:48 ` Russ Anderson 2013-06-02 15:48 ` Russ Anderson 2013-06-03 12:17 ` Matt Fleming 2013-06-03 14:58 ` Matthew Garrett [this message] 2013-06-03 14:58 ` Matthew Garrett 2013-06-03 16:13 ` joeyli 2013-06-03 16:31 ` Matthew Garrett 2013-06-03 16:31 ` Matthew Garrett 2013-06-04 3:35 ` joeyli 2013-06-04 3:35 ` joeyli 2013-06-05 14:49 ` Fleming, Matt 2013-06-05 14:53 ` Matthew Garrett 2013-06-05 14:53 ` Matthew Garrett 2013-06-05 15:59 ` Matt Fleming 2013-06-05 15:59 ` Matt Fleming 2013-06-05 16:08 ` Matthew Garrett 2013-06-05 16:08 ` Matthew Garrett 2013-06-05 19:59 ` Matt Fleming 2013-06-05 19:59 ` Matt Fleming 2013-06-06 2:24 ` joeyli 2013-06-05 20:19 ` H. Peter Anvin 2013-06-05 20:19 ` H. Peter Anvin 2013-06-06 5:05 ` joeyli 2013-06-06 5:05 ` joeyli 2013-06-06 5:41 ` joeyli 2013-06-06 5:42 ` Matthew Garrett 2013-06-06 5:42 ` Matthew Garrett 2013-06-06 7:40 ` joeyli 2013-06-06 7:40 ` joeyli 2013-06-06 9:25 ` Matt Fleming 2013-06-06 9:25 ` Matt Fleming 2013-06-06 14:48 ` Russ Anderson 2013-06-06 14:48 ` Russ Anderson 2013-06-06 15:00 ` Matt Fleming 2013-06-06 15:00 ` Matt Fleming 2013-06-06 15:28 ` Russ Anderson 2013-06-06 15:28 ` Russ Anderson 2013-06-10 18:54 ` Russ Anderson 2013-06-10 18:54 ` Russ Anderson 2013-06-04 5:29 ` Lingzhu Xiang 2013-06-04 5:29 ` Lingzhu Xiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1370271528.6315.5.camel@x230.lan \ --to=matthew.garrett@nebula.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=hpa@linux.intel.com \ --cc=jkosina@suse.cz \ --cc=jlee@suse.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=matt.fleming@intel.com \ --cc=mingo@kernel.org \ --cc=rja@sgi.com \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.