All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <matthew.garrett@nebula.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: "Fleming, Matt" <matt.fleming@intel.com>, joeyli <jlee@suse.com>,
	"rja@sgi.com" <rja@sgi.com>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"bp@alien8.de" <bp@alien8.de>,
	"jkosina@suse.cz" <jkosina@suse.cz>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"hpa@linux.intel.com" <hpa@linux.intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"oneukum@suse.de" <oneukum@suse.de>
Subject: Re: [PATCH] Modify UEFI anti-bricking code
Date: Wed, 5 Jun 2013 16:08:39 +0000	[thread overview]
Message-ID: <1370448519.6315.36.camel@x230.lan> (raw)
In-Reply-To: <20130605155904.GC30420@console-pimps.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 769 bytes --]

On Wed, 2013-06-05 at 16:59 +0100, Matt Fleming wrote:

> +	/* clean DUMMY object */
> +	efi.set_variable(efi_dummy_name, &EFI_DUMMY_GUID, 0, 0, NULL);

Hm. Actually, is that going to work? From the spec:

If a preexisting variable is rewritten with different attributes,
SetVariable()shall not modify the variable and shall return
EFI_INVALID_PARAMETER. 

So I think we probably need to fix the attributes to NV|RT|BS for both
this call and the one in query_variable_store. We should probably also
only do the workaround if the NV bit is set in the original query.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: "Fleming,
	Matt" <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	joeyli <jlee-IBi9RG/b67k@public.gmane.org>,
	"rja-sJ/iWh9BUns@public.gmane.org"
	<rja-sJ/iWh9BUns@public.gmane.org>,
	"mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org"
	<bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
	"jkosina-AlSwsSmVLrQ@public.gmane.org"
	<jkosina-AlSwsSmVLrQ@public.gmane.org>,
	"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org"
	<tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	"hpa-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<hpa-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"oneukum-l3A5Bk7waGM@public.gmane.org"
	<oneukum-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH] Modify UEFI anti-bricking code
Date: Wed, 5 Jun 2013 16:08:39 +0000	[thread overview]
Message-ID: <1370448519.6315.36.camel@x230.lan> (raw)
In-Reply-To: <20130605155904.GC30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>

On Wed, 2013-06-05 at 16:59 +0100, Matt Fleming wrote:

> +	/* clean DUMMY object */
> +	efi.set_variable(efi_dummy_name, &EFI_DUMMY_GUID, 0, 0, NULL);

Hm. Actually, is that going to work? From the spec:

If a preexisting variable is rewritten with different attributes,
SetVariable()shall not modify the variable and shall return
EFI_INVALID_PARAMETER. 

So I think we probably need to fix the attributes to NV|RT|BS for both
this call and the one in query_variable_store. We should probably also
only do the workaround if the NV bit is set in the original query.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2013-06-05 16:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01 20:06 [PATCH] Modify UEFI anti-bricking code Matthew Garrett
2013-06-01 20:06 ` Matthew Garrett
2013-06-02 15:48 ` Russ Anderson
2013-06-02 15:48   ` Russ Anderson
2013-06-03 12:17 ` Matt Fleming
2013-06-03 14:58   ` Matthew Garrett
2013-06-03 14:58     ` Matthew Garrett
2013-06-03 16:13 ` joeyli
2013-06-03 16:31   ` Matthew Garrett
2013-06-03 16:31     ` Matthew Garrett
2013-06-04  3:35     ` joeyli
2013-06-04  3:35       ` joeyli
2013-06-05 14:49       ` Fleming, Matt
2013-06-05 14:53         ` Matthew Garrett
2013-06-05 14:53           ` Matthew Garrett
2013-06-05 15:59           ` Matt Fleming
2013-06-05 15:59             ` Matt Fleming
2013-06-05 16:08             ` Matthew Garrett [this message]
2013-06-05 16:08               ` Matthew Garrett
2013-06-05 19:59               ` Matt Fleming
2013-06-05 19:59                 ` Matt Fleming
2013-06-06  2:24               ` joeyli
2013-06-05 20:19             ` H. Peter Anvin
2013-06-05 20:19               ` H. Peter Anvin
2013-06-06  5:05             ` joeyli
2013-06-06  5:05               ` joeyli
2013-06-06  5:41               ` joeyli
2013-06-06  5:42               ` Matthew Garrett
2013-06-06  5:42                 ` Matthew Garrett
2013-06-06  7:40                 ` joeyli
2013-06-06  7:40                   ` joeyli
2013-06-06  9:25                   ` Matt Fleming
2013-06-06  9:25                     ` Matt Fleming
2013-06-06 14:48                     ` Russ Anderson
2013-06-06 14:48                       ` Russ Anderson
2013-06-06 15:00                       ` Matt Fleming
2013-06-06 15:00                         ` Matt Fleming
2013-06-06 15:28                         ` Russ Anderson
2013-06-06 15:28                           ` Russ Anderson
2013-06-10 18:54                     ` Russ Anderson
2013-06-10 18:54                       ` Russ Anderson
2013-06-04  5:29 ` Lingzhu Xiang
2013-06-04  5:29   ` Lingzhu Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370448519.6315.36.camel@x230.lan \
    --to=matthew.garrett@nebula.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=hpa@linux.intel.com \
    --cc=jkosina@suse.cz \
    --cc=jlee@suse.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@console-pimps.org \
    --cc=mingo@kernel.org \
    --cc=oneukum@suse.de \
    --cc=rja@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.