From: Ben Hutchings <bhutchings@solarflare.com>
To: <Narendra_K@Dell.com>
Cc: <john.fastabend@gmail.com>, <netdev@vger.kernel.org>,
<john.r.fastabend@intel.com>
Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs
Date: Wed, 19 Jun 2013 16:36:34 +0100 [thread overview]
Message-ID: <1371656194.1956.25.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <E31FB011129F30488D5861F383904915210BB90367@BLRX7MCDC201.AMER.DELL.COM>
On Wed, 2013-06-19 at 07:29 -0700, Narendra_K@Dell.com wrote:
[...]
> 2. show_phys_port function sees a consistent value of
> 'netdev->phys_port.port_id and netdev->phys_port.port_id_len ' if
> another execution path changes the value of 'netdev->phys_port.port_id
> and netdev->phys_port.port_id_len ' with write_lock(&dev_base_lock)
> held (similar to how dev->operstate is being changed).
[...]
If the physical port ID can change dynamically (I hadn't thought of
that, but an embedded switch could support such reconfiguration) then
any such change also needs to be announced through rtnetlink. Actually,
I think the value needs to be included in rtnetlink information anyway.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-06-19 15:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 18:10 [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs Narendra_K
2013-06-17 18:47 ` John Fastabend
2013-06-19 14:29 ` Narendra_K
2013-06-19 15:36 ` Ben Hutchings [this message]
2013-06-19 18:53 ` Narendra_K
2013-06-19 19:34 ` Ben Hutchings
2013-06-19 21:37 ` Praveen_Paladugu
2013-06-21 17:11 ` John Fastabend
2013-06-25 17:33 ` Narendra_K
2013-06-28 16:33 ` John Fastabend
2013-06-28 17:09 ` Ben Hutchings
2013-07-02 14:40 ` Narendra_K
2013-07-11 20:39 ` Jiri Pirko
2013-07-15 15:34 ` Narendra_K
2013-07-21 5:55 ` Or Gerlitz
2013-07-21 7:24 ` Jiri Pirko
2013-07-21 11:14 ` Or Gerlitz
2013-07-21 14:48 ` Ben Hutchings
2013-07-21 20:29 ` Or Gerlitz
2013-07-21 20:50 ` Ben Hutchings
2013-07-22 11:46 ` Narendra_K
2013-07-22 11:49 ` Jiri Pirko
2013-07-22 15:48 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371656194.1956.25.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=Narendra_K@Dell.com \
--cc=john.fastabend@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.