From: Jiri Pirko <jiri@resnulli.us>
To: Narendra_K@Dell.com
Cc: bhutchings@solarflare.com, or.gerlitz@gmail.com,
netdev@vger.kernel.org, john.r.fastabend@intel.com
Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs
Date: Mon, 22 Jul 2013 13:49:44 +0200 [thread overview]
Message-ID: <20130722114944.GA1552@minipsycho.orion> (raw)
In-Reply-To: <20130722114556.GB4511@fedora18-dev.oslab.blr.amer.dell.com>
Mon, Jul 22, 2013 at 01:46:01PM CEST, Narendra_K@Dell.com wrote:
>On Sun, Jul 21, 2013 at 08:18:23PM +0530, Ben Hutchings wrote:
>>
>> On Sun, 2013-07-21 at 14:14 +0300, Or Gerlitz wrote:
>> > On Sun, Jul 21, 2013 at 10:24 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> > [...]
>> >
>> > Sorry, I missed that fact that initially you responded on this thread
>> >
>> > > The value could be anything. But note that you have to have different
>> > > values for card1-port1,2 and card2-port1,2
>> >
>> > why?
>>
>> The intent is to identify physical ports uniquely, so userland can tell
>> whether two devices are backed by the same physical port.
>>
>> But there's no requirement on the format, so you could ensure that one
>> byte of this identifier is the port number on the board.
>
>Would it be useful to embed the port number at a known offset to ensure
>uniformity across all drivers, if a driver choses to embed port number
>as part of phys_port_id ?
I would not do that. Just let it be meaningless number. That is best for
security reasons as well.
>
>--
>With regards,
>Narendra K
>Linux Engineering
>Dell Inc.
next prev parent reply other threads:[~2013-07-22 11:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 18:10 [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs Narendra_K
2013-06-17 18:47 ` John Fastabend
2013-06-19 14:29 ` Narendra_K
2013-06-19 15:36 ` Ben Hutchings
2013-06-19 18:53 ` Narendra_K
2013-06-19 19:34 ` Ben Hutchings
2013-06-19 21:37 ` Praveen_Paladugu
2013-06-21 17:11 ` John Fastabend
2013-06-25 17:33 ` Narendra_K
2013-06-28 16:33 ` John Fastabend
2013-06-28 17:09 ` Ben Hutchings
2013-07-02 14:40 ` Narendra_K
2013-07-11 20:39 ` Jiri Pirko
2013-07-15 15:34 ` Narendra_K
2013-07-21 5:55 ` Or Gerlitz
2013-07-21 7:24 ` Jiri Pirko
2013-07-21 11:14 ` Or Gerlitz
2013-07-21 14:48 ` Ben Hutchings
2013-07-21 20:29 ` Or Gerlitz
2013-07-21 20:50 ` Ben Hutchings
2013-07-22 11:46 ` Narendra_K
2013-07-22 11:49 ` Jiri Pirko [this message]
2013-07-22 15:48 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722114944.GA1552@minipsycho.orion \
--to=jiri@resnulli.us \
--cc=Narendra_K@Dell.com \
--cc=bhutchings@solarflare.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.