All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <or.gerlitz@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
	Narendra_K@dell.com, netdev@vger.kernel.org,
	john.r.fastabend@intel.com
Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs
Date: Sun, 21 Jul 2013 23:29:33 +0300	[thread overview]
Message-ID: <CAJZOPZJdYvSYZ2O+h3nLM2dxjwRx6Ma975T7DZXVXUoZmywVeg@mail.gmail.com> (raw)
In-Reply-To: <1374418103.16533.69.camel@deadeye.wl.decadent.org.uk>

On Sun, Jul 21, 2013 at 5:48 PM, Ben Hutchings
<bhutchings@solarflare.com> wrote:
> On Sun, 2013-07-21 at 14:14 +0300, Or Gerlitz wrote:
>> On Sun, Jul 21, 2013 at 10:24 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> [...]
>>
>> Sorry, I missed that fact that initially you responded on this thread
>>
>> > The value could be anything. But note that you have to have different
>> > values for card1-port1,2 and card2-port1,2
>>
>> why?
>
> The intent is to identify physical ports uniquely, so userland can tell
> whether two devices are backed by the same physical port.

OK this makes sense, and I understand that there are also some SRIOV
aspects / use cases where this field could be usefu, still I don't
understamd the direct relation to virtual functions, as mentioned in
the 1st patch.
>
> But there's no requirement on the format, so you could ensure that one
> byte of this identifier is the port number on the board.
>
> Ben.
>
> --
> Ben Hutchings, Staff Engineer, Solarflare
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.
>

  reply	other threads:[~2013-07-21 20:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 18:10 [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs Narendra_K
2013-06-17 18:47 ` John Fastabend
2013-06-19 14:29   ` Narendra_K
2013-06-19 15:36     ` Ben Hutchings
2013-06-19 18:53       ` Narendra_K
2013-06-19 19:34         ` Ben Hutchings
2013-06-19 21:37           ` Praveen_Paladugu
2013-06-21 17:11           ` John Fastabend
2013-06-25 17:33             ` Narendra_K
2013-06-28 16:33               ` John Fastabend
2013-06-28 17:09                 ` Ben Hutchings
2013-07-02 14:40                   ` Narendra_K
2013-07-11 20:39 ` Jiri Pirko
2013-07-15 15:34   ` Narendra_K
2013-07-21  5:55     ` Or Gerlitz
2013-07-21  7:24       ` Jiri Pirko
2013-07-21 11:14         ` Or Gerlitz
2013-07-21 14:48           ` Ben Hutchings
2013-07-21 20:29             ` Or Gerlitz [this message]
2013-07-21 20:50               ` Ben Hutchings
2013-07-22 11:46             ` Narendra_K
2013-07-22 11:49               ` Jiri Pirko
2013-07-22 15:48                 ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZOPZJdYvSYZ2O+h3nLM2dxjwRx6Ma975T7DZXVXUoZmywVeg@mail.gmail.com \
    --to=or.gerlitz@gmail.com \
    --cc=Narendra_K@dell.com \
    --cc=bhutchings@solarflare.com \
    --cc=jiri@resnulli.us \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.