All of lore.kernel.org
 help / color / mirror / Atom feed
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 12/13] usb: chipidea: udc: .pullup is valid when vbus is on at CI_HDRC_PULLUP_ON_VBUS
Date: Thu, 11 Jul 2013 14:27:20 +0800	[thread overview]
Message-ID: <1373524041-10482-13-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1373524041-10482-1-git-send-email-peter.chen@freescale.com>

When the flag CI_HDRC_PULLUP_ON_VBUS is set, .pullup should only be
called when the vbus is active. When the CI_HDRC_PULLUP_ON_VBUS
is set, the controller only begins to run when the vbus is on,
So, it is only meaningful software set pullup/pulldown after
the controller begins to run.

Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 drivers/usb/chipidea/udc.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 45abf4d..b7ead5f 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1514,6 +1514,10 @@ static int ci_udc_pullup(struct usb_gadget *_gadget, int is_on)
 {
 	struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget);
 
+	if ((ci->platdata->flags & CI_HDRC_PULLUP_ON_VBUS)
+			&& !ci->vbus_active)
+		return -EOPNOTSUPP;
+
 	if (is_on)
 		hw_write(ci, OP_USBCMD, USBCMD_RS, USBCMD_RS);
 	else
-- 
1.7.0.4

  parent reply	other threads:[~2013-07-11  6:27 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11  6:27 [PATCH v12 00/13] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
2013-07-11  6:27 ` [PATCH v12 01/13] usb: chipidea: add vbus regulator control Peter Chen
2013-07-11  6:27 ` [PATCH v12 02/13] usb: chipidea: imx: remove vbus regulator operation Peter Chen
2013-07-11  6:37   ` Sascha Hauer
2013-07-11  6:55     ` Peter Chen
2013-07-11  6:27 ` [PATCH v12 03/13] usb: chipidea: udc: otg_set_peripheral is useless for some chipidea users Peter Chen
2013-07-11  6:27 ` [PATCH v12 04/13] usb: chipidea: otg: Add otg file used to access otgsc Peter Chen
2013-07-11  6:27 ` [PATCH v12 05/13] usb: chipidea: Add role init and destory APIs Peter Chen
2013-07-11  6:27 ` [PATCH v12 06/13] usb: chipidea: add otg_cap attribute for otg capable Peter Chen
2013-07-11 15:36   ` Marek Vasut
2013-07-12  2:58     ` Peter Chen
2013-07-12  3:54       ` Marek Vasut
2013-07-12  8:12   ` Alexander Shishkin
2013-07-12  8:25     ` Peter Chen
2013-07-12  9:42       ` Alexander Shishkin
2013-07-12 10:16         ` Peter Chen
2013-07-16  9:45         ` Peter Chen
2013-07-11  6:27 ` [PATCH v12 07/13] usb: chipidea: disable all interrupts and clear all interrupts status Peter Chen
2013-07-11  6:27 ` [PATCH v12 08/13] usb: chipidea: move otg relate things to otg file Peter Chen
2013-07-11  6:27 ` [PATCH v12 09/13] usb: chipidea: add vbus interrupt handler Peter Chen
2013-07-11  6:27 ` [PATCH v12 10/13] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts Peter Chen
2013-07-11  7:24   ` Marc Kleine-Budde
2013-07-11  9:25     ` Peter Chen
2013-07-11  9:31       ` Marc Kleine-Budde
2013-07-11  6:27 ` [PATCH v12 11/13] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS Peter Chen
2013-07-11  6:27 ` Peter Chen [this message]
2013-07-11  6:27 ` [PATCH v12 13/13] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget Peter Chen
2013-07-11 17:57 ` [PATCH v12 00/13] Add tested id switch and vbus connect detect support for Chipidea Marek Vasut
2013-07-12  3:12   ` Peter Chen
2013-07-12  4:04     ` Marek Vasut
2013-07-12  8:26       ` Peter Chen
2013-07-12 13:18         ` Marek Vasut
2013-07-13  0:36           ` Chen Peter-B29397
2013-07-16  9:43           ` Peter Chen
2013-07-22  1:15             ` Marek Vasut
2013-07-22  1:21               ` Peter Chen
2013-07-22  1:40                 ` Marek Vasut
2013-07-22  1:53                   ` Peter Chen
2013-07-25  5:55                     ` Marek Vasut
2013-07-25  5:58                       ` Peter Chen
2013-07-25 12:36                         ` Marek Vasut
2013-07-19 14:11 ` Fabio Estevam
2013-07-25  6:05 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373524041-10482-13-git-send-email-peter.chen@freescale.com \
    --to=peter.chen@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.