* [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings
@ 2013-07-30 17:35 Emil Goode
2013-07-31 8:16 ` walter harms
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Emil Goode @ 2013-07-30 17:35 UTC (permalink / raw)
To: kernel-janitors
This patch fixes the following sparse warnings.
dma_addr_t can be either u32 or u64 so we should cast to the
largest type and use the format specifier %llx.
drivers/spi/spi-atmel.c: In function ‘atmel_spi_next_xfer_dma_submit’:
drivers/spi/spi-atmel.c:631:2: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 7 has type ‘dma_addr_t’ [-Wformat]
drivers/spi/spi-atmel.c:631:2: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 9 has type ‘dma_addr_t’ [-Wformat]
drivers/spi/spi-atmel.c: In function ‘atmel_spi_pdc_next_xfer’:
drivers/spi/spi-atmel.c:734:3: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 7 has type ‘dma_addr_t’ [-Wformat]
drivers/spi/spi-atmel.c:734:3: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 9 has type ‘dma_addr_t’ [-Wformat]
drivers/spi/spi-atmel.c:773:3: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 7 has type ‘dma_addr_t’ [-Wformat]
drivers/spi/spi-atmel.c:773:3: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 9 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/spi/spi-atmel.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 4e40693..fd7cc56 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -629,9 +629,9 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
goto err_dma;
dev_dbg(master->dev.parent,
- " start dma xfer %p: len %u tx %p/%08x rx %p/%08x\n",
- xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
- xfer->rx_buf, xfer->rx_dma);
+ " start dma xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
+ xfer, xfer->len, xfer->tx_buf, (unsigned long long)xfer->tx_dma,
+ xfer->rx_buf, (unsigned long long)xfer->rx_dma);
/* Enable relevant interrupts */
spi_writel(as, IER, SPI_BIT(OVRES));
@@ -732,9 +732,10 @@ static void atmel_spi_pdc_next_xfer(struct spi_master *master,
spi_writel(as, TCR, len);
dev_dbg(&msg->spi->dev,
- " start xfer %p: len %u tx %p/%08x rx %p/%08x\n",
- xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
- xfer->rx_buf, xfer->rx_dma);
+ " start xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
+ xfer, xfer->len, xfer->tx_buf,
+ (unsigned long long)xfer->tx_dma, xfer->rx_buf,
+ (unsigned long long)xfer->rx_dma);
} else {
xfer = as->next_transfer;
remaining = as->next_remaining_bytes;
@@ -771,9 +772,10 @@ static void atmel_spi_pdc_next_xfer(struct spi_master *master,
spi_writel(as, TNCR, len);
dev_dbg(&msg->spi->dev,
- " next xfer %p: len %u tx %p/%08x rx %p/%08x\n",
- xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
- xfer->rx_buf, xfer->rx_dma);
+ " next xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
+ xfer, xfer->len, xfer->tx_buf,
+ (unsigned long long)xfer->tx_dma, xfer->rx_buf,
+ (unsigned long long)xfer->rx_dma);
ieval = SPI_BIT(ENDRX) | SPI_BIT(OVRES);
} else {
spi_writel(as, RNCR, 0);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings
2013-07-30 17:35 [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings Emil Goode
@ 2013-07-31 8:16 ` walter harms
2013-07-31 8:23 ` Dan Carpenter
2013-07-31 16:55 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: walter harms @ 2013-07-31 8:16 UTC (permalink / raw)
To: kernel-janitors
Am 30.07.2013 19:35, schrieb Emil Goode:
> This patch fixes the following sparse warnings.
> dma_addr_t can be either u32 or u64 so we should cast to the
> largest type and use the format specifier %llx.
>
> drivers/spi/spi-atmel.c: In function ‘atmel_spi_next_xfer_dma_submit’:
> drivers/spi/spi-atmel.c:631:2: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 7 has type ‘dma_addr_t’ [-Wformat]
maybe a %p is better here?
re,
wh
> drivers/spi/spi-atmel.c:631:2: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 9 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c: In function ‘atmel_spi_pdc_next_xfer’:
> drivers/spi/spi-atmel.c:734:3: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 7 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c:734:3: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 9 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c:773:3: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 7 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c:773:3: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 9 has type ‘dma_addr_t’ [-Wformat]
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
> drivers/spi/spi-atmel.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 4e40693..fd7cc56 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -629,9 +629,9 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
> goto err_dma;
>
> dev_dbg(master->dev.parent,
> - " start dma xfer %p: len %u tx %p/%08x rx %p/%08x\n",
> - xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
> - xfer->rx_buf, xfer->rx_dma);
> + " start dma xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
> + xfer, xfer->len, xfer->tx_buf, (unsigned long long)xfer->tx_dma,
> + xfer->rx_buf, (unsigned long long)xfer->rx_dma);
>
> /* Enable relevant interrupts */
> spi_writel(as, IER, SPI_BIT(OVRES));
> @@ -732,9 +732,10 @@ static void atmel_spi_pdc_next_xfer(struct spi_master *master,
> spi_writel(as, TCR, len);
>
> dev_dbg(&msg->spi->dev,
> - " start xfer %p: len %u tx %p/%08x rx %p/%08x\n",
> - xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
> - xfer->rx_buf, xfer->rx_dma);
> + " start xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
> + xfer, xfer->len, xfer->tx_buf,
> + (unsigned long long)xfer->tx_dma, xfer->rx_buf,
> + (unsigned long long)xfer->rx_dma);
> } else {
> xfer = as->next_transfer;
> remaining = as->next_remaining_bytes;
> @@ -771,9 +772,10 @@ static void atmel_spi_pdc_next_xfer(struct spi_master *master,
> spi_writel(as, TNCR, len);
>
> dev_dbg(&msg->spi->dev,
> - " next xfer %p: len %u tx %p/%08x rx %p/%08x\n",
> - xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
> - xfer->rx_buf, xfer->rx_dma);
> + " next xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
> + xfer, xfer->len, xfer->tx_buf,
> + (unsigned long long)xfer->tx_dma, xfer->rx_buf,
> + (unsigned long long)xfer->rx_dma);
> ieval = SPI_BIT(ENDRX) | SPI_BIT(OVRES);
> } else {
> spi_writel(as, RNCR, 0);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings
2013-07-30 17:35 [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings Emil Goode
2013-07-31 8:16 ` walter harms
@ 2013-07-31 8:23 ` Dan Carpenter
2013-07-31 16:55 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-07-31 8:23 UTC (permalink / raw)
To: kernel-janitors
On Wed, Jul 31, 2013 at 10:16:59AM +0200, walter harms wrote:
>
>
> Am 30.07.2013 19:35, schrieb Emil Goode:
> > This patch fixes the following sparse warnings.
> > dma_addr_t can be either u32 or u64 so we should cast to the
> > largest type and use the format specifier %llx.
> >
> > drivers/spi/spi-atmel.c: In function ‘atmel_spi_next_xfer_dma_submit’:
> > drivers/spi/spi-atmel.c:631:2: warning:
> > format ‘%x’ expects argument of type ‘unsigned int’,
> > but argument 7 has type ‘dma_addr_t’ [-Wformat]
>
> maybe a %p is better here?
>
No, that doesn't work for dma_addr_t.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings
2013-07-30 17:35 [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings Emil Goode
2013-07-31 8:16 ` walter harms
2013-07-31 8:23 ` Dan Carpenter
@ 2013-07-31 16:55 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-07-31 16:55 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
On Tue, Jul 30, 2013 at 07:35:35PM +0200, Emil Goode wrote:
> This patch fixes the following sparse warnings.
> dma_addr_t can be either u32 or u64 so we should cast to the
> largest type and use the format specifier %llx.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-31 16:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-30 17:35 [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings Emil Goode
2013-07-31 8:16 ` walter harms
2013-07-31 8:23 ` Dan Carpenter
2013-07-31 16:55 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.