All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	Iwo Mergler <Iwo.Mergler@netcommwireless.com.au>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Akinobu Mita <akinobu.mita@gmail.com>,
	Vikram Narayanan <vikram186@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH -next v2 10/10] mtd: mtd_nandbiterrs: use mtd_test helpers
Date: Sat,  3 Aug 2013 18:52:16 +0900	[thread overview]
Message-ID: <1375523536-32671-11-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1375523536-32671-1-git-send-email-akinobu.mita@gmail.com>

Use mtdtest_write() and mtdtest_erase_eraseblock() in mtd_test helpers.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Iwo Mergler <Iwo.Mergler@netcommwireless.com.au>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Vikram Narayanan <vikram186@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
---
* Newly added patch from v2

 drivers/mtd/tests/nandbiterrs.c | 39 ++++++---------------------------------
 1 file changed, 6 insertions(+), 33 deletions(-)

diff --git a/drivers/mtd/tests/nandbiterrs.c b/drivers/mtd/tests/nandbiterrs.c
index 207bf9a..5a8c858 100644
--- a/drivers/mtd/tests/nandbiterrs.c
+++ b/drivers/mtd/tests/nandbiterrs.c
@@ -49,6 +49,7 @@
 #include <linux/err.h>
 #include <linux/mtd/nand.h>
 #include <linux/slab.h>
+#include "mtd_test.h"
 
 static int dev;
 module_param(dev, int, S_IRUGO);
@@ -98,45 +99,17 @@ static uint8_t hash(unsigned offset)
 	return c;
 }
 
-static int erase_block(void)
-{
-	int err;
-	struct erase_info ei;
-	loff_t addr = eraseblock * mtd->erasesize;
-
-	pr_info("erase_block\n");
-
-	memset(&ei, 0, sizeof(struct erase_info));
-	ei.mtd  = mtd;
-	ei.addr = addr;
-	ei.len  = mtd->erasesize;
-
-	err = mtd_erase(mtd, &ei);
-	if (err || ei.state == MTD_ERASE_FAILED) {
-		pr_err("error %d while erasing\n", err);
-		if (!err)
-			err = -EIO;
-		return err;
-	}
-
-	return 0;
-}
-
 /* Writes wbuffer to page */
 static int write_page(int log)
 {
-	int err = 0;
-	size_t written;
+	int err;
 
 	if (log)
 		pr_info("write_page\n");
 
-	err = mtd_write(mtd, offset, mtd->writesize, &written, wbuffer);
-	if (err || written != mtd->writesize) {
+	err = mtdtest_write(mtd, offset, mtd->writesize, wbuffer);
+	if (err)
 		pr_err("error: write failed at %#llx\n", (long long)offset);
-		if (!err)
-			err = -EIO;
-	}
 
 	return err;
 }
@@ -415,7 +388,7 @@ static int __init mtd_nandbiterrs_init(void)
 		goto exit_rbuffer;
 	}
 
-	err = erase_block();
+	err = mtdtest_erase_eraseblock(mtd, eraseblock);
 	if (err)
 		goto exit_error;
 
@@ -428,7 +401,7 @@ static int __init mtd_nandbiterrs_init(void)
 		goto exit_error;
 
 	/* We leave the block un-erased in case of test failure. */
-	err = erase_block();
+	err = mtdtest_erase_eraseblock(mtd, eraseblock);
 	if (err)
 		goto exit_error;
 
-- 
1.8.3.1

  parent reply	other threads:[~2013-08-03  9:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03  9:52 [PATCH -next v2 00/10] mtd: tests: reduce duplication among mtd tests modules Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 01/10] mtd: tests: introduce helper functions Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 02/10] mtd: tests: rename sources in order to link a helper object Akinobu Mita
2013-08-30 15:53   ` David Woodhouse
2013-08-30 16:24     ` Brian Norris
2013-08-30 17:17       ` David Woodhouse
2013-09-01  0:51         ` Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 03/10] mtd: mtd_oobtest: use mtd_test helpers Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 04/10] mtd: mtd_pagetest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 05/10] mtd: mtd_readtest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 06/10] mtd: mtd_speedtest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 07/10] mtd: mtd_stresstest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 08/10] mtd: mtd_subpagetest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 09/10] mtd: mtd_torturetest: " Akinobu Mita
2013-08-03  9:52 ` Akinobu Mita [this message]
2013-08-06 14:07 ` [PATCH -next v2 00/10] mtd: tests: reduce duplication among mtd tests modules Artem Bityutskiy
2013-08-07 14:11   ` Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375523536-32671-11-git-send-email-akinobu.mita@gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=Iwo.Mergler@netcommwireless.com.au \
    --cc=adrian.hunter@intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vikram186@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.