All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Iwo Mergler <Iwo.Mergler@netcommwireless.com.au>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Vikram Narayanan <vikram186@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH -next v2 00/10] mtd: tests: reduce duplication among mtd tests modules
Date: Wed, 7 Aug 2013 23:11:07 +0900	[thread overview]
Message-ID: <CAC5umyj=7Eug0Eaqacps1y_2zfzQrU93Z+Ukxgvh=AeXgHRPRA@mail.gmail.com> (raw)
In-Reply-To: <1375798078.30770.145.camel@sauron.fi.intel.com>

2013/8/6 Artem Bityutskiy <dedekind1@gmail.com>:
> On Sat, 2013-08-03 at 18:52 +0900, Akinobu Mita wrote:
>> This patch set reduces code duplication among mtd/tests modules by
>> moving common helper functions into mtd_test.c.
>>
>
> You could make this nicer by incorporating the error messages to the
> common handlers, and removing them from tests - they are almost the same
> everywhere.

Sounds good.  Especially incorporating the error messages to mtdtest_read()
and mtdtest_write() enables to convert some of remaining usages of
mtd_read() and mtd_write in the test modules.

> But this is anyway a good clean-up, so pushed to l2-mtd.git, thanks!

Thanks.

      reply	other threads:[~2013-08-07 14:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03  9:52 [PATCH -next v2 00/10] mtd: tests: reduce duplication among mtd tests modules Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 01/10] mtd: tests: introduce helper functions Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 02/10] mtd: tests: rename sources in order to link a helper object Akinobu Mita
2013-08-30 15:53   ` David Woodhouse
2013-08-30 16:24     ` Brian Norris
2013-08-30 17:17       ` David Woodhouse
2013-09-01  0:51         ` Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 03/10] mtd: mtd_oobtest: use mtd_test helpers Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 04/10] mtd: mtd_pagetest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 05/10] mtd: mtd_readtest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 06/10] mtd: mtd_speedtest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 07/10] mtd: mtd_stresstest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 08/10] mtd: mtd_subpagetest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 09/10] mtd: mtd_torturetest: " Akinobu Mita
2013-08-03  9:52 ` [PATCH -next v2 10/10] mtd: mtd_nandbiterrs: " Akinobu Mita
2013-08-06 14:07 ` [PATCH -next v2 00/10] mtd: tests: reduce duplication among mtd tests modules Artem Bityutskiy
2013-08-07 14:11   ` Akinobu Mita [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC5umyj=7Eug0Eaqacps1y_2zfzQrU93Z+Ukxgvh=AeXgHRPRA@mail.gmail.com' \
    --to=akinobu.mita@gmail.com \
    --cc=Iwo.Mergler@netcommwireless.com.au \
    --cc=adrian.hunter@intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vikram186@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.