Re: [PATCH -next v2 02/10] mtd: tests: rename sources in order to link a helper object

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On Fri, 2013-08-30 at 09:24 -0700, Brian Norris wrote:
> We actually had the discussion (in multiple threads?) that because a 
> separate module would complicate the process for running the test 
> modules, it is preferable to copy the small helper code into each 
> module. That is, we don't want to do this:
> 
> insmod mtd_test.ko
> insmod mtd_<actualtest>.ko dev=X ...

So use modprobe instead :)

> However, this is still fairly trivial, so if you think there are good 
> reasons to provide separate modules, I do not object to separate modules.

Even if you can't use modprobe, once mtd_test.ko is loaded it's going to
stay loaded and you can just forget about it and do your various tests.

Unless you're actually making changes to the code within mtd_test.ko
itself, of course. In which case you really *don't* want to have eight
different copies of it built in to eight different modules. I know that
making changes to that code is going to be relatively infrequent, but we
probably shouldn't make it suck *this* much :)

-- 
dwmw2


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]