[DYLAN] RPATH issue with qt5's qtwebkit

[DYLAN] RPATH issue with qt5's qtwebkit

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

Hi,

When I try to include "qtwebkit" in my image from the "dylan" branch I end
up
with the following QA do_package_qa error [note that this does not happen
with "master"]:

ERROR: QA Issue: package qtwebkit contains bad RPATH
/home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
in file
/home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/packages-split/qtwebkit/usr/lib/qt5/libexec/QtWebProcess

And the QA test is correct. When I "objdump -x" this binary I get:

Dynamic Section:
  NEEDED               libQt5WebKitWidgets.so.5
  NEEDED               libQt5WebKit.so.5
  NEEDED               libQt5Widgets.so.5
  NEEDED               libQt5Core.so.5
  NEEDED               libstdc++.so.6
  NEEDED               libc.so.6
  RPATH
/home/trevor/build/yocto/tmp/rdk/work/armv5te-rdk-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib

Can anyone suggest any fixes or patches? Note I'm using 5.0.2.

Best regards,
    Trevor

[-- Attachment #2: Type: text/html, Size: 1187 bytes --]

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Richard Purdie]

On Fri, 2013-08-23 at 21:36 -0400, Trevor Woerner wrote:
> When I try to include "qtwebkit" in my image from the "dylan" branch I end up
> with the following QA do_package_qa error [note that this does not happen
> with "master"]:
> 
> ERROR: QA Issue: package qtwebkit contains bad RPATH /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib in file /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/packages-split/qtwebkit/usr/lib/qt5/libexec/QtWebProcess
> 
> 
> And the QA test is correct. When I "objdump -x" this binary I get:
> 
> Dynamic Section:
>   NEEDED               libQt5WebKitWidgets.so.5
>   NEEDED               libQt5WebKit.so.5
>   NEEDED               libQt5Widgets.so.5
>   NEEDED               libQt5Core.so.5
>   NEEDED               libstdc++.so.6
>   NEEDED               libc.so.6
>   RPATH                /home/trevor/build/yocto/tmp/rdk/work/armv5te-rdk-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
> 
> 
> Can anyone suggest any fixes or patches? Note I'm using 5.0.2.

Check the compile logs. Somewhere, something is passing a -rpath value
to the linker which results in this. You'll have to find out where it
gets passed in, then trace it back to the source of the problem.
Sometimes this can get added by libtool but there will still be
something on the commandline which triggers libtool to do that.

Cheers,

Richard

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Erik Botö]

On Sat, Aug 24, 2013 at 3:36 AM, Trevor Woerner
<trevor.woerner@linaro.org> wrote:
> Hi,
>
> When I try to include "qtwebkit" in my image from the "dylan" branch I end
> up
> with the following QA do_package_qa error [note that this does not happen
> with "master"]:
>
> ERROR: QA Issue: package qtwebkit contains bad RPATH
> /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
> in file
> /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/packages-split/qtwebkit/usr/lib/qt5/libexec/QtWebProcess
>
> And the QA test is correct. When I "objdump -x" this binary I get:
>
> Dynamic Section:
>   NEEDED               libQt5WebKitWidgets.so.5
>   NEEDED               libQt5WebKit.so.5
>   NEEDED               libQt5Widgets.so.5
>   NEEDED               libQt5Core.so.5
>   NEEDED               libstdc++.so.6
>   NEEDED               libc.so.6
>   RPATH
> /home/trevor/build/yocto/tmp/rdk/work/armv5te-rdk-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
>
> Can anyone suggest any fixes or patches? Note I'm using 5.0.2.

Try adding a .bbappend with the following content:

#################
DEPENDS += "chrpath-replacement-native"
EXTRANATIVEPATH += "chrpath-native"

PRINC := "${@int(PRINC) + 1}"

do_install_append() {
        # Remove rpath from the offending binaries
        chrpath -d ${D}${OE_QMAKE_PATH_LIBEXECS}/QtWebProcess
}
#################

That should do it.

Is this something everyone building qtwebkit is seeing? I had just
assumed that it had something to do with other changes I do to
meta-qt5, but if it affect everyone I guess it could be done in
meta-qt5 instead of local bbappends.

Cheers
Erik


>
> Best regards,
>     Trevor
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3064 bytes --]

On Sat, Aug 24, 2013 at 03:06:21PM +0200, Erik Botö wrote:
> On Sat, Aug 24, 2013 at 3:36 AM, Trevor Woerner
> <trevor.woerner@linaro.org> wrote:
> > Hi,
> >
> > When I try to include "qtwebkit" in my image from the "dylan" branch I end
> > up
> > with the following QA do_package_qa error [note that this does not happen
> > with "master"]:
> >
> > ERROR: QA Issue: package qtwebkit contains bad RPATH
> > /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
> > in file
> > /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/packages-split/qtwebkit/usr/lib/qt5/libexec/QtWebProcess
> >
> > And the QA test is correct. When I "objdump -x" this binary I get:
> >
> > Dynamic Section:
> >   NEEDED               libQt5WebKitWidgets.so.5
> >   NEEDED               libQt5WebKit.so.5
> >   NEEDED               libQt5Widgets.so.5
> >   NEEDED               libQt5Core.so.5
> >   NEEDED               libstdc++.so.6
> >   NEEDED               libc.so.6
> >   RPATH
> > /home/trevor/build/yocto/tmp/rdk/work/armv5te-rdk-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
> >
> > Can anyone suggest any fixes or patches? Note I'm using 5.0.2.
> 
> Try adding a .bbappend with the following content:
> 
> #################
> DEPENDS += "chrpath-replacement-native"
> EXTRANATIVEPATH += "chrpath-native"
> 
> PRINC := "${@int(PRINC) + 1}"
> 
> do_install_append() {
>         # Remove rpath from the offending binaries
>         chrpath -d ${D}${OE_QMAKE_PATH_LIBEXECS}/QtWebProcess
> }
> #################
> 
> That should do it.
> 
> Is this something everyone building qtwebkit is seeing? I had just
> assumed that it had something to do with other changes I do to
> meta-qt5, but if it affect everyone I guess it could be done in
> meta-qt5 instead of local bbappends.

Yes I think everyone is seeing it, but in many distro configs bad RPATH
is only QA warning not error (that's why I was partially ignoring it
until now, concentrating on other issues).

You can see do_configure_append in qtwebkit.inc which is removing bad
rpath from qmake generated Makefile, this sometimes doesn't work, from
similar Makefile issue in qtjsondb I know that "sometimes" Makefile
generated in do_configure is regenerated later in do_compile or
do_install task, I'm not sure yet why, but that's what breaks similar
hack in qtjsondb_git.bb:do_configure_append().

Of course the real fix for both issues would be to fix .pri/.prf files
to prevent incorrect Makefile to be generated at all.

Regards,

> 
> Cheers
> Erik
> 
> 
> >
> > Best regards,
> >     Trevor
> >
> > _______________________________________________
> > yocto mailing list
> > yocto@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/yocto
> >
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Richard Purdie]

On Sat, 2013-08-24 at 15:06 +0200, Erik Botö wrote:
> On Sat, Aug 24, 2013 at 3:36 AM, Trevor Woerner
> <trevor.woerner@linaro.org> wrote:
> > Hi,
> >
> > When I try to include "qtwebkit" in my image from the "dylan" branch I end
> > up
> > with the following QA do_package_qa error [note that this does not happen
> > with "master"]:
> >
> > ERROR: QA Issue: package qtwebkit contains bad RPATH
> > /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
> > in file
> > /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/packages-split/qtwebkit/usr/lib/qt5/libexec/QtWebProcess
> >
> > And the QA test is correct. When I "objdump -x" this binary I get:
> >
> > Dynamic Section:
> >   NEEDED               libQt5WebKitWidgets.so.5
> >   NEEDED               libQt5WebKit.so.5
> >   NEEDED               libQt5Widgets.so.5
> >   NEEDED               libQt5Core.so.5
> >   NEEDED               libstdc++.so.6
> >   NEEDED               libc.so.6
> >   RPATH
> > /home/trevor/build/yocto/tmp/rdk/work/armv5te-rdk-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
> >
> > Can anyone suggest any fixes or patches? Note I'm using 5.0.2.
> 
> Try adding a .bbappend with the following content:
> 
> #################
> DEPENDS += "chrpath-replacement-native"
> EXTRANATIVEPATH += "chrpath-native"
> 
> PRINC := "${@int(PRINC) + 1}"
> 
> do_install_append() {
>         # Remove rpath from the offending binaries
>         chrpath -d ${D}${OE_QMAKE_PATH_LIBEXECS}/QtWebProcess
> }
> #################
> 
> That should do it.
> 
> Is this something everyone building qtwebkit is seeing? I had just
> assumed that it had something to do with other changes I do to
> meta-qt5, but if it affect everyone I guess it could be done in
> meta-qt5 instead of local bbappends.

The above is a workaround, the proper fix is to track down why this is
making its way in there in the first place and fix the problem at
source.

Cheers,

Richard

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Belisko Marek]

Hi All,

On Sat, Aug 24, 2013 at 6:03 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sat, 2013-08-24 at 15:06 +0200, Erik Botö wrote:
>> On Sat, Aug 24, 2013 at 3:36 AM, Trevor Woerner
>> <trevor.woerner@linaro.org> wrote:
>> > Hi,
>> >
>> > When I try to include "qtwebkit" in my image from the "dylan" branch I end
>> > up
>> > with the following QA do_package_qa error [note that this does not happen
>> > with "master"]:
>> >
>> > ERROR: QA Issue: package qtwebkit contains bad RPATH
>> > /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
>> > in file
>> > /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/packages-split/qtwebkit/usr/lib/qt5/libexec/QtWebProcess
>> >
>> > And the QA test is correct. When I "objdump -x" this binary I get:
>> >
>> > Dynamic Section:
>> >   NEEDED               libQt5WebKitWidgets.so.5
>> >   NEEDED               libQt5WebKit.so.5
>> >   NEEDED               libQt5Widgets.so.5
>> >   NEEDED               libQt5Core.so.5
>> >   NEEDED               libstdc++.so.6
>> >   NEEDED               libc.so.6
>> >   RPATH
>> > /home/trevor/build/yocto/tmp/rdk/work/armv5te-rdk-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
>> >
>> > Can anyone suggest any fixes or patches? Note I'm using 5.0.2.
>>
>> Try adding a .bbappend with the following content:
>>
>> #################
>> DEPENDS += "chrpath-replacement-native"
>> EXTRANATIVEPATH += "chrpath-native"
>>
>> PRINC := "${@int(PRINC) + 1}"
>>
>> do_install_append() {
>>         # Remove rpath from the offending binaries
>>         chrpath -d ${D}${OE_QMAKE_PATH_LIBEXECS}/QtWebProcess
>> }
>> #################
>>
>> That should do it.
>>
>> Is this something everyone building qtwebkit is seeing? I had just
>> assumed that it had something to do with other changes I do to
>> meta-qt5, but if it affect everyone I guess it could be done in
>> meta-qt5 instead of local bbappends.
>
> The above is a workaround, the proper fix is to track down why this is
> making its way in there in the first place and fix the problem at
> source.
Just my 2 cents.
I have similar issue some time ago and I fix it following way (it's
also workaround and maybe help somebody to find correct solution):
---
 Tools/qmake/mkspecs/features/rpath.prf |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Tools/qmake/mkspecs/features/rpath.prf
b/Tools/qmake/mkspecs/features/rpath.prf
index 8dbc42f..487f12f 100644
--- a/Tools/qmake/mkspecs/features/rpath.prf
+++ b/Tools/qmake/mkspecs/features/rpath.prf
@@ -9,13 +9,13 @@ equals(ROOT_BUILD_DIR, $$dirname(DESTDIR)):
RPATHDIR_RELATIVE_TO_DESTDIR = ../li
 linux-*:!isEmpty(RPATHDIR_RELATIVE_TO_DESTDIR) {
     # Do the rpath by hand since it's not possible to use ORIGIN in
QMAKE_RPATHDIR
     # this expands to $ORIGIN (after qmake and make), it does NOT
read a qmake var.
-    QMAKE_RPATHDIR = \$\$ORIGIN/$${RPATHDIR_RELATIVE_TO_DESTDIR}
$${QMAKE_RPATHDIR}
+#    QMAKE_RPATHDIR = \$\$ORIGIN/$${RPATHDIR_RELATIVE_TO_DESTDIR}
$${QMAKE_RPATHDIR}
     RPATH = $$join(QMAKE_RPATHDIR, ":")

-    QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${RPATH}\'
+#    QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${RPATH}\'
     QMAKE_RPATHDIR =
 } else {
-    QMAKE_RPATHDIR = $${ROOT_BUILD_DIR}/lib $${QMAKE_RPATHDIR}
+#    QMAKE_RPATHDIR = $${ROOT_BUILD_DIR}/lib $${QMAKE_RPATHDIR}
 }

 # FIXME: For Qt5 this will only give correct rpath for the tools that
come with WebKit
-- 
1.7.9.5
>
> Cheers,
>
> Richard
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Fathi Boudra]

Hi,

On 24 August 2013 04:36, Trevor Woerner <trevor.woerner@linaro.org> wrote:
> Hi,
>
> When I try to include "qtwebkit" in my image from the "dylan" branch I end
> up
> with the following QA do_package_qa error [note that this does not happen
> with "master"]:
>
> ERROR: QA Issue: package qtwebkit contains bad RPATH
> /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
> in file
> /home/trevor/build/yocto/tmp/dylan/work/armv5te-poky-linux-gnueabi/qtwebkit/5.0.2-r0.0/packages-split/qtwebkit/usr/lib/qt5/libexec/QtWebProcess
>
> And the QA test is correct. When I "objdump -x" this binary I get:
>
> Dynamic Section:
>   NEEDED               libQt5WebKitWidgets.so.5
>   NEEDED               libQt5WebKit.so.5
>   NEEDED               libQt5Widgets.so.5
>   NEEDED               libQt5Core.so.5
>   NEEDED               libstdc++.so.6
>   NEEDED               libc.so.6
>   RPATH
> /home/trevor/build/yocto/tmp/rdk/work/armv5te-rdk-linux-gnueabi/qtwebkit/5.0.2-r0.0/build/lib
>
> Can anyone suggest any fixes or patches? Note I'm using 5.0.2.

I haven't checked how qtwebkit is built or meta-qt5, but the Qt's
configure has -no-rpath option. A grep on meta-qt5 doesn't show any
usage of it.

Cheers,
Fathi

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Trevor Woerner]

Hi Fathi,

On 26 August 2013 07:11, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> I haven't checked how qtwebkit is built or meta-qt5, but the Qt's
> configure has -no-rpath option. A grep on meta-qt5 doesn't show any
> usage of it.

A "-no-rpath" option looks like something that might be passed to
./configure? I'm not sure if things are done differently on master,
but on dylan qmake is used to generate the Makefiles. Or is
"-no-rpath" something that can be passed to "qmake"?

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Trevor Woerner]

Hi Martin,

On 24 August 2013 10:11, Martin Jansa <martin.jansa@gmail.com> wrote:
> You can see do_configure_append in qtwebkit.inc which is removing bad
> rpath from qmake generated Makefile, this sometimes doesn't work

Yes, I've been seeing the exact same thing. Although this _append
claims to be fixing the rpath issue, I'm still seeing QA issues (which
lead to errors) build packaging qtwebkit.

Interestingly enough, the _append you mention is only trying to fix
QtWebProcess but I'm seeing this rpath error occur on both it and
QtWebPluginProcess.

> Of course the real fix for both issues would be to fix .pri/.prf files
> to prevent incorrect Makefile to be generated at all.

As you, Richard, and everyone else has mentioned it would be nice to
have a "proper" fix instead of things which patch up files afterward.
This is why I like Marek's proposal since it fixes the *.prf file
before the build. Looking through that patch, however, I'm wondering
if it couldn't be a little cleaner? Marek's patch simply comments out
a couple lines. I think it would be cleaner to just remove the lines
that are causing problems and/or investigate whether or not that *.prf
file is actually needed at all in this build environment.

Are there any comments on what Marek has targetted? Would others
consider this a "proper" fix (if the patch were cleaned up)?

Best regards,
    Trevor

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Fathi Boudra]

On 17 September 2013 04:23, Trevor Woerner <trevor.woerner@linaro.org> wrote:
> Hi Fathi,
>
> On 26 August 2013 07:11, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> I haven't checked how qtwebkit is built or meta-qt5, but the Qt's
>> configure has -no-rpath option. A grep on meta-qt5 doesn't show any
>> usage of it.
>
> A "-no-rpath" option looks like something that might be passed to
> ./configure? I'm not sure if things are done differently on master,
> but on dylan qmake is used to generate the Makefiles. Or is
> "-no-rpath" something that can be passed to "qmake"?

It's a configure argument. Unfortunately, it doesn't help in this case.
afaics, most distro are using chrpath hack to get rid of it in
QtWebProcess and QtWebPluginProcess.
A "proper" fix ins't available yet... it doesn't seem trivial, see
https://github.com/WebKit/webkit/commit/069ee433aba1ae8ae5107784b22bd6ade830a012

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Trevor Woerner]

Hi Fathi,

On 18 September 2013 17:52, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> afaics, most distro are using chrpath hack to get rid of it in
> QtWebProcess and QtWebPluginProcess.

That's good to know. For some odd reason (as Martin pointed out) the
chrpath hack in OE doesn't always seem to kick in. In my case it
always fails so I'll try to target the "proper" fix.

> A "proper" fix ins't available yet... it doesn't seem trivial, see
> https://github.com/WebKit/webkit/commit/069ee433aba1ae8ae5107784b22bd6ade830a012

Excellent! Thanks for digging this up :-)

It *appears*, however, that this patch has already been applied to the
sources obtained from meta-qt5's 5.0.2 build (although I can't seem to
verify that conclusively via the ChangeLog). If I look through the
sources the comments at the bottom of, and lack of qt4 specifics in,
Tools/qmake/mkspecs/features/rpath.prf would appear to match.

I'll create a patch based on what Marek had done and see what people
think of it. In this case, though, I'm not sure how to assign credit
(is there a "based-on-the-previous-work-of SOB-type line?).

Best regards,
    Trevor

Re: [DYLAN] RPATH issue with qt5's qtwebkit

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

On 18 September 2013 21:36, Trevor Woerner <trevor.woerner@linaro.org>
wrote:
> I'll create a patch

I have created two patches:
- one for dylan:
http://article.gmane.org/gmane.comp.handhelds.openembedded/59766
- one for master:
http://article.gmane.org/gmane.comp.handhelds.openembedded/59795

Which I'm hoping will be found acceptable for merging.

[-- Attachment #2: Type: text/html, Size: 678 bytes --]