From: "Jon Medhurst (Tixy)" <tixy@linaro.org> To: David Long <dave.long@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, Rabin Vincent <rabin@rab.in>, Oleg Nesterov <oleg@redhat.com>, Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/13] ARM: move generic thumb instruction parsing code to new files for use by other features Date: Wed, 13 Nov 2013 17:09:01 +0000 [thread overview] Message-ID: <1384362541.3392.40.camel@linaro1.home> (raw) In-Reply-To: <1381871068-27660-8-git-send-email-dave.long@linaro.org> On Tue, 2013-10-15 at 17:04 -0400, David Long wrote: > From: "David A. Long" <dave.long@linaro.org> > > Move the thumb version of the kprobes instruction parsing code into more generic This patch is moving the 'ARM' instructions, not 'thumb' instructions, so both description and title needs fixing for that. Actually, after looking at patch 08/13, that one seems to erroneously include the thumb reorg, I'm guessing that was meant to be in this patch instead, or in a standalone patch? > files from where it can be used by uprobes and possibly other subsystems. The > symbol names will be made more generic in a subsequent part of this patchset. > > Signed-off-by: David A. Long <dave.long@linaro.org> > --- > arch/arm/include/asm/probes.h | 2 + > arch/arm/kernel/Makefile | 4 +- > arch/arm/kernel/kprobes-arm.c | 723 +------------------------------------- > arch/arm/kernel/kprobes-common.c | 422 +--------------------- > arch/arm/kernel/kprobes-test.c | 1 + > arch/arm/kernel/kprobes-thumb.c | 1 + > arch/arm/kernel/kprobes.c | 1 + > arch/arm/kernel/kprobes.h | 372 -------------------- > arch/arm/kernel/probes-arm.c | 730 +++++++++++++++++++++++++++++++++++++++ > arch/arm/kernel/probes-arm.h | 38 ++ > arch/arm/kernel/probes.c | 441 +++++++++++++++++++++++ > arch/arm/kernel/probes.h | 395 +++++++++++++++++++++ > 12 files changed, 1622 insertions(+), 1508 deletions(-) > create mode 100644 arch/arm/kernel/probes-arm.c > create mode 100644 arch/arm/kernel/probes-arm.h > create mode 100644 arch/arm/kernel/probes.c > create mode 100644 arch/arm/kernel/probes.h A git tip: if you use the -C argument with git format-patch (and send-email I assume) then it will detect files which are copies of others and produce a much smaller patch, as well as a more informative file summary. I believe that this is OK for submissions posted to mailing lists, I know that I've seen people regularly reminded to use -M (which detects file renames). [...] > --- a/arch/arm/kernel/kprobes-arm.c > +++ b/arch/arm/kernel/kprobes-arm.c > @@ -63,10 +63,8 @@ > #include <linux/module.h> > > #include "kprobes.h" > - > -#define sign_extend(x, signbit) ((x) | (0 - ((x) & (1 << (signbit))))) > - > -#define branch_displacement(insn) sign_extend(((insn) & 0xffffff) << 2, 25) > +#include "probes.h" Rather than include "probes.h" after "kprobes.h" here, (and in the other 7 places in this patch, and other patches) I think it would make more sense to have kprobes.h include probes.h as kprobes code is always going to depend on the new generic probe functions. I've trimmed the rest of this large patch as I have no other comments except the above. -- Tixy
WARNING: multiple messages have this Message-ID (diff)
From: tixy@linaro.org (Jon Medhurst (Tixy)) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 07/13] ARM: move generic thumb instruction parsing code to new files for use by other features Date: Wed, 13 Nov 2013 17:09:01 +0000 [thread overview] Message-ID: <1384362541.3392.40.camel@linaro1.home> (raw) In-Reply-To: <1381871068-27660-8-git-send-email-dave.long@linaro.org> On Tue, 2013-10-15 at 17:04 -0400, David Long wrote: > From: "David A. Long" <dave.long@linaro.org> > > Move the thumb version of the kprobes instruction parsing code into more generic This patch is moving the 'ARM' instructions, not 'thumb' instructions, so both description and title needs fixing for that. Actually, after looking at patch 08/13, that one seems to erroneously include the thumb reorg, I'm guessing that was meant to be in this patch instead, or in a standalone patch? > files from where it can be used by uprobes and possibly other subsystems. The > symbol names will be made more generic in a subsequent part of this patchset. > > Signed-off-by: David A. Long <dave.long@linaro.org> > --- > arch/arm/include/asm/probes.h | 2 + > arch/arm/kernel/Makefile | 4 +- > arch/arm/kernel/kprobes-arm.c | 723 +------------------------------------- > arch/arm/kernel/kprobes-common.c | 422 +--------------------- > arch/arm/kernel/kprobes-test.c | 1 + > arch/arm/kernel/kprobes-thumb.c | 1 + > arch/arm/kernel/kprobes.c | 1 + > arch/arm/kernel/kprobes.h | 372 -------------------- > arch/arm/kernel/probes-arm.c | 730 +++++++++++++++++++++++++++++++++++++++ > arch/arm/kernel/probes-arm.h | 38 ++ > arch/arm/kernel/probes.c | 441 +++++++++++++++++++++++ > arch/arm/kernel/probes.h | 395 +++++++++++++++++++++ > 12 files changed, 1622 insertions(+), 1508 deletions(-) > create mode 100644 arch/arm/kernel/probes-arm.c > create mode 100644 arch/arm/kernel/probes-arm.h > create mode 100644 arch/arm/kernel/probes.c > create mode 100644 arch/arm/kernel/probes.h A git tip: if you use the -C argument with git format-patch (and send-email I assume) then it will detect files which are copies of others and produce a much smaller patch, as well as a more informative file summary. I believe that this is OK for submissions posted to mailing lists, I know that I've seen people regularly reminded to use -M (which detects file renames). [...] > --- a/arch/arm/kernel/kprobes-arm.c > +++ b/arch/arm/kernel/kprobes-arm.c > @@ -63,10 +63,8 @@ > #include <linux/module.h> > > #include "kprobes.h" > - > -#define sign_extend(x, signbit) ((x) | (0 - ((x) & (1 << (signbit))))) > - > -#define branch_displacement(insn) sign_extend(((insn) & 0xffffff) << 2, 25) > +#include "probes.h" Rather than include "probes.h" after "kprobes.h" here, (and in the other 7 places in this patch, and other patches) I think it would make more sense to have kprobes.h include probes.h as kprobes code is always going to depend on the new generic probe functions. I've trimmed the rest of this large patch as I have no other comments except the above. -- Tixy
next prev parent reply other threads:[~2013-11-13 17:09 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-15 21:04 [PATCH v2 00/13] uprobes: Add uprobes support for ARM David Long 2013-10-15 21:04 ` David Long 2013-10-15 21:04 ` [PATCH v2 01/13] uprobes: move function declarations out of arch David Long 2013-10-15 21:04 ` David Long 2013-11-05 16:01 ` Oleg Nesterov 2013-11-05 16:01 ` Oleg Nesterov 2013-11-05 18:16 ` Oleg Nesterov 2013-11-05 18:16 ` Oleg Nesterov 2013-11-05 19:01 ` [PATCH] uprobes: Export write_opcode() as uprobe_write_opcode() Oleg Nesterov 2013-11-05 19:01 ` Oleg Nesterov 2013-11-05 19:55 ` David Long 2013-11-05 19:55 ` David Long 2013-11-05 19:13 ` [PATCH v2 01/13] uprobes: move function declarations out of arch David Long 2013-11-05 19:13 ` David Long 2013-10-15 21:04 ` [PATCH v2 02/13] uprobes: allow ignoring of probe hits David Long 2013-10-15 21:04 ` David Long 2013-10-19 17:02 ` Oleg Nesterov 2013-10-19 17:02 ` Oleg Nesterov 2013-10-22 3:45 ` David Long 2013-10-22 3:45 ` David Long 2013-10-22 11:25 ` Oleg Nesterov 2013-10-22 11:25 ` Oleg Nesterov 2013-10-22 23:56 ` David Long 2013-10-22 23:56 ` David Long 2013-10-28 18:54 ` Oleg Nesterov 2013-10-28 18:54 ` Oleg Nesterov 2013-10-30 21:11 ` David Long 2013-10-30 21:11 ` David Long 2013-10-15 21:04 ` [PATCH v2 03/13] uprobes: allow arch access to xol slot David Long 2013-10-15 21:04 ` David Long 2013-10-19 16:36 ` Oleg Nesterov 2013-10-19 16:36 ` Oleg Nesterov 2013-10-23 0:03 ` David Long 2013-10-23 0:03 ` David Long 2013-10-29 15:40 ` Oleg Nesterov 2013-10-29 15:40 ` Oleg Nesterov 2013-11-04 19:49 ` [PATCH] uprobes: introduce arch_uprobe->ixol Oleg Nesterov 2013-11-04 19:49 ` Oleg Nesterov 2013-11-04 21:25 ` David Long 2013-11-04 21:25 ` David Long 2013-11-05 16:04 ` David Long 2013-11-05 16:04 ` David Long 2013-11-05 18:01 ` Oleg Nesterov 2013-11-05 18:01 ` Oleg Nesterov 2013-11-05 18:45 ` David Long 2013-11-05 18:45 ` David Long 2013-10-15 21:04 ` [PATCH v2 04/13] uprobes: allow arch-specific initialization David Long 2013-10-15 21:04 ` David Long 2013-10-19 16:42 ` Oleg Nesterov 2013-10-19 16:42 ` Oleg Nesterov 2013-10-23 1:21 ` David Long 2013-10-23 1:21 ` David Long 2013-10-28 18:58 ` Oleg Nesterov 2013-10-28 18:58 ` Oleg Nesterov 2013-10-31 18:41 ` David Long 2013-10-31 18:41 ` David Long 2013-11-01 13:52 ` Oleg Nesterov 2013-11-01 13:52 ` Oleg Nesterov 2013-11-04 3:24 ` David Long 2013-11-04 3:24 ` David Long 2013-10-15 21:04 ` [PATCH v2 05/13] uprobes: add arch write opcode hook David Long 2013-10-15 21:04 ` David Long 2013-10-19 16:50 ` Oleg Nesterov 2013-10-19 16:50 ` Oleg Nesterov 2013-10-23 18:20 ` David Long 2013-10-23 18:20 ` David Long 2013-10-28 19:49 ` Oleg Nesterov 2013-10-28 19:49 ` Oleg Nesterov 2013-10-29 19:59 ` Oleg Nesterov 2013-10-29 19:59 ` Oleg Nesterov 2013-11-02 3:33 ` David Long 2013-11-02 3:33 ` David Long 2013-11-02 14:03 ` Oleg Nesterov 2013-11-02 14:03 ` Oleg Nesterov 2013-10-15 21:04 ` [PATCH v2 06/13] ARM: move shared uprobe/kprobe definitions into new include file David Long 2013-10-15 21:04 ` David Long 2013-10-15 21:04 ` [PATCH v2 07/13] ARM: move generic thumb instruction parsing code to new files for use by other features David Long 2013-11-13 17:09 ` Jon Medhurst (Tixy) [this message] 2013-11-13 17:09 ` Jon Medhurst (Tixy) 2013-11-14 14:13 ` David Long 2013-11-14 14:13 ` David Long 2013-10-15 21:04 ` [PATCH v2 08/13] ARM: use a function table for determining instruction interpreter actions David Long 2013-11-13 17:11 ` Jon Medhurst (Tixy) 2013-11-13 17:11 ` Jon Medhurst (Tixy) 2013-11-14 15:17 ` David Long 2013-11-14 15:17 ` David Long 2013-10-15 21:04 ` [PATCH v2 09/13] ARM: Disable jprobe selftests in thumb kernels David Long 2013-10-15 21:04 ` David Long 2013-11-07 17:26 ` Jon Medhurst (Tixy) 2013-11-07 17:26 ` Jon Medhurst (Tixy) 2013-11-10 22:57 ` David Long 2013-11-10 22:57 ` David Long 2013-10-15 21:04 ` [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn David Long 2013-10-15 21:04 ` David Long 2013-11-13 17:13 ` Jon Medhurst (Tixy) 2013-11-13 17:13 ` Jon Medhurst (Tixy) 2013-11-14 2:02 ` Masami Hiramatsu 2013-11-14 2:02 ` Masami Hiramatsu 2013-11-14 14:15 ` Jon Medhurst (Tixy) 2013-11-14 14:15 ` Jon Medhurst (Tixy) 2013-11-14 20:33 ` David Long 2013-11-14 20:33 ` David Long 2013-11-15 10:23 ` Masami Hiramatsu 2013-11-15 10:23 ` Masami Hiramatsu 2013-11-15 15:16 ` David Long 2013-11-15 15:16 ` David Long 2013-11-15 10:11 ` Re: " Masami Hiramatsu 2013-11-15 10:11 ` Masami Hiramatsu 2013-11-14 1:20 ` Masami Hiramatsu 2013-11-14 1:20 ` Masami Hiramatsu 2013-10-15 21:04 ` [PATCH v2 11/13] ARM: Finish renaming ARM kprobes APIs for sharing with uprobes David Long 2013-10-15 21:04 ` David Long 2013-11-13 17:16 ` Jon Medhurst (Tixy) 2013-11-13 17:16 ` Jon Medhurst (Tixy) 2013-11-15 15:45 ` David Long 2013-11-15 15:45 ` David Long 2013-10-15 21:04 ` [PATCH v2 12/13] ARM: add uprobes support David Long 2013-10-15 21:04 ` David Long 2013-10-15 21:04 ` [PATCH v2 13/13] ARM: Remove uprobes dependency on kprobes David Long 2013-10-15 21:04 ` David Long
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1384362541.3392.40.camel@linaro1.home \ --to=tixy@linaro.org \ --cc=dave.long@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=oleg@redhat.com \ --cc=rabin@rab.in \ --cc=srikar@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.