All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org,
	shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	marex-ynQEQJNshbs@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v5 03/15] usb: phy-mxs: Add auto clock and power setting
Date: Mon, 9 Dec 2013 14:30:52 +0800	[thread overview]
Message-ID: <1386570664-6713-4-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1386570664-6713-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

With the auto setting, the PHY's clock and power can be
recovered correctly from low power mode, it is ganranteed by IC logic.

Signed-off-by: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/usb/phy/phy-mxs-usb.c |   20 +++++++++++++++++---
 1 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 6d49040..0c6f3bc 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -31,6 +31,11 @@
 
 #define BM_USBPHY_CTRL_SFTRST			BIT(31)
 #define BM_USBPHY_CTRL_CLKGATE			BIT(30)
+#define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS	BIT(26)
+#define BM_USBPHY_CTRL_ENAUTOCLR_USBCLKGATE	BIT(25)
+#define BM_USBPHY_CTRL_ENAUTOCLR_PHY_PWD	BIT(20)
+#define BM_USBPHY_CTRL_ENAUTOCLR_CLKGATE	BIT(19)
+#define BM_USBPHY_CTRL_ENAUTO_PWRON_PLL		BIT(18)
 #define BM_USBPHY_CTRL_ENUTMILEVEL3		BIT(15)
 #define BM_USBPHY_CTRL_ENUTMILEVEL2		BIT(14)
 #define BM_USBPHY_CTRL_ENHOSTDISCONDETECT	BIT(1)
@@ -96,9 +101,18 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
 	/* Power up the PHY */
 	writel(0, base + HW_USBPHY_PWD);
 
-	/* enable FS/LS device */
-	writel(BM_USBPHY_CTRL_ENUTMILEVEL2 |
-	       BM_USBPHY_CTRL_ENUTMILEVEL3,
+	/*
+	 * USB PHY Ctrl Setting
+	 * - Auto clock/power on
+	 * - Enable full/low speed support
+	 */
+	writel(BM_USBPHY_CTRL_ENAUTOSET_USBCLKS |
+		BM_USBPHY_CTRL_ENAUTOCLR_USBCLKGATE |
+		BM_USBPHY_CTRL_ENAUTOCLR_PHY_PWD |
+		BM_USBPHY_CTRL_ENAUTOCLR_CLKGATE |
+		BM_USBPHY_CTRL_ENAUTO_PWRON_PLL |
+		BM_USBPHY_CTRL_ENUTMILEVEL2 |
+		BM_USBPHY_CTRL_ENUTMILEVEL3,
 	       base + HW_USBPHY_CTRL_SET);
 
 	return 0;
-- 
1.7.8


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 03/15] usb: phy-mxs: Add auto clock and power setting
Date: Mon, 9 Dec 2013 14:30:52 +0800	[thread overview]
Message-ID: <1386570664-6713-4-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1386570664-6713-1-git-send-email-peter.chen@freescale.com>

With the auto setting, the PHY's clock and power can be
recovered correctly from low power mode, it is ganranteed by IC logic.

Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 drivers/usb/phy/phy-mxs-usb.c |   20 +++++++++++++++++---
 1 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 6d49040..0c6f3bc 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -31,6 +31,11 @@
 
 #define BM_USBPHY_CTRL_SFTRST			BIT(31)
 #define BM_USBPHY_CTRL_CLKGATE			BIT(30)
+#define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS	BIT(26)
+#define BM_USBPHY_CTRL_ENAUTOCLR_USBCLKGATE	BIT(25)
+#define BM_USBPHY_CTRL_ENAUTOCLR_PHY_PWD	BIT(20)
+#define BM_USBPHY_CTRL_ENAUTOCLR_CLKGATE	BIT(19)
+#define BM_USBPHY_CTRL_ENAUTO_PWRON_PLL		BIT(18)
 #define BM_USBPHY_CTRL_ENUTMILEVEL3		BIT(15)
 #define BM_USBPHY_CTRL_ENUTMILEVEL2		BIT(14)
 #define BM_USBPHY_CTRL_ENHOSTDISCONDETECT	BIT(1)
@@ -96,9 +101,18 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
 	/* Power up the PHY */
 	writel(0, base + HW_USBPHY_PWD);
 
-	/* enable FS/LS device */
-	writel(BM_USBPHY_CTRL_ENUTMILEVEL2 |
-	       BM_USBPHY_CTRL_ENUTMILEVEL3,
+	/*
+	 * USB PHY Ctrl Setting
+	 * - Auto clock/power on
+	 * - Enable full/low speed support
+	 */
+	writel(BM_USBPHY_CTRL_ENAUTOSET_USBCLKS |
+		BM_USBPHY_CTRL_ENAUTOCLR_USBCLKGATE |
+		BM_USBPHY_CTRL_ENAUTOCLR_PHY_PWD |
+		BM_USBPHY_CTRL_ENAUTOCLR_CLKGATE |
+		BM_USBPHY_CTRL_ENAUTO_PWRON_PLL |
+		BM_USBPHY_CTRL_ENUTMILEVEL2 |
+		BM_USBPHY_CTRL_ENUTMILEVEL3,
 	       base + HW_USBPHY_CTRL_SET);
 
 	return 0;
-- 
1.7.8

  parent reply	other threads:[~2013-12-09  6:30 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  6:30 [PATCH v5 00/15] Add power management support for mxs phy Peter Chen
2013-12-09  6:30 ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-09  6:30   ` Peter Chen
     [not found] ` <1386570664-6713-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-09  6:30   ` [PATCH v5 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-09  6:30     ` Peter Chen
2013-12-09  6:30   ` Peter Chen [this message]
2013-12-09  6:30     ` [PATCH v5 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-09  6:30   ` [PATCH v5 05/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-12-09  6:30     ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 06/15] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 07/15] usb: phy: add notify suspend and resume callback Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  8:31   ` Marc Kleine-Budde
2013-12-09  8:31     ` Marc Kleine-Budde
2013-12-09  9:00     ` Peter Chen
2013-12-09  9:00       ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 09/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  8:38   ` Marc Kleine-Budde
2013-12-09  8:38     ` Marc Kleine-Budde
2013-12-09  9:07     ` Peter Chen
2013-12-09  9:07       ` Peter Chen
2013-12-09  9:52       ` Marc Kleine-Budde
2013-12-09  9:52         ` Marc Kleine-Budde
2013-12-10  1:45         ` Peter Chen
2013-12-10  1:45           ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 10/15] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 11/15] usb: phy-mxs: add " Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 12/15] usb: phy: Add set_wakeup API Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  8:41   ` Marc Kleine-Budde
2013-12-09  8:41     ` Marc Kleine-Budde
2013-12-09  9:12     ` Peter Chen
2013-12-09  9:12       ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 13/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 14/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  9:05   ` Marc Kleine-Budde
2013-12-09  9:05     ` Marc Kleine-Budde
2013-12-09  9:19     ` Peter Chen
2013-12-09  9:19       ` Peter Chen
2013-12-09 10:00       ` Marc Kleine-Budde
2013-12-09 10:00         ` Marc Kleine-Budde
2013-12-09 18:20   ` Sergei Shtylyov
2013-12-09 18:20     ` Sergei Shtylyov
     [not found]     ` <52A609D8.1050300-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-12-10  1:47       ` Peter Chen
2013-12-10  1:47         ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386570664-6713-4-git-send-email-peter.chen@freescale.com \
    --to=peter.chen-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.