All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Peter Chen <peter.chen@freescale.com>
Cc: balbi@ti.com, shawn.guo@linaro.org, rob.herring@calxeda.com,
	grant.likely@linaro.org, alexander.shishkin@linux.intel.com,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	festevam@gmail.com, marex@denx.de, kernel@pengutronix.de,
	m.grzeschik@pengutronix.de, frank.li@freescale.com,
	gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd
Date: Mon, 09 Dec 2013 11:00:39 +0100	[thread overview]
Message-ID: <52A594C7.2000007@pengutronix.de> (raw)
In-Reply-To: <20131209091951.GD5291@shlinux1.ap.freescale.net>

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On 12/09/2013 10:19 AM, Peter Chen wrote:
> On Mon, Dec 09, 2013 at 10:05:17AM +0100, Marc Kleine-Budde wrote:
>> On 12/09/2013 07:31 AM, Peter Chen wrote:
>>> After clear portsc.phcd, PHY needs 200us stable time for switch
>>> 32K clock to AHB clock.
>>
>> If this is a general bugbix, please move it to the start of this series
>> and add stable on Cc. I think I hit the bug on the second USB port of a
>> custom MX28 board, the stmp_reset_block() in the USB phy will fail.
> 
> Not a bug-fix, just the requirement for the PHY leaves low power mode.
> Does the bug exists with my this patchset, or just current mainline code?

I see, I found this strange thing on v3.8, but can try on v3.13-rc3.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd
Date: Mon, 09 Dec 2013 11:00:39 +0100	[thread overview]
Message-ID: <52A594C7.2000007@pengutronix.de> (raw)
In-Reply-To: <20131209091951.GD5291@shlinux1.ap.freescale.net>

On 12/09/2013 10:19 AM, Peter Chen wrote:
> On Mon, Dec 09, 2013 at 10:05:17AM +0100, Marc Kleine-Budde wrote:
>> On 12/09/2013 07:31 AM, Peter Chen wrote:
>>> After clear portsc.phcd, PHY needs 200us stable time for switch
>>> 32K clock to AHB clock.
>>
>> If this is a general bugbix, please move it to the start of this series
>> and add stable on Cc. I think I hit the bug on the second USB port of a
>> custom MX28 board, the stmp_reset_block() in the USB phy will fail.
> 
> Not a bug-fix, just the requirement for the PHY leaves low power mode.
> Does the bug exists with my this patchset, or just current mainline code?

I see, I found this strange thing on v3.8, but can try on v3.13-rc3.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/9b6bb951/attachment.sig>

  reply	other threads:[~2013-12-09 10:00 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  6:30 [PATCH v5 00/15] Add power management support for mxs phy Peter Chen
2013-12-09  6:30 ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-09  6:30   ` Peter Chen
     [not found] ` <1386570664-6713-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-09  6:30   ` [PATCH v5 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-09  6:30     ` Peter Chen
2013-12-09  6:30   ` [PATCH v5 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-09  6:30     ` Peter Chen
2013-12-09  6:30   ` [PATCH v5 05/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-12-09  6:30     ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 06/15] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 07/15] usb: phy: add notify suspend and resume callback Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  8:31   ` Marc Kleine-Budde
2013-12-09  8:31     ` Marc Kleine-Budde
2013-12-09  9:00     ` Peter Chen
2013-12-09  9:00       ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 09/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  8:38   ` Marc Kleine-Budde
2013-12-09  8:38     ` Marc Kleine-Budde
2013-12-09  9:07     ` Peter Chen
2013-12-09  9:07       ` Peter Chen
2013-12-09  9:52       ` Marc Kleine-Budde
2013-12-09  9:52         ` Marc Kleine-Budde
2013-12-10  1:45         ` Peter Chen
2013-12-10  1:45           ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 10/15] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-09  6:30   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 11/15] usb: phy-mxs: add " Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 12/15] usb: phy: Add set_wakeup API Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  8:41   ` Marc Kleine-Budde
2013-12-09  8:41     ` Marc Kleine-Budde
2013-12-09  9:12     ` Peter Chen
2013-12-09  9:12       ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 13/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 14/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  6:31 ` [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2013-12-09  6:31   ` Peter Chen
2013-12-09  9:05   ` Marc Kleine-Budde
2013-12-09  9:05     ` Marc Kleine-Budde
2013-12-09  9:19     ` Peter Chen
2013-12-09  9:19       ` Peter Chen
2013-12-09 10:00       ` Marc Kleine-Budde [this message]
2013-12-09 10:00         ` Marc Kleine-Budde
2013-12-09 18:20   ` Sergei Shtylyov
2013-12-09 18:20     ` Sergei Shtylyov
     [not found]     ` <52A609D8.1050300-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-12-10  1:47       ` Peter Chen
2013-12-10  1:47         ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A594C7.2000007@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@freescale.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=marex@denx.de \
    --cc=peter.chen@freescale.com \
    --cc=rob.herring@calxeda.com \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.