All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: hkchu@google.com, edumazet@google.com,
	herbert@gondor.apana.org.au, ogerlitz@mellanox.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack
Date: Sat, 04 Jan 2014 17:33:08 -0800	[thread overview]
Message-ID: <1388885588.12212.158.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20140104.200931.524755895829922293.davem@davemloft.net>

On Sat, 2014-01-04 at 20:09 -0500, David Miller wrote:
> From: "H.K. Jerry Chu" <hkchu@google.com>
> Date: Fri,  3 Jan 2014 21:24:07 -0800
> 
> > +struct packet_offload *gro_find_receive_by_type(__be16 type);
> > +struct packet_offload *gro_find_complete_by_type(__be16 type);
> 
> You're not exporting these to modules, therefore if GRE is built
> modular it won't work.


Ah, I see now net/ipv4/gre_offload.c is not statically included.

This is unfortunate, as GRO/GSO should be fully enabled on routers, even
if no GRE tunnel is setup on the host.

Whole point of moving this stuff in separate gre_offload.c (commit
c50cd357887ac "net: gre: move GSO functions to gre_offload") was offer
offload capabilities without having to load GRE module.

diff --git a/net/ipv4/Makefile b/net/ipv4/Makefile
index 4b81e91c80fe..f8c49ce5b283 100644
--- a/net/ipv4/Makefile
+++ b/net/ipv4/Makefile
@@ -11,7 +11,7 @@ obj-y     := route.o inetpeer.o protocol.o \
 	     tcp_offload.o datagram.o raw.o udp.o udplite.o \
 	     udp_offload.o arp.o icmp.o devinet.o af_inet.o igmp.o \
 	     fib_frontend.o fib_semantics.o fib_trie.o \
-	     inet_fragment.o ping.o ip_tunnel_core.o
+	     inet_fragment.o ping.o ip_tunnel_core.o gre_offload.o
 
 obj-$(CONFIG_NET_IP_TUNNEL) += ip_tunnel.o
 obj-$(CONFIG_SYSCTL) += sysctl_net_ipv4.o
@@ -19,7 +19,7 @@ obj-$(CONFIG_PROC_FS) += proc.o
 obj-$(CONFIG_IP_MULTIPLE_TABLES) += fib_rules.o
 obj-$(CONFIG_IP_MROUTE) += ipmr.o
 obj-$(CONFIG_NET_IPIP) += ipip.o
-gre-y := gre_demux.o gre_offload.o
+gre-y := gre_demux.o
 obj-$(CONFIG_NET_IPGRE_DEMUX) += gre.o
 obj-$(CONFIG_NET_IPGRE) += ip_gre.o
 obj-$(CONFIG_NET_IPVTI) += ip_vti.o

  reply	other threads:[~2014-01-05  1:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04  5:24 [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack H.K. Jerry Chu
2014-01-05  1:09 ` David Miller
2014-01-05  1:33   ` Eric Dumazet [this message]
2014-01-05  4:00   ` Jerry Chu
  -- strict thread matches above, loose matches on Subject: below --
2014-01-07 18:23 H.K. Jerry Chu
2014-01-07 21:22 ` David Miller
2014-01-07 22:55   ` Jerry Chu
2014-01-07 23:14     ` David Miller
2014-01-05  4:37 H.K. Jerry Chu
2014-01-06 20:43 ` David Miller
2014-01-06 21:18   ` David Miller
2014-01-06 21:40     ` Eric Dumazet
2014-01-07 16:42       ` Jerry Chu
2014-01-03 13:46 H.K. Jerry Chu
2014-01-04  1:51 ` David Miller
2014-01-04  5:20   ` Jerry Chu
2014-01-04 21:52     ` Stephen Hemminger
2014-01-04  4:00 ` Eric Dumazet
2013-12-30 17:14 H.K. Jerry Chu
2014-01-03  0:30 ` David Miller
2014-01-03 13:32   ` Jerry Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388885588.12212.158.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=hkchu@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.