All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Chu <hkchu@google.com>
To: David Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack
Date: Sat, 4 Jan 2014 13:20:28 +0800	[thread overview]
Message-ID: <CAPshTCgnwX4g1CSgrEK+OwRPjfE5+z2g4YPbHfqhjVND=2xZKQ@mail.gmail.com> (raw)
In-Reply-To: <20140103.205131.1429670011198294911.davem@davemloft.net>

On Sat, Jan 4, 2014 at 9:51 AM, David Miller <davem@davemloft.net> wrote:
> From: "H.K. Jerry Chu" <hkchu@google.com>
> Date: Fri,  3 Jan 2014 05:46:53 -0800
>
>> +     if (skb->ip_summed == CHECKSUM_COMPLETE)
>> +             NAPI_GRO_CB(skb)->csum = csum_sub(NAPI_GRO_CB(skb)->csum,
>> +                     csum_partial(start, len, 0));
>
> The csum_partial() call as argument needs to line up to exactly the
> first column after the openning parenthesis of the csum_sub()
> invocation.
>
> You must use the appropriate number of TAB then SPACE characters
> necessary to achieve this.
>
> If you indent only using TABS then likely you are doing it wrong :)

Yes I know but sometimes trying to line up arguments either causes > 80
column long line, or many shorter but highly indented fragmented lines
following.

I've fixed the above case and it worked (stopped at 79th column).

Jerry

  reply	other threads:[~2014-01-04  5:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03 13:46 [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack H.K. Jerry Chu
2014-01-04  1:51 ` David Miller
2014-01-04  5:20   ` Jerry Chu [this message]
2014-01-04 21:52     ` Stephen Hemminger
2014-01-04  4:00 ` Eric Dumazet
  -- strict thread matches above, loose matches on Subject: below --
2014-01-07 18:23 H.K. Jerry Chu
2014-01-07 21:22 ` David Miller
2014-01-07 22:55   ` Jerry Chu
2014-01-07 23:14     ` David Miller
2014-01-05  4:37 H.K. Jerry Chu
2014-01-06 20:43 ` David Miller
2014-01-06 21:18   ` David Miller
2014-01-06 21:40     ` Eric Dumazet
2014-01-07 16:42       ` Jerry Chu
2014-01-04  5:24 H.K. Jerry Chu
2014-01-05  1:09 ` David Miller
2014-01-05  1:33   ` Eric Dumazet
2014-01-05  4:00   ` Jerry Chu
2013-12-30 17:14 H.K. Jerry Chu
2014-01-03  0:30 ` David Miller
2014-01-03 13:32   ` Jerry Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPshTCgnwX4g1CSgrEK+OwRPjfE5+z2g4YPbHfqhjVND=2xZKQ@mail.gmail.com' \
    --to=hkchu@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.