From: Jerry Chu <hkchu@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Or Gerlitz <ogerlitz@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack
Date: Tue, 7 Jan 2014 08:42:22 -0800 [thread overview]
Message-ID: <CAPshTCgO3w8t4AY-6nb=8SGj5GfqMwbyeQe27RezzO1fKGR3TQ@mail.gmail.com> (raw)
In-Reply-To: <1389044441.26646.1.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Jan 7, 2014 at 5:40 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Mon, 2014-01-06 at 16:18 -0500, David Miller wrote:
>> From: David Miller <davem@davemloft.net>
>> Date: Mon, 06 Jan 2014 15:43:30 -0500 (EST)
>>
>> > That the gre offload bits won't be registered unless GRE is enabled and
>> > initialized/loaded, right?
>>
>> In fact, it's utterly and completely bogus to make only this change.
>> It breaks the build, I'm reverting:
>>
>> ERROR: "gre_offload_exit" [net/ipv4/gre.ko] undefined!
>> ERROR: "gre_offload_init" [net/ipv4/gre.ko] undefined!
>> --
>
> Jerry, I'll send the patch to do this preparatory work in a small
> and tested unit in the following hour.
Thanks and sorry for breaking the build :(. I knew it was a bad idea
to make a last minute change, especially on something I don't fully
understand, and I did not remember/fully understand all the details/
implication of the two lines in net/ipv4/Makefile:
gre-y := gre_demux.o gre_offload.o
obj-$(CONFIG_NET_IPGRE_DEMUX) += gre.o
Will resubmit the GRE-GRO patch shortly.
Best,
Jerry
>
> Thanks.
>
>
next prev parent reply other threads:[~2014-01-07 16:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 4:37 [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack H.K. Jerry Chu
2014-01-06 20:43 ` David Miller
2014-01-06 21:18 ` David Miller
2014-01-06 21:40 ` Eric Dumazet
2014-01-07 16:42 ` Jerry Chu [this message]
2014-01-06 22:03 ` [PATCH net-next] gre_offload: statically build GRE offloading support Eric Dumazet
2014-01-06 22:34 ` Eric Dumazet
2014-01-07 1:28 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-01-07 18:23 [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack H.K. Jerry Chu
2014-01-07 21:22 ` David Miller
2014-01-07 22:55 ` Jerry Chu
2014-01-07 23:14 ` David Miller
2014-01-04 5:24 H.K. Jerry Chu
2014-01-05 1:09 ` David Miller
2014-01-05 1:33 ` Eric Dumazet
2014-01-05 4:00 ` Jerry Chu
2014-01-03 13:46 H.K. Jerry Chu
2014-01-04 1:51 ` David Miller
2014-01-04 5:20 ` Jerry Chu
2014-01-04 21:52 ` Stephen Hemminger
2014-01-04 4:00 ` Eric Dumazet
2013-12-30 17:14 H.K. Jerry Chu
2014-01-03 0:30 ` David Miller
2014-01-03 13:32 ` Jerry Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPshTCgO3w8t4AY-6nb=8SGj5GfqMwbyeQe27RezzO1fKGR3TQ@mail.gmail.com' \
--to=hkchu@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.