From: Joe Perches <joe@perches.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
patches@linaro.org, Roy Franz <roy.franz@linaro.org>
Subject: Re: [PATCH 05/22] Add shared printk wrapper for consistent prefixing
Date: Wed, 05 Feb 2014 09:34:13 -0800 [thread overview]
Message-ID: <1391621653.30094.11.camel@joe-AO722> (raw)
In-Reply-To: <1391619853-10601-6-git-send-email-leif.lindholm@linaro.org>
On Wed, 2014-02-05 at 17:03 +0000, Leif Lindholm wrote:
> From: Roy Franz <roy.franz@linaro.org>
>
> Add a wrapper for printk to standardize the prefix for informational and
> error messages from the EFI stub.
trivia:
> diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c
[]
> @@ -45,6 +45,9 @@ static void efi_printk(efi_system_table_t *sys_table_arg, char *str)
> }
> }
>
> +#define pr_efi(sys_table, msg) efi_printk(sys_table, "EFI stub: "msg)
> +#define pr_efi_err(sys_table, msg) efi_printk(sys_table, "EFI stub: ERROR: "msg)
Perhaps it'd be better to use a space after the second "
Also, maybe pr_efi should be pr_efi_info.
That would quiet any checkpatch noise around long msg uses.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Roy Franz <roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 05/22] Add shared printk wrapper for consistent prefixing
Date: Wed, 05 Feb 2014 09:34:13 -0800 [thread overview]
Message-ID: <1391621653.30094.11.camel@joe-AO722> (raw)
In-Reply-To: <1391619853-10601-6-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Wed, 2014-02-05 at 17:03 +0000, Leif Lindholm wrote:
> From: Roy Franz <roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Add a wrapper for printk to standardize the prefix for informational and
> error messages from the EFI stub.
trivia:
> diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c
[]
> @@ -45,6 +45,9 @@ static void efi_printk(efi_system_table_t *sys_table_arg, char *str)
> }
> }
>
> +#define pr_efi(sys_table, msg) efi_printk(sys_table, "EFI stub: "msg)
> +#define pr_efi_err(sys_table, msg) efi_printk(sys_table, "EFI stub: ERROR: "msg)
Perhaps it'd be better to use a space after the second "
Also, maybe pr_efi should be pr_efi_info.
That would quiet any checkpatch noise around long msg uses.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/22] Add shared printk wrapper for consistent prefixing
Date: Wed, 05 Feb 2014 09:34:13 -0800 [thread overview]
Message-ID: <1391621653.30094.11.camel@joe-AO722> (raw)
In-Reply-To: <1391619853-10601-6-git-send-email-leif.lindholm@linaro.org>
On Wed, 2014-02-05 at 17:03 +0000, Leif Lindholm wrote:
> From: Roy Franz <roy.franz@linaro.org>
>
> Add a wrapper for printk to standardize the prefix for informational and
> error messages from the EFI stub.
trivia:
> diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c
[]
> @@ -45,6 +45,9 @@ static void efi_printk(efi_system_table_t *sys_table_arg, char *str)
> }
> }
>
> +#define pr_efi(sys_table, msg) efi_printk(sys_table, "EFI stub: "msg)
> +#define pr_efi_err(sys_table, msg) efi_printk(sys_table, "EFI stub: ERROR: "msg)
Perhaps it'd be better to use a space after the second "
Also, maybe pr_efi should be pr_efi_info.
That would quiet any checkpatch noise around long msg uses.
next prev parent reply other threads:[~2014-02-05 17:34 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 17:03 [PATCH 00/22] arm/arm64: UEFI stubs + runtime services Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 01/22] arm: break part of __soft_restart out into separate function Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 02/22] arm: add new asm macro update_sctlr Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 18:01 ` Will Deacon
2014-02-05 18:01 ` Will Deacon
2014-02-05 18:01 ` Will Deacon
2014-02-05 17:03 ` [PATCH 03/22] efi: add helper function to get UEFI params from FDT Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-13 11:17 ` Matt Fleming
2014-02-13 11:17 ` Matt Fleming
2014-02-13 11:17 ` Matt Fleming
2014-02-13 14:56 ` Mark Salter
2014-02-13 14:56 ` Mark Salter
2014-02-13 14:56 ` Mark Salter
2014-02-05 17:03 ` [PATCH 04/22] efi-stub.txt updates for ARM Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 05/22] Add shared printk wrapper for consistent prefixing Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:34 ` Joe Perches [this message]
2014-02-05 17:34 ` Joe Perches
2014-02-05 17:34 ` Joe Perches
2014-02-05 17:03 ` [PATCH 06/22] Add helper functions used by arm/arm64 Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-13 11:26 ` Matt Fleming
2014-02-13 11:26 ` Matt Fleming
2014-02-13 11:26 ` Matt Fleming
2014-02-14 19:02 ` Roy Franz
2014-02-14 19:02 ` Roy Franz
2014-02-14 19:02 ` Roy Franz
2014-03-03 14:08 ` Matt Fleming
2014-03-03 14:08 ` Matt Fleming
2014-03-03 14:08 ` Matt Fleming
2014-03-04 7:48 ` Roy Franz
2014-03-04 7:48 ` Roy Franz
2014-03-04 7:48 ` Roy Franz
2014-02-05 17:03 ` [PATCH 07/22] Add shared FDT related functions for ARM/ARM64 Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 08/22] Add strstr to compressed string.c for ARM Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 09/22] Add shared arm/arm64 EFI stub Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 10/22] Add EFI stub for ARM Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 11/22] Disable stack protection for decompressor/stub Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 12/22] Documentation: arm: add UEFI support documentation Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 13/22] arm: Add [U]EFI runtime services support Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 14/22] init: efi: arm: enable (U)EFI runtime services on arm Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 15/22] lib: add fdt_empty_tree.c Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 16/22] arm64: Add function to create identity mappings Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-14 17:42 ` Catalin Marinas
2014-02-14 17:42 ` Catalin Marinas
2014-02-17 13:29 ` Mark Salter
2014-02-17 13:29 ` Mark Salter
2014-02-17 13:29 ` Mark Salter
2014-02-05 17:04 ` [PATCH 17/22] arm64: add EFI stub Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 18/22] doc: arm64: add description of EFI stub support Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 19/22] arm64: add EFI runtime services Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 20/22] Improve cmdline conversion Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 21/22] arm: efistub: ignore dtb= when UEFI SecureBoot is enabled Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 18:09 ` Ard Biesheuvel
2014-02-05 18:09 ` Ard Biesheuvel
2014-02-05 18:09 ` Ard Biesheuvel
2014-02-05 17:04 ` [PATCH 22/22] arm: update boot/compressed/.gitignore Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391621653.30094.11.camel@joe-AO722 \
--to=joe@perches.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.