From: Catalin Marinas <catalin.marinas@arm.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
patches@linaro.org, Mark Salter <msalter@redhat.com>
Subject: Re: [PATCH 16/22] arm64: Add function to create identity mappings
Date: Fri, 14 Feb 2014 17:42:56 +0000 [thread overview]
Message-ID: <20140214174256.GC12304@arm.com> (raw)
In-Reply-To: <1391619853-10601-17-git-send-email-leif.lindholm@linaro.org>
On Wed, Feb 05, 2014 at 05:04:07PM +0000, Leif Lindholm wrote:
> +void __init create_id_mapping(phys_addr_t addr, phys_addr_t size, int map_io)
> +{
> + pgd_t *pgd = &idmap_pg_dir[pgd_index(addr)];
> +
> + if (pgd >= &idmap_pg_dir[ARRAY_SIZE(idmap_pg_dir)]) {
> + pr_warn("BUG: not creating id mapping for 0x%016llx\n", addr);
> + return;
> + }
> + __create_mapping(pgd, addr, addr, size, map_io);
> +}
I'm a bit worried because I gave some feedback in the past but it didn't
make to this patch.
What I said on 22nd of January:
The condition above is always false since pgd_index() already ands the
index with (PTRS_PER_PGD - 1). Better check addr against something like
(PTRS_PER_PGD * PGDIR_SIZE) (for clarity, you could do other shifts,
doesn't really matter).
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/22] arm64: Add function to create identity mappings
Date: Fri, 14 Feb 2014 17:42:56 +0000 [thread overview]
Message-ID: <20140214174256.GC12304@arm.com> (raw)
In-Reply-To: <1391619853-10601-17-git-send-email-leif.lindholm@linaro.org>
On Wed, Feb 05, 2014 at 05:04:07PM +0000, Leif Lindholm wrote:
> +void __init create_id_mapping(phys_addr_t addr, phys_addr_t size, int map_io)
> +{
> + pgd_t *pgd = &idmap_pg_dir[pgd_index(addr)];
> +
> + if (pgd >= &idmap_pg_dir[ARRAY_SIZE(idmap_pg_dir)]) {
> + pr_warn("BUG: not creating id mapping for 0x%016llx\n", addr);
> + return;
> + }
> + __create_mapping(pgd, addr, addr, size, map_io);
> +}
I'm a bit worried because I gave some feedback in the past but it didn't
make to this patch.
What I said on 22nd of January:
The condition above is always false since pgd_index() already ands the
index with (PTRS_PER_PGD - 1). Better check addr against something like
(PTRS_PER_PGD * PGDIR_SIZE) (for clarity, you could do other shifts,
doesn't really matter).
--
Catalin
next prev parent reply other threads:[~2014-02-14 17:43 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 17:03 [PATCH 00/22] arm/arm64: UEFI stubs + runtime services Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 01/22] arm: break part of __soft_restart out into separate function Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 02/22] arm: add new asm macro update_sctlr Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 18:01 ` Will Deacon
2014-02-05 18:01 ` Will Deacon
2014-02-05 18:01 ` Will Deacon
2014-02-05 17:03 ` [PATCH 03/22] efi: add helper function to get UEFI params from FDT Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-13 11:17 ` Matt Fleming
2014-02-13 11:17 ` Matt Fleming
2014-02-13 11:17 ` Matt Fleming
2014-02-13 14:56 ` Mark Salter
2014-02-13 14:56 ` Mark Salter
2014-02-13 14:56 ` Mark Salter
2014-02-05 17:03 ` [PATCH 04/22] efi-stub.txt updates for ARM Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 05/22] Add shared printk wrapper for consistent prefixing Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:34 ` Joe Perches
2014-02-05 17:34 ` Joe Perches
2014-02-05 17:34 ` Joe Perches
2014-02-05 17:03 ` [PATCH 06/22] Add helper functions used by arm/arm64 Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-13 11:26 ` Matt Fleming
2014-02-13 11:26 ` Matt Fleming
2014-02-13 11:26 ` Matt Fleming
2014-02-14 19:02 ` Roy Franz
2014-02-14 19:02 ` Roy Franz
2014-02-14 19:02 ` Roy Franz
2014-03-03 14:08 ` Matt Fleming
2014-03-03 14:08 ` Matt Fleming
2014-03-03 14:08 ` Matt Fleming
2014-03-04 7:48 ` Roy Franz
2014-03-04 7:48 ` Roy Franz
2014-03-04 7:48 ` Roy Franz
2014-02-05 17:03 ` [PATCH 07/22] Add shared FDT related functions for ARM/ARM64 Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` [PATCH 08/22] Add strstr to compressed string.c for ARM Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:03 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 09/22] Add shared arm/arm64 EFI stub Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 10/22] Add EFI stub for ARM Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 11/22] Disable stack protection for decompressor/stub Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 12/22] Documentation: arm: add UEFI support documentation Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 13/22] arm: Add [U]EFI runtime services support Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 14/22] init: efi: arm: enable (U)EFI runtime services on arm Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 15/22] lib: add fdt_empty_tree.c Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 16/22] arm64: Add function to create identity mappings Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-14 17:42 ` Catalin Marinas [this message]
2014-02-14 17:42 ` Catalin Marinas
2014-02-17 13:29 ` Mark Salter
2014-02-17 13:29 ` Mark Salter
2014-02-17 13:29 ` Mark Salter
2014-02-05 17:04 ` [PATCH 17/22] arm64: add EFI stub Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 18/22] doc: arm64: add description of EFI stub support Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 19/22] arm64: add EFI runtime services Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 20/22] Improve cmdline conversion Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 17:04 ` [PATCH 21/22] arm: efistub: ignore dtb= when UEFI SecureBoot is enabled Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
2014-02-05 18:09 ` Ard Biesheuvel
2014-02-05 18:09 ` Ard Biesheuvel
2014-02-05 18:09 ` Ard Biesheuvel
2014-02-05 17:04 ` [PATCH 22/22] arm: update boot/compressed/.gitignore Leif Lindholm
2014-02-05 17:04 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214174256.GC12304@arm.com \
--to=catalin.marinas@arm.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.