All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Courbot <acourbot@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Tomasz Figa <t.figa@samsung.com>
Cc: gnurou@gmail.com, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	Alexandre Courbot <acourbot@nvidia.com>,
	Olof Johansson <olof@lixom.net>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing
Date: Fri, 7 Feb 2014 13:35:02 +0900	[thread overview]
Message-ID: <1391747706-1847-3-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1391747706-1847-1-git-send-email-acourbot@nvidia.com>

When Trusted Foundations is detected as present on the system, but
Trusted Foundations support is not built into the kernel, the kernel
used to issue a panic very early during boot, leaving little clue to the
user as to what is going wrong.

It turns out that even without TF support built-in, the kernel can boot
on a TF-enabled system provided that SMP and cpuidle are disabled. This
patch does this and continue booting on one CPU, leaving the user with a
usable (however degraded) system.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 arch/arm/include/asm/trusted_foundations.h | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/arm/include/asm/trusted_foundations.h b/arch/arm/include/asm/trusted_foundations.h
index 997862fd5d77..b5f7705abcb0 100644
--- a/arch/arm/include/asm/trusted_foundations.h
+++ b/arch/arm/include/asm/trusted_foundations.h
@@ -30,6 +30,8 @@
 #include <linux/printk.h>
 #include <linux/bug.h>
 #include <linux/of.h>
+#include <linux/cpu.h>
+#include <linux/smp.h>
 
 struct trusted_foundations_platform_data {
 	unsigned int version_major;
@@ -47,10 +49,13 @@ static inline void register_trusted_foundations(
 				   struct trusted_foundations_platform_data *pd)
 {
 	/*
-	 * If we try to register TF, this means the system needs it to continue.
-	 * Its absence if thus a fatal error.
+	 * If the system requires TF and we cannot provide it, continue booting
+	 * but disable features that cannot be provided.
 	 */
-	panic("No support for Trusted Foundations, stopping...\n");
+	pr_err("No support for Trusted Foundations, continuing in degraded mode.\n");
+	pr_err("Secondary processors as well as CPU PM will be disabled.\n");
+	setup_max_cpus = 0;
+	cpu_idle_poll_ctrl(true);
 }
 
 static inline void of_register_trusted_foundations(void)
-- 
1.8.5.3

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Tomasz Figa <t.figa@samsung.com>
Cc: Olof Johansson <olof@lixom.net>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<gnurou@gmail.com>, Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing
Date: Fri, 7 Feb 2014 13:35:02 +0900	[thread overview]
Message-ID: <1391747706-1847-3-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1391747706-1847-1-git-send-email-acourbot@nvidia.com>

When Trusted Foundations is detected as present on the system, but
Trusted Foundations support is not built into the kernel, the kernel
used to issue a panic very early during boot, leaving little clue to the
user as to what is going wrong.

It turns out that even without TF support built-in, the kernel can boot
on a TF-enabled system provided that SMP and cpuidle are disabled. This
patch does this and continue booting on one CPU, leaving the user with a
usable (however degraded) system.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 arch/arm/include/asm/trusted_foundations.h | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/arm/include/asm/trusted_foundations.h b/arch/arm/include/asm/trusted_foundations.h
index 997862fd5d77..b5f7705abcb0 100644
--- a/arch/arm/include/asm/trusted_foundations.h
+++ b/arch/arm/include/asm/trusted_foundations.h
@@ -30,6 +30,8 @@
 #include <linux/printk.h>
 #include <linux/bug.h>
 #include <linux/of.h>
+#include <linux/cpu.h>
+#include <linux/smp.h>
 
 struct trusted_foundations_platform_data {
 	unsigned int version_major;
@@ -47,10 +49,13 @@ static inline void register_trusted_foundations(
 				   struct trusted_foundations_platform_data *pd)
 {
 	/*
-	 * If we try to register TF, this means the system needs it to continue.
-	 * Its absence if thus a fatal error.
+	 * If the system requires TF and we cannot provide it, continue booting
+	 * but disable features that cannot be provided.
 	 */
-	panic("No support for Trusted Foundations, stopping...\n");
+	pr_err("No support for Trusted Foundations, continuing in degraded mode.\n");
+	pr_err("Secondary processors as well as CPU PM will be disabled.\n");
+	setup_max_cpus = 0;
+	cpu_idle_poll_ctrl(true);
 }
 
 static inline void of_register_trusted_foundations(void)
-- 
1.8.5.3


WARNING: multiple messages have this Message-ID (diff)
From: acourbot@nvidia.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing
Date: Fri, 7 Feb 2014 13:35:02 +0900	[thread overview]
Message-ID: <1391747706-1847-3-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1391747706-1847-1-git-send-email-acourbot@nvidia.com>

When Trusted Foundations is detected as present on the system, but
Trusted Foundations support is not built into the kernel, the kernel
used to issue a panic very early during boot, leaving little clue to the
user as to what is going wrong.

It turns out that even without TF support built-in, the kernel can boot
on a TF-enabled system provided that SMP and cpuidle are disabled. This
patch does this and continue booting on one CPU, leaving the user with a
usable (however degraded) system.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 arch/arm/include/asm/trusted_foundations.h | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/arm/include/asm/trusted_foundations.h b/arch/arm/include/asm/trusted_foundations.h
index 997862fd5d77..b5f7705abcb0 100644
--- a/arch/arm/include/asm/trusted_foundations.h
+++ b/arch/arm/include/asm/trusted_foundations.h
@@ -30,6 +30,8 @@
 #include <linux/printk.h>
 #include <linux/bug.h>
 #include <linux/of.h>
+#include <linux/cpu.h>
+#include <linux/smp.h>
 
 struct trusted_foundations_platform_data {
 	unsigned int version_major;
@@ -47,10 +49,13 @@ static inline void register_trusted_foundations(
 				   struct trusted_foundations_platform_data *pd)
 {
 	/*
-	 * If we try to register TF, this means the system needs it to continue.
-	 * Its absence if thus a fatal error.
+	 * If the system requires TF and we cannot provide it, continue booting
+	 * but disable features that cannot be provided.
 	 */
-	panic("No support for Trusted Foundations, stopping...\n");
+	pr_err("No support for Trusted Foundations, continuing in degraded mode.\n");
+	pr_err("Secondary processors as well as CPU PM will be disabled.\n");
+	setup_max_cpus = 0;
+	cpu_idle_poll_ctrl(true);
 }
 
 static inline void of_register_trusted_foundations(void)
-- 
1.8.5.3

  parent reply	other threads:[~2014-02-07  4:35 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07  4:35 [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Alexandre Courbot
2014-02-07  4:35 ` Alexandre Courbot
2014-02-07  4:35 ` Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 1/6] ARM: trusted_foundations: fix vendor prefix typos Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35 ` Alexandre Courbot [this message]
2014-02-07  4:35   ` [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 3/6] ARM: firmware: enable Trusted Foundations by default Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
     [not found]   ` <1391747706-1847-5-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-13 11:01     ` Tomasz Figa
2014-02-13 11:01       ` Tomasz Figa
2014-02-13 11:01       ` Tomasz Figa
     [not found]       ` <52FCA5FC.80504-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-02-13 16:37         ` Stephen Warren
2014-02-13 16:37           ` Stephen Warren
2014-02-13 16:37           ` Stephen Warren
2014-02-14  5:16         ` Alexandre Courbot
2014-02-14  5:16           ` Alexandre Courbot
2014-02-14  5:16           ` Alexandre Courbot
     [not found]           ` <52FDA6B4.6070404-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-14 10:42             ` Tomasz Figa
2014-02-14 10:42               ` Tomasz Figa
2014-02-14 10:42               ` Tomasz Figa
2014-02-07  4:35 ` [PATCH v2 5/6] ARM: trusted_foundations: implement prepare_idle() Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
     [not found] ` <1391747706-1847-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-07  4:35   ` [PATCH v2 6/6] ARM: tegra: cpuidle: use firmware for power down Alexandre Courbot
2014-02-07  4:35     ` Alexandre Courbot
2014-02-07  4:35     ` Alexandre Courbot
2014-02-12  1:36     ` Olof Johansson
2014-02-12  1:36       ` Olof Johansson
     [not found]       ` <20140212013650.GA7584-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2014-02-12  1:56         ` Alexandre Courbot
2014-02-12  1:56           ` Alexandre Courbot
2014-02-12  1:56           ` Alexandre Courbot
     [not found]           ` <52FAD4C2.80803-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-12  2:43             ` [PATCH v3] " Alexandre Courbot
2014-02-12  2:43               ` Alexandre Courbot
2014-02-12  2:43               ` Alexandre Courbot
2014-02-12 20:04               ` Olof Johansson
2014-02-12 20:04                 ` Olof Johansson
2014-02-12 20:04                 ` Olof Johansson
2014-02-18 20:56   ` [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Stephen Warren
2014-02-18 20:56     ` Stephen Warren
2014-02-18 20:56     ` Stephen Warren
2014-02-12  1:38 ` Olof Johansson
2014-02-12  1:38   ` Olof Johansson
     [not found]   ` <20140212013846.GB7584-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2014-02-12 20:07     ` Stephen Warren
2014-02-12 20:07       ` Stephen Warren
2014-02-12 20:07       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391747706-1847-3-git-send-email-acourbot@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=swarren@wwwdotorg.org \
    --cc=t.figa@samsung.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.