All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Alexandre Courbot
	<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation
Date: Thu, 13 Feb 2014 12:01:16 +0100	[thread overview]
Message-ID: <52FCA5FC.80504@samsung.com> (raw)
In-Reply-To: <1391747706-1847-5-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Hi Alexandre,

On 07.02.2014 05:35, Alexandre Courbot wrote:
> Some firmwares do not put the CPU into idle mode themselves, but still
> need to be informed that the CPU is about to enter idle mode before this
> happens. Add a prepare_idle() operation to the firmware_ops structure to
> handle such cases.
>
> Signed-off-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>   arch/arm/include/asm/firmware.h | 4 ++++
>   1 file changed, 4 insertions(+)

I wonder if .do_idle() couldn't simply return an appropriate error code 
to let the upper layer know that it should proceed with normal CPU idle 
activation, while still letting the firmware know that the CPU is going 
to idle.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <t.figa@samsung.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Russell King <linux@arm.linux.org.uk>
Cc: Olof Johansson <olof@lixom.net>,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	gnurou@gmail.com
Subject: Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation
Date: Thu, 13 Feb 2014 12:01:16 +0100	[thread overview]
Message-ID: <52FCA5FC.80504@samsung.com> (raw)
In-Reply-To: <1391747706-1847-5-git-send-email-acourbot@nvidia.com>

Hi Alexandre,

On 07.02.2014 05:35, Alexandre Courbot wrote:
> Some firmwares do not put the CPU into idle mode themselves, but still
> need to be informed that the CPU is about to enter idle mode before this
> happens. Add a prepare_idle() operation to the firmware_ops structure to
> handle such cases.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>   arch/arm/include/asm/firmware.h | 4 ++++
>   1 file changed, 4 insertions(+)

I wonder if .do_idle() couldn't simply return an appropriate error code 
to let the upper layer know that it should proceed with normal CPU idle 
activation, while still letting the firmware know that the CPU is going 
to idle.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation
Date: Thu, 13 Feb 2014 12:01:16 +0100	[thread overview]
Message-ID: <52FCA5FC.80504@samsung.com> (raw)
In-Reply-To: <1391747706-1847-5-git-send-email-acourbot@nvidia.com>

Hi Alexandre,

On 07.02.2014 05:35, Alexandre Courbot wrote:
> Some firmwares do not put the CPU into idle mode themselves, but still
> need to be informed that the CPU is about to enter idle mode before this
> happens. Add a prepare_idle() operation to the firmware_ops structure to
> handle such cases.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>   arch/arm/include/asm/firmware.h | 4 ++++
>   1 file changed, 4 insertions(+)

I wonder if .do_idle() couldn't simply return an appropriate error code 
to let the upper layer know that it should proceed with normal CPU idle 
activation, while still letting the firmware know that the CPU is going 
to idle.

Best regards,
Tomasz

  parent reply	other threads:[~2014-02-13 11:01 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07  4:35 [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Alexandre Courbot
2014-02-07  4:35 ` Alexandre Courbot
2014-02-07  4:35 ` Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 1/6] ARM: trusted_foundations: fix vendor prefix typos Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 3/6] ARM: firmware: enable Trusted Foundations by default Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
     [not found]   ` <1391747706-1847-5-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-13 11:01     ` Tomasz Figa [this message]
2014-02-13 11:01       ` Tomasz Figa
2014-02-13 11:01       ` Tomasz Figa
     [not found]       ` <52FCA5FC.80504-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-02-13 16:37         ` Stephen Warren
2014-02-13 16:37           ` Stephen Warren
2014-02-13 16:37           ` Stephen Warren
2014-02-14  5:16         ` Alexandre Courbot
2014-02-14  5:16           ` Alexandre Courbot
2014-02-14  5:16           ` Alexandre Courbot
     [not found]           ` <52FDA6B4.6070404-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-14 10:42             ` Tomasz Figa
2014-02-14 10:42               ` Tomasz Figa
2014-02-14 10:42               ` Tomasz Figa
2014-02-07  4:35 ` [PATCH v2 5/6] ARM: trusted_foundations: implement prepare_idle() Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
2014-02-07  4:35   ` Alexandre Courbot
     [not found] ` <1391747706-1847-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-07  4:35   ` [PATCH v2 6/6] ARM: tegra: cpuidle: use firmware for power down Alexandre Courbot
2014-02-07  4:35     ` Alexandre Courbot
2014-02-07  4:35     ` Alexandre Courbot
2014-02-12  1:36     ` Olof Johansson
2014-02-12  1:36       ` Olof Johansson
     [not found]       ` <20140212013650.GA7584-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2014-02-12  1:56         ` Alexandre Courbot
2014-02-12  1:56           ` Alexandre Courbot
2014-02-12  1:56           ` Alexandre Courbot
     [not found]           ` <52FAD4C2.80803-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-12  2:43             ` [PATCH v3] " Alexandre Courbot
2014-02-12  2:43               ` Alexandre Courbot
2014-02-12  2:43               ` Alexandre Courbot
2014-02-12 20:04               ` Olof Johansson
2014-02-12 20:04                 ` Olof Johansson
2014-02-12 20:04                 ` Olof Johansson
2014-02-18 20:56   ` [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Stephen Warren
2014-02-18 20:56     ` Stephen Warren
2014-02-18 20:56     ` Stephen Warren
2014-02-12  1:38 ` Olof Johansson
2014-02-12  1:38   ` Olof Johansson
     [not found]   ` <20140212013846.GB7584-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2014-02-12 20:07     ` Stephen Warren
2014-02-12 20:07       ` Stephen Warren
2014-02-12 20:07       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FCA5FC.80504@samsung.com \
    --to=t.figa-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.