From: Jean Delvare <jdelvare@suse.de> To: Laszlo Papp <lpapp@kde.org> Cc: Lee Jones <lee.jones@linaro.org>, LKML <linux-kernel@vger.kernel.org>, lm-sensors@lm-sensors.org, Guenter Roeck <linux@roeck-us.net> Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Date: Thu, 13 Feb 2014 12:07:32 +0100 [thread overview] Message-ID: <1392289652.29672.26.camel@chaos.site> (raw) In-Reply-To: <CAOMwXhOv-as1W69wcSno49jEXsXWZZ7odnu8og-vgnDwRTJ4sA@mail.gmail.com> Hi Laszlo, Le Thursday 13 February 2014 à 10:46 +0000, Laszlo Papp a écrit : > On Thu, Feb 13, 2014 at 10:38 AM, Laszlo Papp <lpapp@kde.org> wrote: > > On Thu, Feb 13, 2014 at 10:15 AM, Jean Delvare <jdelvare@suse.de> wrote: > >> Any change to the max6650 driver should go on top of his patch series > >> to avoid conflicts: > >> > >> http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041223.html > > > > As far as I can see, that patch set was not even tested, so how can it > > go in? I was told that any patch should be _runtime_ tested, too. > > Fwiw, I do not have time to test those personally, he would need to > > find someone else if that requirement really holds true. I find it _very_ funny that you dare to complain here, when you sent a totally untested patch no later than 2 days ago: http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041180.html There's no way that patch can work. And, actually, Guenter's patches have been reviewed and tested by myself, to some degree (I don't have access to a physical MAX6650 or MAX6651 chip so I used an emulation, which I think was good enough given the nature of the changes.) > > I would not really like to fix bugs appearing in that code to get my > > features in. I have no idea what you mean here. > Also, since my change has been around for 2-3 months now, I would > really prefer not to be forced to rewrite it again from scratch. I'm sure Gunter would have preferred if you could write proper patches so he wouldn't have to do it himself. Seriously, nobody here cares about your personal preferences. You said you want some significant changes done to the max6650 driver, it takes many steps to get there, either you take them, or you can leave right now. If you're not going to listen to (and subsequently obey) people who have been working on this project for years and are well-known and respected by the vast majority of their peers, then bye bye. > Surely, you can wait with those, more or less, cosmetic non-runtime > tested changes? I see you once again failed to read (or understand) something I repeated many times already. One of these changes (the one moving the hwmon attributes from i2c device to hwmon device) is _mandatory_ to get your own changes accepted. Guenter did you an immense favor by writing these patches, so if anything you should be very grateful to him. > This would impose me a lot of additional work again, and I personally > do not see the benefit of it. In my book at least, feature is over > internal polishing. Change books then, yours is just wrong. Bug fixes come first, then cleanups, then features. Adding features on top of ugly code is a pain for everyone. Plus cleaning up the code helps you to understand it, so I'd say this is time well invested. You should try, that would certainly help you avoid some mistakes you did in the past. I would like to add a more general comment on the way you behave with the community and that has been bothering me for days. You apparently act first and think second. I can no longer count the number of times you replied to a post only to reply to yourself a few minutes later. Last occurrence of this is in this thread: first reply from you at 11:38, and then an addition at 11:46, i.e. 8 minutes later. And you do that all the time. And it holds for patches too, for example. http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041179.html posted at 11:24, then http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041180.html v2 of the same posted at 11:28. So please listen to this piece of advice: take your time. Think more, and only act after you have thought thoroughly about everything. It will save you a lot of trouble, and the community a lot of time. Thanks, -- Jean Delvare Suse L3 Support
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de> To: Laszlo Papp <lpapp@kde.org> Cc: Lee Jones <lee.jones@linaro.org>, LKML <linux-kernel@vger.kernel.org>, lm-sensors@lm-sensors.org, Guenter Roeck <linux@roeck-us.net> Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Date: Thu, 13 Feb 2014 11:07:32 +0000 [thread overview] Message-ID: <1392289652.29672.26.camel@chaos.site> (raw) In-Reply-To: <CAOMwXhOv-as1W69wcSno49jEXsXWZZ7odnu8og-vgnDwRTJ4sA@mail.gmail.com> SGkgTGFzemxvLAoKTGUgVGh1cnNkYXkgMTMgRmVicnVhcnkgMjAxNCDDoCAxMDo0NiArMDAwMCwg TGFzemxvIFBhcHAgYSDDqWNyaXQgOgo+IE9uIFRodSwgRmViIDEzLCAyMDE0IGF0IDEwOjM4IEFN LCBMYXN6bG8gUGFwcCA8bHBhcHBAa2RlLm9yZz4gd3JvdGU6Cj4gPiBPbiBUaHUsIEZlYiAxMywg MjAxNCBhdCAxMDoxNSBBTSwgSmVhbiBEZWx2YXJlIDxqZGVsdmFyZUBzdXNlLmRlPiB3cm90ZToK PiA+PiBBbnkgY2hhbmdlIHRvIHRoZSBtYXg2NjUwIGRyaXZlciBzaG91bGQgZ28gb24gdG9wIG9m IGhpcyBwYXRjaCBzZXJpZXMKPiA+PiB0byBhdm9pZCBjb25mbGljdHM6Cj4gPj4KPiA+PiBodHRw Oi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvcGlwZXJtYWlsL2xtLXNlbnNvcnMvMjAxNC1GZWJydWFy eS8wNDEyMjMuaHRtbAo+ID4KPiA+IEFzIGZhciBhcyBJIGNhbiBzZWUsIHRoYXQgcGF0Y2ggc2V0 IHdhcyBub3QgZXZlbiB0ZXN0ZWQsIHNvIGhvdyBjYW4gaXQKPiA+IGdvIGluPyBJIHdhcyB0b2xk IHRoYXQgYW55IHBhdGNoIHNob3VsZCBiZSBfcnVudGltZV8gdGVzdGVkLCB0b28uCj4gPiBGd2l3 LCBJIGRvIG5vdCBoYXZlIHRpbWUgdG8gdGVzdCB0aG9zZSBwZXJzb25hbGx5LCBoZSB3b3VsZCBu ZWVkIHRvCj4gPiBmaW5kIHNvbWVvbmUgZWxzZSBpZiB0aGF0IHJlcXVpcmVtZW50IHJlYWxseSBo b2xkcyB0cnVlLgoKSSBmaW5kIGl0IF92ZXJ5XyBmdW5ueSB0aGF0IHlvdSBkYXJlIHRvIGNvbXBs YWluIGhlcmUsIHdoZW4geW91IHNlbnQgYQp0b3RhbGx5IHVudGVzdGVkIHBhdGNoIG5vIGxhdGVy IHRoYW4gMiBkYXlzIGFnbzoKCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9waXBlcm1haWwv bG0tc2Vuc29ycy8yMDE0LUZlYnJ1YXJ5LzA0MTE4MC5odG1sCgpUaGVyZSdzIG5vIHdheSB0aGF0 IHBhdGNoIGNhbiB3b3JrLgoKQW5kLCBhY3R1YWxseSwgR3VlbnRlcidzIHBhdGNoZXMgaGF2ZSBi ZWVuIHJldmlld2VkIGFuZCB0ZXN0ZWQgYnkKbXlzZWxmLCB0byBzb21lIGRlZ3JlZSAoSSBkb24n dCBoYXZlIGFjY2VzcyB0byBhIHBoeXNpY2FsIE1BWDY2NTAgb3IKTUFYNjY1MSBjaGlwIHNvIEkg dXNlZCBhbiBlbXVsYXRpb24sIHdoaWNoIEkgdGhpbmsgd2FzIGdvb2QgZW5vdWdoIGdpdmVuCnRo ZSBuYXR1cmUgb2YgdGhlIGNoYW5nZXMuKQoKPiA+IEkgd291bGQgbm90IHJlYWxseSBsaWtlIHRv IGZpeCBidWdzIGFwcGVhcmluZyBpbiB0aGF0IGNvZGUgdG8gZ2V0IG15Cj4gPiBmZWF0dXJlcyBp bi4KCkkgaGF2ZSBubyBpZGVhIHdoYXQgeW91IG1lYW4gaGVyZS4KCj4gQWxzbywgc2luY2UgbXkg Y2hhbmdlIGhhcyBiZWVuIGFyb3VuZCBmb3IgMi0zIG1vbnRocyBub3csIEkgd291bGQKPiByZWFs bHkgcHJlZmVyIG5vdCB0byBiZSBmb3JjZWQgdG8gcmV3cml0ZSBpdCBhZ2FpbiBmcm9tIHNjcmF0 Y2guCgpJJ20gc3VyZSBHdW50ZXIgd291bGQgaGF2ZSBwcmVmZXJyZWQgaWYgeW91IGNvdWxkIHdy aXRlIHByb3BlciBwYXRjaGVzCnNvIGhlIHdvdWxkbid0IGhhdmUgdG8gZG8gaXQgaGltc2VsZi4K ClNlcmlvdXNseSwgbm9ib2R5IGhlcmUgY2FyZXMgYWJvdXQgeW91ciBwZXJzb25hbCBwcmVmZXJl bmNlcy4gWW91IHNhaWQKeW91IHdhbnQgc29tZSBzaWduaWZpY2FudCBjaGFuZ2VzIGRvbmUgdG8g dGhlIG1heDY2NTAgZHJpdmVyLCBpdCB0YWtlcwptYW55IHN0ZXBzIHRvIGdldCB0aGVyZSwgZWl0 aGVyIHlvdSB0YWtlIHRoZW0sIG9yIHlvdSBjYW4gbGVhdmUgcmlnaHQKbm93LiBJZiB5b3UncmUg bm90IGdvaW5nIHRvIGxpc3RlbiB0byAoYW5kIHN1YnNlcXVlbnRseSBvYmV5KSBwZW9wbGUgd2hv CmhhdmUgYmVlbiB3b3JraW5nIG9uIHRoaXMgcHJvamVjdCBmb3IgeWVhcnMgYW5kIGFyZSB3ZWxs LWtub3duIGFuZApyZXNwZWN0ZWQgYnkgdGhlIHZhc3QgbWFqb3JpdHkgb2YgdGhlaXIgcGVlcnMs IHRoZW4gYnllIGJ5ZS4KCj4gU3VyZWx5LCB5b3UgY2FuIHdhaXQgd2l0aCB0aG9zZSwgbW9yZSBv ciBsZXNzLCBjb3NtZXRpYyBub24tcnVudGltZQo+IHRlc3RlZCBjaGFuZ2VzPwoKSSBzZWUgeW91 IG9uY2UgYWdhaW4gZmFpbGVkIHRvIHJlYWQgKG9yIHVuZGVyc3RhbmQpIHNvbWV0aGluZyBJIHJl cGVhdGVkCm1hbnkgdGltZXMgYWxyZWFkeS4gT25lIG9mIHRoZXNlIGNoYW5nZXMgKHRoZSBvbmUg bW92aW5nIHRoZSBod21vbgphdHRyaWJ1dGVzIGZyb20gaTJjIGRldmljZSB0byBod21vbiBkZXZp Y2UpIGlzIF9tYW5kYXRvcnlfIHRvIGdldCB5b3VyCm93biBjaGFuZ2VzIGFjY2VwdGVkLiBHdWVu dGVyIGRpZCB5b3UgYW4gaW1tZW5zZSBmYXZvciBieSB3cml0aW5nIHRoZXNlCnBhdGNoZXMsIHNv IGlmIGFueXRoaW5nIHlvdSBzaG91bGQgYmUgdmVyeSBncmF0ZWZ1bCB0byBoaW0uCgo+IFRoaXMg d291bGQgaW1wb3NlIG1lIGEgbG90IG9mIGFkZGl0aW9uYWwgd29yayBhZ2FpbiwgYW5kIEkgcGVy c29uYWxseQo+IGRvIG5vdCBzZWUgdGhlIGJlbmVmaXQgb2YgaXQuIEluIG15IGJvb2sgYXQgbGVh c3QsIGZlYXR1cmUgaXMgb3Zlcgo+IGludGVybmFsIHBvbGlzaGluZy4KCkNoYW5nZSBib29rcyB0 aGVuLCB5b3VycyBpcyBqdXN0IHdyb25nLiBCdWcgZml4ZXMgY29tZSBmaXJzdCwgdGhlbgpjbGVh bnVwcywgdGhlbiBmZWF0dXJlcy4gQWRkaW5nIGZlYXR1cmVzIG9uIHRvcCBvZiB1Z2x5IGNvZGUg aXMgYSBwYWluCmZvciBldmVyeW9uZS4gUGx1cyBjbGVhbmluZyB1cCB0aGUgY29kZSBoZWxwcyB5 b3UgdG8gdW5kZXJzdGFuZCBpdCwgc28KSSdkIHNheSB0aGlzIGlzIHRpbWUgd2VsbCBpbnZlc3Rl ZC4gWW91IHNob3VsZCB0cnksIHRoYXQgd291bGQgY2VydGFpbmx5CmhlbHAgeW91IGF2b2lkIHNv bWUgbWlzdGFrZXMgeW91IGRpZCBpbiB0aGUgcGFzdC4KCkkgd291bGQgbGlrZSB0byBhZGQgYSBt b3JlIGdlbmVyYWwgY29tbWVudCBvbiB0aGUgd2F5IHlvdSBiZWhhdmUgd2l0aAp0aGUgY29tbXVu aXR5IGFuZCB0aGF0IGhhcyBiZWVuIGJvdGhlcmluZyBtZSBmb3IgZGF5cy4gWW91IGFwcGFyZW50 bHkKYWN0IGZpcnN0IGFuZCB0aGluayBzZWNvbmQuIEkgY2FuIG5vIGxvbmdlciBjb3VudCB0aGUg bnVtYmVyIG9mIHRpbWVzCnlvdSByZXBsaWVkIHRvIGEgcG9zdCBvbmx5IHRvIHJlcGx5IHRvIHlv dXJzZWxmIGEgZmV3IG1pbnV0ZXMgbGF0ZXIuCkxhc3Qgb2NjdXJyZW5jZSBvZiB0aGlzIGlzIGlu IHRoaXMgdGhyZWFkOiBmaXJzdCByZXBseSBmcm9tIHlvdSBhdAoxMTozOCwgYW5kIHRoZW4gYW4g YWRkaXRpb24gYXQgMTE6NDYsIGkuZS4gOCBtaW51dGVzIGxhdGVyLiBBbmQgeW91IGRvCnRoYXQg YWxsIHRoZSB0aW1lLgoKQW5kIGl0IGhvbGRzIGZvciBwYXRjaGVzIHRvbywgZm9yIGV4YW1wbGUu Cmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9waXBlcm1haWwvbG0tc2Vuc29ycy8yMDE0LUZl YnJ1YXJ5LzA0MTE3OS5odG1sCnBvc3RlZCBhdCAxMToyNCwgdGhlbgpodHRwOi8vbGlzdHMubG0t c2Vuc29ycy5vcmcvcGlwZXJtYWlsL2xtLXNlbnNvcnMvMjAxNC1GZWJydWFyeS8wNDExODAuaHRt bAp2MiBvZiB0aGUgc2FtZSBwb3N0ZWQgYXQgMTE6MjguCgpTbyBwbGVhc2UgbGlzdGVuIHRvIHRo aXMgcGllY2Ugb2YgYWR2aWNlOiB0YWtlIHlvdXIgdGltZS4gVGhpbmsgbW9yZSwKYW5kIG9ubHkg YWN0IGFmdGVyIHlvdSBoYXZlIHRob3VnaHQgdGhvcm91Z2hseSBhYm91dCBldmVyeXRoaW5nLiBJ dCB3aWxsCnNhdmUgeW91IGEgbG90IG9mIHRyb3VibGUsIGFuZCB0aGUgY29tbXVuaXR5IGEgbG90 IG9mIHRpbWUuCgpUaGFua3MsCi0tIApKZWFuIERlbHZhcmUKU3VzZSBMMyBTdXBwb3J0CgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBt YWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vu c29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz
next prev parent reply other threads:[~2014-02-13 11:07 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-13 8:50 [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Laszlo Papp 2014-02-13 8:50 ` [lm-sensors] " Laszlo Papp 2014-02-13 9:58 ` Lee Jones 2014-02-13 9:58 ` [lm-sensors] " Lee Jones 2014-02-13 10:15 ` Jean Delvare 2014-02-13 10:15 ` Jean Delvare 2014-02-13 10:38 ` Laszlo Papp 2014-02-13 10:38 ` Laszlo Papp 2014-02-13 10:46 ` Laszlo Papp 2014-02-13 10:46 ` Laszlo Papp 2014-02-13 11:07 ` Jean Delvare [this message] 2014-02-13 11:07 ` Jean Delvare 2014-02-13 11:29 ` Laszlo Papp 2014-02-13 11:29 ` Laszlo Papp 2014-02-13 11:33 ` Lee Jones 2014-02-13 11:33 ` Lee Jones 2014-02-13 12:27 ` Laszlo Papp 2014-02-13 12:27 ` Laszlo Papp 2014-02-13 12:40 ` Lee Jones 2014-02-13 12:40 ` Lee Jones 2014-02-14 7:03 ` Laszlo Papp 2014-02-14 7:03 ` Laszlo Papp 2014-02-14 9:02 ` Lee Jones 2014-02-14 9:02 ` Lee Jones 2014-02-14 9:20 ` Laszlo Papp 2014-02-14 9:20 ` Laszlo Papp 2014-02-14 10:17 ` Lee Jones 2014-02-14 10:17 ` Lee Jones 2014-02-13 12:57 ` Jean Delvare 2014-02-13 12:57 ` Jean Delvare 2014-02-13 13:19 ` Laszlo Papp 2014-02-13 13:19 ` Laszlo Papp 2014-02-13 16:16 ` Guenter Roeck 2014-02-13 16:16 ` Guenter Roeck 2014-02-13 16:53 ` Laszlo Papp 2014-02-13 16:53 ` Laszlo Papp 2014-02-14 9:13 ` Lee Jones 2014-02-14 9:13 ` Lee Jones 2014-02-13 11:16 ` Lee Jones 2014-02-13 11:16 ` Lee Jones 2014-02-13 11:58 ` Jean Delvare 2014-02-13 11:58 ` Jean Delvare 2014-02-13 16:29 ` Guenter Roeck 2014-02-13 16:29 ` Guenter Roeck 2014-02-13 10:55 ` Laszlo Papp 2014-02-13 10:55 ` [lm-sensors] " Laszlo Papp
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1392289652.29672.26.camel@chaos.site \ --to=jdelvare@suse.de \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lm-sensors@lm-sensors.org \ --cc=lpapp@kde.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.