All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: Jean Delvare <jdelvare@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver
Date: Thu, 13 Feb 2014 12:40:02 +0000	[thread overview]
Message-ID: <20140213124002.GA3403@lee--X1> (raw)
In-Reply-To: <CAOMwXhMNHqXnzR0YHF9rx710JbaL3YFn=3cLf_WdNkCx7hbZug@mail.gmail.com>

> http://comments.gmane.org/gmane.linux.kernel/1645251
> 
> Step 2 did not happen. I did not get any review for my change. I
> literally submitted that within a couple of hours after the request.
> 
> Could you please tell me what was wrong with that change, and why I
> did not get any respect not to "xargs rm -rf" my work in that area? I
> believe I was ignored instead of improving the change, and someone
> else tried to address the same thing. There was no argument in that
> thread. It was a technical change. I personally do not feel happy
> about it.

Let's start again.

Rebase your work on top of the HWMON tree on kernel.org and resubmit
the entire set. If rebasing takes you more than 20 mins, you're
probably doing it wrong. Ensure you submit the entire patchset with a
nice cover letter and all the patches dangling (shallow threaded) from
it. If you don't know how to do that look at `git send-email --help`
and search for "thread", "annotate" and "compose". Keep submitting
them to your own (and only your own) email address until it looks
correct, _then_ submit to the MLs CC'ing all of the maintainers on all
of the patches.

Submission should look like this:

  [PATCH 0/x] Patch-set title
   \->[PATCH 1/x] mfd: Patch title
   |->[PATCH ./x] hwmon: Patch title
   |->[PATCH x/x] gpio/pinctrl: Patch title

We'll give you constructive reviews and you'll ask questions (not
arguments) and resubmit.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: Jean Delvare <jdelvare@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver
Date: Thu, 13 Feb 2014 12:40:02 +0000	[thread overview]
Message-ID: <20140213124002.GA3403@lee--X1> (raw)
In-Reply-To: <CAOMwXhMNHqXnzR0YHF9rx710JbaL3YFn=3cLf_WdNkCx7hbZug@mail.gmail.com>

PiBodHRwOi8vY29tbWVudHMuZ21hbmUub3JnL2dtYW5lLmxpbnV4Lmtlcm5lbC8xNjQ1MjUxCj4g
Cj4gU3RlcCAyIGRpZCBub3QgaGFwcGVuLiBJIGRpZCBub3QgZ2V0IGFueSByZXZpZXcgZm9yIG15
IGNoYW5nZS4gSQo+IGxpdGVyYWxseSBzdWJtaXR0ZWQgdGhhdCB3aXRoaW4gYSBjb3VwbGUgb2Yg
aG91cnMgYWZ0ZXIgdGhlIHJlcXVlc3QuCj4gCj4gQ291bGQgeW91IHBsZWFzZSB0ZWxsIG1lIHdo
YXQgd2FzIHdyb25nIHdpdGggdGhhdCBjaGFuZ2UsIGFuZCB3aHkgSQo+IGRpZCBub3QgZ2V0IGFu
eSByZXNwZWN0IG5vdCB0byAieGFyZ3Mgcm0gLXJmIiBteSB3b3JrIGluIHRoYXQgYXJlYT8gSQo+
IGJlbGlldmUgSSB3YXMgaWdub3JlZCBpbnN0ZWFkIG9mIGltcHJvdmluZyB0aGUgY2hhbmdlLCBh
bmQgc29tZW9uZQo+IGVsc2UgdHJpZWQgdG8gYWRkcmVzcyB0aGUgc2FtZSB0aGluZy4gVGhlcmUg
d2FzIG5vIGFyZ3VtZW50IGluIHRoYXQKPiB0aHJlYWQuIEl0IHdhcyBhIHRlY2huaWNhbCBjaGFu
Z2UuIEkgcGVyc29uYWxseSBkbyBub3QgZmVlbCBoYXBweQo+IGFib3V0IGl0LgoKTGV0J3Mgc3Rh
cnQgYWdhaW4uCgpSZWJhc2UgeW91ciB3b3JrIG9uIHRvcCBvZiB0aGUgSFdNT04gdHJlZSBvbiBr
ZXJuZWwub3JnIGFuZCByZXN1Ym1pdAp0aGUgZW50aXJlIHNldC4gSWYgcmViYXNpbmcgdGFrZXMg
eW91IG1vcmUgdGhhbiAyMCBtaW5zLCB5b3UncmUKcHJvYmFibHkgZG9pbmcgaXQgd3JvbmcuIEVu
c3VyZSB5b3Ugc3VibWl0IHRoZSBlbnRpcmUgcGF0Y2hzZXQgd2l0aCBhCm5pY2UgY292ZXIgbGV0
dGVyIGFuZCBhbGwgdGhlIHBhdGNoZXMgZGFuZ2xpbmcgKHNoYWxsb3cgdGhyZWFkZWQpIGZyb20K
aXQuIElmIHlvdSBkb24ndCBrbm93IGhvdyB0byBkbyB0aGF0IGxvb2sgYXQgYGdpdCBzZW5kLWVt
YWlsIC0taGVscGAKYW5kIHNlYXJjaCBmb3IgInRocmVhZCIsICJhbm5vdGF0ZSIgYW5kICJjb21w
b3NlIi4gS2VlcCBzdWJtaXR0aW5nCnRoZW0gdG8geW91ciBvd24gKGFuZCBvbmx5IHlvdXIgb3du
KSBlbWFpbCBhZGRyZXNzIHVudGlsIGl0IGxvb2tzCmNvcnJlY3QsIF90aGVuXyBzdWJtaXQgdG8g
dGhlIE1McyBDQydpbmcgYWxsIG9mIHRoZSBtYWludGFpbmVycyBvbiBhbGwKb2YgdGhlIHBhdGNo
ZXMuCgpTdWJtaXNzaW9uIHNob3VsZCBsb29rIGxpa2UgdGhpczoKCiAgW1BBVENIIDAveF0gUGF0
Y2gtc2V0IHRpdGxlCiAgIFwtPltQQVRDSCAxL3hdIG1mZDogUGF0Y2ggdGl0bGUKICAgfC0+W1BB
VENIIC4veF0gaHdtb246IFBhdGNoIHRpdGxlCiAgIHwtPltQQVRDSCB4L3hdIGdwaW8vcGluY3Ry
bDogUGF0Y2ggdGl0bGUKCldlJ2xsIGdpdmUgeW91IGNvbnN0cnVjdGl2ZSByZXZpZXdzIGFuZCB5
b3UnbGwgYXNrIHF1ZXN0aW9ucyAobm90CmFyZ3VtZW50cykgYW5kIHJlc3VibWl0LgoKLS0gCkxl
ZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFy
by5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJv
OiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxt
LXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2xtLXNlbnNvcnM

  reply	other threads:[~2014-02-13 12:40 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13  8:50 [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Laszlo Papp
2014-02-13  8:50 ` [lm-sensors] " Laszlo Papp
2014-02-13  9:58 ` Lee Jones
2014-02-13  9:58   ` [lm-sensors] " Lee Jones
2014-02-13 10:15   ` Jean Delvare
2014-02-13 10:15     ` Jean Delvare
2014-02-13 10:38     ` Laszlo Papp
2014-02-13 10:38       ` Laszlo Papp
2014-02-13 10:46       ` Laszlo Papp
2014-02-13 10:46         ` Laszlo Papp
2014-02-13 11:07         ` Jean Delvare
2014-02-13 11:07           ` Jean Delvare
2014-02-13 11:29           ` Laszlo Papp
2014-02-13 11:29             ` Laszlo Papp
2014-02-13 11:33         ` Lee Jones
2014-02-13 11:33           ` Lee Jones
2014-02-13 12:27           ` Laszlo Papp
2014-02-13 12:27             ` Laszlo Papp
2014-02-13 12:40             ` Lee Jones [this message]
2014-02-13 12:40               ` Lee Jones
2014-02-14  7:03               ` Laszlo Papp
2014-02-14  7:03                 ` Laszlo Papp
2014-02-14  9:02                 ` Lee Jones
2014-02-14  9:02                   ` Lee Jones
2014-02-14  9:20                   ` Laszlo Papp
2014-02-14  9:20                     ` Laszlo Papp
2014-02-14 10:17                     ` Lee Jones
2014-02-14 10:17                       ` Lee Jones
2014-02-13 12:57             ` Jean Delvare
2014-02-13 12:57               ` Jean Delvare
2014-02-13 13:19               ` Laszlo Papp
2014-02-13 13:19                 ` Laszlo Papp
2014-02-13 16:16             ` Guenter Roeck
2014-02-13 16:16               ` Guenter Roeck
2014-02-13 16:53               ` Laszlo Papp
2014-02-13 16:53                 ` Laszlo Papp
2014-02-14  9:13                 ` Lee Jones
2014-02-14  9:13                   ` Lee Jones
2014-02-13 11:16     ` Lee Jones
2014-02-13 11:16       ` Lee Jones
2014-02-13 11:58       ` Jean Delvare
2014-02-13 11:58         ` Jean Delvare
2014-02-13 16:29         ` Guenter Roeck
2014-02-13 16:29           ` Guenter Roeck
2014-02-13 10:55   ` Laszlo Papp
2014-02-13 10:55     ` [lm-sensors] " Laszlo Papp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213124002.GA3403@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=lpapp@kde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.