All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Benoît Canet" <benoit.canet@irqsave.net>
Subject: [Qemu-devel] [PATCH] Fix: remove bogus QDECREF()
Date: Thu, 13 Feb 2014 17:22:32 +0100	[thread overview]
Message-ID: <1392308553-9886-1-git-send-email-benoit.canet@irqsave.net> (raw)

This extra QDECREF() was causing quorum_close() to crash while doing
bdrv_unref().

As the optional options qdict should belong to the block layer so do not use
QDECREF() on it.

I tested the following inti and qemu exit sequences.

tested regular snapshots on device=virtio0 ok
tested command line quorum ok
tested command line quorum + snapshot transaction ok
tested quorum open by reference ok
tested quorum open by reference + snapshot transaction ok
tested quorum open at once ok
tested quorum open at once + snapshot transaction ok

Benoît Canet (1):
  blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to
    crash on close.

 blockdev.c | 2 --
 1 file changed, 2 deletions(-)

-- 
1.8.3.2

             reply	other threads:[~2014-02-13 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 16:22 Benoît Canet [this message]
2014-02-13 16:22 ` [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close Benoît Canet
2014-02-14 10:01   ` Kevin Wolf
2014-02-14 15:30   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392308553-9886-1-git-send-email-benoit.canet@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.