All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org,
	Benoit Canet <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.
Date: Fri, 14 Feb 2014 16:30:05 +0100	[thread overview]
Message-ID: <20140214153005.GU17391@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1392308553-9886-2-git-send-email-benoit.canet@irqsave.net>

On Thu, Feb 13, 2014 at 05:22:33PM +0100, Benoît Canet wrote:
> As bdrv_open() documentation states:
> "The reference to the QDict belongs to the block layer
>  * after the call (even on failure), so if the caller intends to reuse the
>  * dictionary, it needs to use QINCREF() before calling bdrv_open."
> 
> the optional options dict will not be reused after bdrv_open() and should
> belong to the block layer so remove the extra QDECREF(options).
> 
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  blockdev.c | 2 --
>  1 file changed, 2 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

      parent reply	other threads:[~2014-02-14 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 16:22 [Qemu-devel] [PATCH] Fix: remove bogus QDECREF() Benoît Canet
2014-02-13 16:22 ` [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close Benoît Canet
2014-02-14 10:01   ` Kevin Wolf
2014-02-14 15:30   ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214153005.GU17391@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=benoit.canet@irqsave.net \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.