* [lm-sensors] [PATCH 2/3] hwmon: (ltc4245) Associate log messages with hwmon device
@ 2014-02-16 2:16 Guenter Roeck
2014-02-23 10:46 ` Jean Delvare
2014-02-23 16:38 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-02-16 2:16 UTC (permalink / raw)
To: lm-sensors
Since sysfs attributes are not attached to the hwmon device,
it makes sense to associate log messages with the hwmon device
as well.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/ltc4245.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/ltc4245.c b/drivers/hwmon/ltc4245.c
index 2c6da5d..0a3eddb 100644
--- a/drivers/hwmon/ltc4245.c
+++ b/drivers/hwmon/ltc4245.c
@@ -95,7 +95,7 @@ static void ltc4245_update_gpios(struct device *dev)
* readings as stale by setting them to -EAGAIN
*/
if (time_after(jiffies, data->last_updated + 5 * HZ)) {
- dev_dbg(&client->dev, "Marking GPIOs invalid\n");
+ dev_dbg(dev, "Marking GPIOs invalid\n");
for (i = 0; i < ARRAY_SIZE(data->gpios); i++)
data->gpios[i] = -EAGAIN;
}
@@ -141,7 +141,7 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)
if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
- dev_dbg(&client->dev, "Starting ltc4245 update\n");
+ dev_dbg(dev, "Starting ltc4245 update\n");
/* Read control registers -- 0x00 to 0x07 */
for (i = 0; i < ARRAY_SIZE(data->cregs); i++) {
--
1.7.9.7
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 2/3] hwmon: (ltc4245) Associate log messages with hwmon device
2014-02-16 2:16 [lm-sensors] [PATCH 2/3] hwmon: (ltc4245) Associate log messages with hwmon device Guenter Roeck
@ 2014-02-23 10:46 ` Jean Delvare
2014-02-23 16:38 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2014-02-23 10:46 UTC (permalink / raw)
To: lm-sensors
On Sat, 15 Feb 2014 18:16:11 -0800, Guenter Roeck wrote:
> Since sysfs attributes are not attached to the hwmon device,
> it makes sense to associate log messages with the hwmon device
> as well.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/ltc4245.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/ltc4245.c b/drivers/hwmon/ltc4245.c
> index 2c6da5d..0a3eddb 100644
> --- a/drivers/hwmon/ltc4245.c
> +++ b/drivers/hwmon/ltc4245.c
> @@ -95,7 +95,7 @@ static void ltc4245_update_gpios(struct device *dev)
> * readings as stale by setting them to -EAGAIN
> */
> if (time_after(jiffies, data->last_updated + 5 * HZ)) {
> - dev_dbg(&client->dev, "Marking GPIOs invalid\n");
> + dev_dbg(dev, "Marking GPIOs invalid\n");
> for (i = 0; i < ARRAY_SIZE(data->gpios); i++)
> data->gpios[i] = -EAGAIN;
> }
> @@ -141,7 +141,7 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)
>
> if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
>
> - dev_dbg(&client->dev, "Starting ltc4245 update\n");
> + dev_dbg(dev, "Starting ltc4245 update\n");
>
> /* Read control registers -- 0x00 to 0x07 */
> for (i = 0; i < ARRAY_SIZE(data->cregs); i++) {
Both debug messages are quite pointless IMHO and I'd rather delete them
than update them.
--
Jean Delvare
Suse L3 Support
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 2/3] hwmon: (ltc4245) Associate log messages with hwmon device
2014-02-16 2:16 [lm-sensors] [PATCH 2/3] hwmon: (ltc4245) Associate log messages with hwmon device Guenter Roeck
2014-02-23 10:46 ` Jean Delvare
@ 2014-02-23 16:38 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-02-23 16:38 UTC (permalink / raw)
To: lm-sensors
On 02/23/2014 02:46 AM, Jean Delvare wrote:
> On Sat, 15 Feb 2014 18:16:11 -0800, Guenter Roeck wrote:
>> Since sysfs attributes are not attached to the hwmon device,
>> it makes sense to associate log messages with the hwmon device
>> as well.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> drivers/hwmon/ltc4245.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwmon/ltc4245.c b/drivers/hwmon/ltc4245.c
>> index 2c6da5d..0a3eddb 100644
>> --- a/drivers/hwmon/ltc4245.c
>> +++ b/drivers/hwmon/ltc4245.c
>> @@ -95,7 +95,7 @@ static void ltc4245_update_gpios(struct device *dev)
>> * readings as stale by setting them to -EAGAIN
>> */
>> if (time_after(jiffies, data->last_updated + 5 * HZ)) {
>> - dev_dbg(&client->dev, "Marking GPIOs invalid\n");
>> + dev_dbg(dev, "Marking GPIOs invalid\n");
>> for (i = 0; i < ARRAY_SIZE(data->gpios); i++)
>> data->gpios[i] = -EAGAIN;
>> }
>> @@ -141,7 +141,7 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)
>>
>> if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
>>
>> - dev_dbg(&client->dev, "Starting ltc4245 update\n");
>> + dev_dbg(dev, "Starting ltc4245 update\n");
>>
>> /* Read control registers -- 0x00 to 0x07 */
>> for (i = 0; i < ARRAY_SIZE(data->cregs); i++) {
>
> Both debug messages are quite pointless IMHO and I'd rather delete them
> than update them.
>
Ok, I'll do that.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-23 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-16 2:16 [lm-sensors] [PATCH 2/3] hwmon: (ltc4245) Associate log messages with hwmon device Guenter Roeck
2014-02-23 10:46 ` Jean Delvare
2014-02-23 16:38 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.