* [PATCH] Documentation: broadcom-bcmgenet: fix address and cells properties
@ 2014-02-18 0:27 Florian Fainelli
2014-02-18 4:37 ` Florian Fainelli
2014-02-18 22:23 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2014-02-18 0:27 UTC (permalink / raw)
To: netdev; +Cc: davem, sergei.shtylyov, Florian Fainelli
This patch fixes a typo in the Device Tree binding for the
leading '#'.
Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
index 88c3d04..25339ee 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
+++ b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
@@ -10,8 +10,8 @@ Required properties:
- phy-mode: String, operation mode of the PHY interface. Supported values are
"mii", "rgmii", "rgmii-txid", "rev-mii", "moca". Analogous to ePAPR
"phy-connection-type" values
-- address-cells: should be 1
-- size-cells: should be 1
+- #address-cells: should be 1
+- #size-cells: should be 1
Optional properties:
- clocks: When provided, must be two phandles to the functional clocks nodes
@@ -42,8 +42,8 @@ MDIO bus node required properties:
parent node compatible property (e.g: brcm,genet-v4 pairs with
brcm,genet-mdio-v4)
- reg: address and length relative to the parent node base register address
-- address-cells: address cell for MDIO bus addressing, should be 1
-- size-cells: size of the cells for MDIO bus addressing, should be 0
+- #address-cells: address cell for MDIO bus addressing, should be 1
+- #size-cells: size of the cells for MDIO bus addressing, should be 0
Ethernet PHY node properties:
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: broadcom-bcmgenet: fix address and cells properties
2014-02-18 0:27 [PATCH] Documentation: broadcom-bcmgenet: fix address and cells properties Florian Fainelli
@ 2014-02-18 4:37 ` Florian Fainelli
2014-02-18 22:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2014-02-18 4:37 UTC (permalink / raw)
To: netdev; +Cc: davem, sergei.shtylyov
Le lundi 17 février 2014, 16:27:35 Florian Fainelli a écrit :
> This patch fixes a typo in the Device Tree binding for the
> leading '#'.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
Forgot to mention that this patch is for the net-next tree. Thanks!
> Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
> b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt index
> 88c3d04..25339ee 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
> +++ b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
> @@ -10,8 +10,8 @@ Required properties:
> - phy-mode: String, operation mode of the PHY interface. Supported values
> are "mii", "rgmii", "rgmii-txid", "rev-mii", "moca". Analogous to ePAPR
> "phy-connection-type" values
> -- address-cells: should be 1
> -- size-cells: should be 1
> +- #address-cells: should be 1
> +- #size-cells: should be 1
>
> Optional properties:
> - clocks: When provided, must be two phandles to the functional clocks
> nodes @@ -42,8 +42,8 @@ MDIO bus node required properties:
> parent node compatible property (e.g: brcm,genet-v4 pairs with
> brcm,genet-mdio-v4)
> - reg: address and length relative to the parent node base register address
> -- address-cells: address cell for MDIO bus addressing, should be 1 --
> size-cells: size of the cells for MDIO bus addressing, should be 0 +-
> #address-cells: address cell for MDIO bus addressing, should be 1 +-
> #size-cells: size of the cells for MDIO bus addressing, should be 0
>
> Ethernet PHY node properties:
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: broadcom-bcmgenet: fix address and cells properties
2014-02-18 0:27 [PATCH] Documentation: broadcom-bcmgenet: fix address and cells properties Florian Fainelli
2014-02-18 4:37 ` Florian Fainelli
@ 2014-02-18 22:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-02-18 22:23 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, sergei.shtylyov
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 17 Feb 2014 16:27:35 -0800
> This patch fixes a typo in the Device Tree binding for the
> leading '#'.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Sergei put the phy-mode documentation to a common location, so you'll
need to respin this.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-18 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-18 0:27 [PATCH] Documentation: broadcom-bcmgenet: fix address and cells properties Florian Fainelli
2014-02-18 4:37 ` Florian Fainelli
2014-02-18 22:23 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.