[PATCH] ip_set: remove extraneous log message

[PATCH] ip_set: remove extraneous log message

[Jason A. Donenfeld]

This code path is hit everytime a new network namespace is created,
which means it runs everytime I start Chromium, resulting in needless
noise in my logs. This message doesn't add very much at all, and isn't
triggered at the correct place anyway, so this patch simply removes it.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 net/netfilter/ipset/ip_set_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
index de770ec..283f197 100644
--- a/net/netfilter/ipset/ip_set_core.c
+++ b/net/netfilter/ipset/ip_set_core.c
@@ -1945,7 +1945,6 @@ ip_set_net_init(struct net *net)
 		return -ENOMEM;
 	inst->is_deleted = 0;
 	rcu_assign_pointer(inst->ip_set_list, list);
-	pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL);
 	return 0;
 }
 
-- 
1.8.5.4

Re: [PATCH] ip_set: remove extraneous log message

[Jozsef Kadlecsik]

On Sun, 2 Mar 2014, Jason A. Donenfeld wrote:

> This code path is hit everytime a new network namespace is created,
> which means it runs everytime I start Chromium, resulting in needless
> noise in my logs. This message doesn't add very much at all, and isn't
> triggered at the correct place anyway, so this patch simply removes it.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  net/netfilter/ipset/ip_set_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
> index de770ec..283f197 100644
> --- a/net/netfilter/ipset/ip_set_core.c
> +++ b/net/netfilter/ipset/ip_set_core.c
> @@ -1945,7 +1945,6 @@ ip_set_net_init(struct net *net)
>  		return -ENOMEM;
>  	inst->is_deleted = 0;
>  	rcu_assign_pointer(inst->ip_set_list, list);
> -	pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL);
>  	return 0;
>  }

A similar patch has already been applied to the ipset git tree and going 
to be submitted this week. Thanks your patch anyway.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary