* [PATCH] drm/radeon: fix VCE fence command
@ 2014-04-14 22:10 Christoph Jaeger
2014-04-14 22:13 ` Deucher, Alexander
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Jaeger @ 2014-04-14 22:10 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied
Cc: dri-devel, linux-kernel, Christoph Jaeger
Due to a type mismatch that causes an implicit type conversion, the
upper 32 bits of the GPU address have been zeroed out when adding to the
command buffer.
Picked up by Coverity - CID 1198624.
Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>
---
drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
index 76e9904..ced53dd 100644
--- a/drivers/gpu/drm/radeon/radeon_vce.c
+++ b/drivers/gpu/drm/radeon/radeon_vce.c
@@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device *rdev,
struct radeon_fence *fence)
{
struct radeon_ring *ring = &rdev->ring[fence->ring];
- uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
+ uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;
radeon_ring_write(ring, VCE_CMD_FENCE);
radeon_ring_write(ring, addr);
--
1.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/radeon: fix VCE fence command
2014-04-14 22:10 [PATCH] drm/radeon: fix VCE fence command Christoph Jaeger
@ 2014-04-14 22:13 ` Deucher, Alexander
0 siblings, 0 replies; 4+ messages in thread
From: Deucher, Alexander @ 2014-04-14 22:13 UTC (permalink / raw)
To: Christoph Jaeger, Koenig, Christian, airlied; +Cc: dri-devel, linux-kernel
> -----Original Message-----
> From: Christoph Jaeger [mailto:christophjaeger@linux.com]
> Sent: Monday, April 14, 2014 6:10 PM
> To: Deucher, Alexander; Koenig, Christian; airlied@linux.ie
> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Christoph
> Jaeger
> Subject: [PATCH] drm/radeon: fix VCE fence command
>
> Due to a type mismatch that causes an implicit type conversion, the
> upper 32 bits of the GPU address have been zeroed out when adding to the
> command buffer.
>
> Picked up by Coverity - CID 1198624.
>
> Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>
Good catch!
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c
> b/drivers/gpu/drm/radeon/radeon_vce.c
> index 76e9904..ced53dd 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device
> *rdev,
> struct radeon_fence *fence)
> {
> struct radeon_ring *ring = &rdev->ring[fence->ring];
> - uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> + uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;
>
> radeon_ring_write(ring, VCE_CMD_FENCE);
> radeon_ring_write(ring, addr);
> --
> 1.9.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/radeon: fix VCE fence command
@ 2014-04-14 22:13 ` Deucher, Alexander
0 siblings, 0 replies; 4+ messages in thread
From: Deucher, Alexander @ 2014-04-14 22:13 UTC (permalink / raw)
To: Christoph Jaeger, Koenig, Christian, airlied; +Cc: linux-kernel, dri-devel
> -----Original Message-----
> From: Christoph Jaeger [mailto:christophjaeger@linux.com]
> Sent: Monday, April 14, 2014 6:10 PM
> To: Deucher, Alexander; Koenig, Christian; airlied@linux.ie
> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Christoph
> Jaeger
> Subject: [PATCH] drm/radeon: fix VCE fence command
>
> Due to a type mismatch that causes an implicit type conversion, the
> upper 32 bits of the GPU address have been zeroed out when adding to the
> command buffer.
>
> Picked up by Coverity - CID 1198624.
>
> Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>
Good catch!
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c
> b/drivers/gpu/drm/radeon/radeon_vce.c
> index 76e9904..ced53dd 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device
> *rdev,
> struct radeon_fence *fence)
> {
> struct radeon_ring *ring = &rdev->ring[fence->ring];
> - uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> + uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;
>
> radeon_ring_write(ring, VCE_CMD_FENCE);
> radeon_ring_write(ring, addr);
> --
> 1.9.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: fix VCE fence command
2014-04-14 22:13 ` Deucher, Alexander
(?)
@ 2014-04-15 9:17 ` Christian König
-1 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2014-04-15 9:17 UTC (permalink / raw)
To: Deucher, Alexander, Christoph Jaeger, airlied; +Cc: dri-devel, linux-kernel
Am 15.04.2014 00:13, schrieb Deucher, Alexander:
>> -----Original Message-----
>> From: Christoph Jaeger [mailto:christophjaeger@linux.com]
>> Sent: Monday, April 14, 2014 6:10 PM
>> To: Deucher, Alexander; Koenig, Christian; airlied@linux.ie
>> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Christoph
>> Jaeger
>> Subject: [PATCH] drm/radeon: fix VCE fence command
>>
>> Due to a type mismatch that causes an implicit type conversion, the
>> upper 32 bits of the GPU address have been zeroed out when adding to the
>> command buffer.
>>
>> Picked up by Coverity - CID 1198624.
>>
>> Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>
> Good catch!
Indeed.
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Added to my 3.15 fixes queue.
Thanks,
Christian.
>
>> ---
>> drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c
>> b/drivers/gpu/drm/radeon/radeon_vce.c
>> index 76e9904..ced53dd 100644
>> --- a/drivers/gpu/drm/radeon/radeon_vce.c
>> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
>> @@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device
>> *rdev,
>> struct radeon_fence *fence)
>> {
>> struct radeon_ring *ring = &rdev->ring[fence->ring];
>> - uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
>> + uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;
>>
>> radeon_ring_write(ring, VCE_CMD_FENCE);
>> radeon_ring_write(ring, addr);
>> --
>> 1.9.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-15 9:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-14 22:10 [PATCH] drm/radeon: fix VCE fence command Christoph Jaeger
2014-04-14 22:13 ` Deucher, Alexander
2014-04-14 22:13 ` Deucher, Alexander
2014-04-15 9:17 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.