All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Niemeyer <tim.niemeyer@corscience.de>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	Robert Nelson <robertcnelson@gmail.com>,
	nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, airlied@linux.ie,
	robdclark@gmail.com, plagnioj@jcrosoft.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/3] DRM driver for the ATMEL High end LCD controller
Date: Thu, 24 Apr 2014 14:46:52 +0200	[thread overview]
Message-ID: <1398343612.4295.66.camel@herbert.er.corscience.de> (raw)
In-Reply-To: <5359000C.50005@free-electrons.com>

Hi Boris

Am Donnerstag, den 24.04.2014, 14:14 +0200 schrieb Boris BREZILLON:
> Hi Tim,
> 
> On 23/04/2014 17:36, Tim Niemeyer wrote:
> > Hi Jean-Jacques,
> >
> > Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot:
> >> Hi,
> >>
> >> this patch serie implements a simple DRM driver for the ATMEL High end LCD
> >> controller found in the SAMA5 familly. It's based on the tilcdc driver.
> >> It uses the cma_helper for memory and fbdev stuff.
> >> Your comments are welcome !
> > I applied your and Robert's patches on a 3.15-rc2 kernel and tried the
> > framebuffer device on the sama5d31-ek. Seems to work.
> >
> >> Supported features:
> >> * the base layer (the main framebuffer)
> > Tested to show a little tux png, but it's appearing only after 
> > 'echo 0 > /sys/devices/ahb.1/apb.2/f0030000.hlcdc/graphics/fb0/rotate'
> > is there missing some initializing?
> 
> Could you try to apply this http://code.bulix.org/f01kvh-86117 ?
I can't see any difference with that.

I used fbv to display the tux. With CONFIG_FRAMEBUFFER_CONSOLE=n the
display stays with a small atmel logo and u-Boot version information. If
i set CONFIG_FRAMEBUFFER_CONSOLE=y, the display is black after kernel
start and fbv just works as expected.

Best Regards,
Tim

> Best Regards,
> 
> Boris
> 
> >
> >> * a simple panel
> >> * a backlight driver
> > Tested to set brightness to 0, 20 and 255. Works.
> >
> > Thanks for your work.
> >
> > Best Regards
> > Tim
> >
> >> * structure to 'easily' add other connectors (it comes from the tilcdc)
> >>
> >> On the todo list:
> >> * support overlays as drm_planes
> >> * support for the hardware cursor
> >> * support for the SiI9022 HDMI connector (present on sama5d36ek)
> >>
> >>
> >> Jean-Jacques Hiblot (3):
> >>   atmel: drm: added drm driver for the atmel hlcd controller
> >>   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
> >>   atmel: dt: Add supports for the lcdc support on the sama5d36ek
> >>
> >>  arch/arm/boot/dts/sama5d36ek.dts                   |  27 +-
> >>  arch/arm/boot/dts/sama5d3_lcd.dtsi                 |  11 +
> >>  drivers/gpu/drm/Kconfig                            |   2 +
> >>  drivers/gpu/drm/Makefile                           |   1 +
> >>  drivers/gpu/drm/atmel_hlcdc/Kconfig                |  13 +
> >>  drivers/gpu/drm/atmel_hlcdc/Makefile               |  12 +
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h          | 771 +++++++++++++++++++++
> >>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c    |  92 +++
> >>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h    |  25 +
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c     | 702 +++++++++++++++++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c      | 586 ++++++++++++++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h      | 124 ++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h      | 190 +++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c    | 459 ++++++++++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h    |  28 +
> >>  15 files changed, 3042 insertions(+), 1 deletion(-)
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h
> >>
> >> --
> >> 1.9.1
> >>
> >>
> >> _______________________________________________
> >> linux-arm-kernel mailing list
> >> linux-arm-kernel@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
> 



WARNING: multiple messages have this Message-ID (diff)
From: tim.niemeyer@corscience.de (Tim Niemeyer)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 0/3] DRM driver for the ATMEL High end LCD controller
Date: Thu, 24 Apr 2014 14:46:52 +0200	[thread overview]
Message-ID: <1398343612.4295.66.camel@herbert.er.corscience.de> (raw)
In-Reply-To: <5359000C.50005@free-electrons.com>

Hi Boris

Am Donnerstag, den 24.04.2014, 14:14 +0200 schrieb Boris BREZILLON:
> Hi Tim,
> 
> On 23/04/2014 17:36, Tim Niemeyer wrote:
> > Hi Jean-Jacques,
> >
> > Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot:
> >> Hi,
> >>
> >> this patch serie implements a simple DRM driver for the ATMEL High end LCD
> >> controller found in the SAMA5 familly. It's based on the tilcdc driver.
> >> It uses the cma_helper for memory and fbdev stuff.
> >> Your comments are welcome !
> > I applied your and Robert's patches on a 3.15-rc2 kernel and tried the
> > framebuffer device on the sama5d31-ek. Seems to work.
> >
> >> Supported features:
> >> * the base layer (the main framebuffer)
> > Tested to show a little tux png, but it's appearing only after 
> > 'echo 0 > /sys/devices/ahb.1/apb.2/f0030000.hlcdc/graphics/fb0/rotate'
> > is there missing some initializing?
> 
> Could you try to apply this http://code.bulix.org/f01kvh-86117 ?
I can't see any difference with that.

I used fbv to display the tux. With CONFIG_FRAMEBUFFER_CONSOLE=n the
display stays with a small atmel logo and u-Boot version information. If
i set CONFIG_FRAMEBUFFER_CONSOLE=y, the display is black after kernel
start and fbv just works as expected.

Best Regards,
Tim

> Best Regards,
> 
> Boris
> 
> >
> >> * a simple panel
> >> * a backlight driver
> > Tested to set brightness to 0, 20 and 255. Works.
> >
> > Thanks for your work.
> >
> > Best Regards
> > Tim
> >
> >> * structure to 'easily' add other connectors (it comes from the tilcdc)
> >>
> >> On the todo list:
> >> * support overlays as drm_planes
> >> * support for the hardware cursor
> >> * support for the SiI9022 HDMI connector (present on sama5d36ek)
> >>
> >>
> >> Jean-Jacques Hiblot (3):
> >>   atmel: drm: added drm driver for the atmel hlcd controller
> >>   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
> >>   atmel: dt: Add supports for the lcdc support on the sama5d36ek
> >>
> >>  arch/arm/boot/dts/sama5d36ek.dts                   |  27 +-
> >>  arch/arm/boot/dts/sama5d3_lcd.dtsi                 |  11 +
> >>  drivers/gpu/drm/Kconfig                            |   2 +
> >>  drivers/gpu/drm/Makefile                           |   1 +
> >>  drivers/gpu/drm/atmel_hlcdc/Kconfig                |  13 +
> >>  drivers/gpu/drm/atmel_hlcdc/Makefile               |  12 +
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h          | 771 +++++++++++++++++++++
> >>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c    |  92 +++
> >>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h    |  25 +
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c     | 702 +++++++++++++++++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c      | 586 ++++++++++++++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h      | 124 ++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h      | 190 +++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c    | 459 ++++++++++++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h    |  28 +
> >>  15 files changed, 3042 insertions(+), 1 deletion(-)
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h
> >>
> >> --
> >> 1.9.1
> >>
> >>
> >> _______________________________________________
> >> linux-arm-kernel mailing list
> >> linux-arm-kernel at lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
> 

  reply	other threads:[~2014-04-24 12:52 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18  9:45 [RFC 0/3] DRM driver for the ATMEL High end LCD controller Jean-Jacques Hiblot
2014-04-18  9:45 ` Jean-Jacques Hiblot
2014-04-18  9:45 ` [RFC 1/3] atmel: drm: added drm driver for the atmel hlcd controller Jean-Jacques Hiblot
2014-04-18  9:45   ` Jean-Jacques Hiblot
2014-04-18  9:45   ` Jean-Jacques Hiblot
2014-04-18 13:21   ` Boris BREZILLON
2014-04-18 13:21     ` Boris BREZILLON
2014-04-18 14:31     ` Robert Nelson
2014-04-18 14:31       ` Robert Nelson
2014-04-18 14:31       ` Robert Nelson
2014-04-19 19:03       ` Jean-Jacques Hiblot
2014-04-19 19:03         ` Jean-Jacques Hiblot
2014-04-19 19:03         ` Jean-Jacques Hiblot
2014-04-28 19:22   ` Boris BREZILLON
2014-04-28 19:22     ` Boris BREZILLON
2014-05-01  6:34     ` Jean-Jacques Hiblot
2014-05-01  6:34       ` Jean-Jacques Hiblot
2014-04-18  9:45 ` [RFC 2/3] atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5 Jean-Jacques Hiblot
2014-04-18  9:45   ` Jean-Jacques Hiblot
2014-04-18  9:45   ` Jean-Jacques Hiblot
2014-04-18  9:45 ` [RFC 3/3] atmel: dt: Add supports for the lcdc support on the sama5d36ek Jean-Jacques Hiblot
2014-04-18  9:45   ` Jean-Jacques Hiblot
2014-04-18  9:45   ` Jean-Jacques Hiblot
2014-04-18 14:48   ` Robert Nelson
2014-04-18 14:48     ` Robert Nelson
2014-04-18 14:48     ` Robert Nelson
2014-04-19 19:07     ` Jean-Jacques Hiblot
2014-04-19 19:07       ` Jean-Jacques Hiblot
2014-04-19 19:07       ` Jean-Jacques Hiblot
2014-04-18 13:37 ` [RFC 0/3] DRM driver for the ATMEL High end LCD controller Boris BREZILLON
2014-04-18 13:37   ` Boris BREZILLON
2014-04-23 15:36 ` Tim Niemeyer
2014-04-23 15:36   ` Tim Niemeyer
2014-04-24 12:14   ` Boris BREZILLON
2014-04-24 12:14     ` Boris BREZILLON
2014-04-24 12:46     ` Tim Niemeyer [this message]
2014-04-24 12:46       ` Tim Niemeyer
2014-04-24 16:59       ` Jean-Jacques Hiblot
2014-04-24 16:59         ` Jean-Jacques Hiblot
2014-04-30 14:31       ` Jean-Jacques Hiblot
2014-04-30 14:31         ` Jean-Jacques Hiblot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398343612.4295.66.camel@herbert.er.corscience.de \
    --to=tim.niemeyer@corscience.de \
    --cc=airlied@linux.ie \
    --cc=boris.brezillon@free-electrons.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jjhiblot@traphandler.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robdclark@gmail.com \
    --cc=robertcnelson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.