* [PATCH] libxl: add stdvga video memory setting with upstream qemu
@ 2014-04-24 13:29 Fabio Fantoni
2014-05-02 9:12 ` Fabio Fantoni
2014-05-02 12:24 ` Ian Campbell
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Fantoni @ 2014-04-24 13:29 UTC (permalink / raw)
To: xen-devel
Cc: anthony.perard, Fabio Fantoni, Ian.Jackson, Ian.Campbell,
Stefano.Stabellini
Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
---
tools/libxl/libxl_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 90f19b7..51ab2bf 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -505,7 +505,9 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
switch (b_info->u.hvm.vga.kind) {
case LIBXL_VGA_INTERFACE_TYPE_STD:
- flexarray_append_pair(dm_args, "-device", "VGA");
+ flexarray_append_pair(dm_args, "-device",
+ GCSPRINTF("VGA,vgamem_mb=%d",
+ libxl__sizekb_to_mb(b_info->video_memkb)));
break;
case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
flexarray_append_pair(dm_args, "-device",
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] libxl: add stdvga video memory setting with upstream qemu
2014-04-24 13:29 [PATCH] libxl: add stdvga video memory setting with upstream qemu Fabio Fantoni
@ 2014-05-02 9:12 ` Fabio Fantoni
2014-05-02 12:24 ` Ian Campbell
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Fantoni @ 2014-05-02 9:12 UTC (permalink / raw)
To: xen-devel; +Cc: anthony.perard, Ian.Jackson, Ian.Campbell, Stefano.Stabellini
Il 24/04/2014 15:29, Fabio Fantoni ha scritto:
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> ---
> tools/libxl/libxl_dm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 90f19b7..51ab2bf 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -505,7 +505,9 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
>
> switch (b_info->u.hvm.vga.kind) {
> case LIBXL_VGA_INTERFACE_TYPE_STD:
> - flexarray_append_pair(dm_args, "-device", "VGA");
> + flexarray_append_pair(dm_args, "-device",
> + GCSPRINTF("VGA,vgamem_mb=%d",
> + libxl__sizekb_to_mb(b_info->video_memkb)));
> break;
> case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
> flexarray_append_pair(dm_args, "-device",
Ping
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libxl: add stdvga video memory setting with upstream qemu
2014-04-24 13:29 [PATCH] libxl: add stdvga video memory setting with upstream qemu Fabio Fantoni
2014-05-02 9:12 ` Fabio Fantoni
@ 2014-05-02 12:24 ` Ian Campbell
2014-05-02 13:46 ` Fabio Fantoni
1 sibling, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2014-05-02 12:24 UTC (permalink / raw)
To: Fabio Fantoni; +Cc: anthony.perard, xen-devel, Ian.Jackson, Stefano.Stabellini
On Thu, 2014-04-24 at 15:29 +0200, Fabio Fantoni wrote:
Is this change applicable to all versions of qemu which might be used
with Xen?
Stefano,Anthony: Your feedback would be appreciated.
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> ---
> tools/libxl/libxl_dm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 90f19b7..51ab2bf 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -505,7 +505,9 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
>
> switch (b_info->u.hvm.vga.kind) {
> case LIBXL_VGA_INTERFACE_TYPE_STD:
> - flexarray_append_pair(dm_args, "-device", "VGA");
> + flexarray_append_pair(dm_args, "-device",
> + GCSPRINTF("VGA,vgamem_mb=%d",
> + libxl__sizekb_to_mb(b_info->video_memkb)));
> break;
> case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
> flexarray_append_pair(dm_args, "-device",
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libxl: add stdvga video memory setting with upstream qemu
2014-05-02 12:24 ` Ian Campbell
@ 2014-05-02 13:46 ` Fabio Fantoni
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Fantoni @ 2014-05-02 13:46 UTC (permalink / raw)
To: Ian Campbell; +Cc: anthony.perard, xen-devel, Ian.Jackson, Stefano.Stabellini
Il 02/05/2014 14:24, Ian Campbell ha scritto:
> On Thu, 2014-04-24 at 15:29 +0200, Fabio Fantoni wrote:
>
> Is this change applicable to all versions of qemu which might be used
> with Xen?
vgamem_mb property was added in qemu 1.3 (same for cirrus vga patch),
xen 4.4 from source use qemu 1.6, and from distributions package is
newer all case I saw, then FWIK there should be no problems.
Xen 4.4 if I remember good change other important qemu value for hvm
domUs that require qemu>=1.6.
>
> Stefano,Anthony: Your feedback would be appreciated.
>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>> ---
>> tools/libxl/libxl_dm.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 90f19b7..51ab2bf 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -505,7 +505,9 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
>>
>> switch (b_info->u.hvm.vga.kind) {
>> case LIBXL_VGA_INTERFACE_TYPE_STD:
>> - flexarray_append_pair(dm_args, "-device", "VGA");
>> + flexarray_append_pair(dm_args, "-device",
>> + GCSPRINTF("VGA,vgamem_mb=%d",
>> + libxl__sizekb_to_mb(b_info->video_memkb)));
>> break;
>> case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
>> flexarray_append_pair(dm_args, "-device",
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-02 13:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-24 13:29 [PATCH] libxl: add stdvga video memory setting with upstream qemu Fabio Fantoni
2014-05-02 9:12 ` Fabio Fantoni
2014-05-02 12:24 ` Ian Campbell
2014-05-02 13:46 ` Fabio Fantoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.