All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: David Scott <dave.scott@citrix.com>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com,
	ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 3/6] libxl: implement channels via PV console rings
Date: Wed, 18 Jun 2014 14:31:34 +0100	[thread overview]
Message-ID: <1403098294.6568.9.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1402912195-24732-4-git-send-email-dave.scott@citrix.com>

On Mon, 2014-06-16 at 10:49 +0100, David Scott wrote:
> We extend the (internal) console type with a 'name' (string)
> which isn't used by the default built-in console 0.

Normally this would be part of the same patch which added the idl
change.

You also need to add a #define LIBXL_HAVE_FOO to libxl.h to flag the
presence of this feature.

Lastly - I don't see any libxl_device_channel_* ops added here, is it
intentional that it not be possible to dynamically add these things?


> +    switch (channel->type) {
> +        case LIBXL_CHANNEL_TYPE_NONE:
> +        case LIBXL_CHANNEL_TYPE_PTY:
> +            /* No path is needed */

How do I go about finding the PTY for a channel?

Ian.

  reply	other threads:[~2014-06-18 13:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16  9:49 [PATCH v2] implement libvirt-like 'channels' via PV consoles David Scott
2014-06-16  9:49 ` [PATCH v2 1/6] libxl: add a list of abstract 'channels' to the domain config David Scott
2014-06-18 13:27   ` Ian Campbell
2014-06-18 14:05     ` Dave Scott
2014-06-18 14:38       ` Ian Campbell
2014-06-16  9:49 ` [PATCH v2 2/6] xl: add support for channels David Scott
2014-06-16  9:49 ` [PATCH v2 3/6] libxl: implement channels via PV console rings David Scott
2014-06-18 13:31   ` Ian Campbell [this message]
2014-06-16  9:49 ` [PATCH v2 4/6] libxl: spawn a qemu to implement channels David Scott
2014-06-18 13:32   ` Ian Campbell
2014-06-16  9:49 ` [PATCH v2 5/6] Add a section in xl.cfg(5) describing 'channels' David Scott
2014-06-18 13:38   ` Ian Campbell
2014-06-16  9:49 ` [PATCH v2 6/6] Add a general description of the channel mechanism to docs/misc/ David Scott
2014-06-18 13:41   ` Ian Campbell
2014-06-18 14:37     ` Dave Scott
2014-06-18 14:43       ` Ian Campbell
2014-06-18 15:00         ` Dave Scott
2014-06-16 13:34 ` [PATCH v2] implement libvirt-like 'channels' via PV consoles Konrad Rzeszutek Wilk
2014-06-16 13:49   ` Dave Scott
2014-06-16 13:52     ` Konrad Rzeszutek Wilk
2014-06-18 13:43       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403098294.6568.9.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=dave.scott@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.