[Qemu-devel] [PATCH for 2.1] qemu-char: initialize out_lock

[Qemu-devel] [PATCH for 2.1] qemu-char: initialize out_lock

[Paolo Bonzini]

Otherwise, Windows fails with a deadlock.

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qemu-char.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qemu-char.c b/qemu-char.c
index 2e50a10..17bd360 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -94,6 +94,7 @@ static QTAILQ_HEAD(CharDriverStateHead, CharDriverState) chardevs =
 CharDriverState *qemu_chr_alloc(void)
 {
     CharDriverState *chr = g_malloc0(sizeof(CharDriverState));
+    qemu_mutex_init(&chr->chr_write_lock);
     return chr;
 }
 
-- 
1.9.3

Re: [Qemu-devel] [PATCH for 2.1] qemu-char: initialize out_lock

[Stefan Weil]

Am 25.06.2014 09:04, schrieb Paolo Bonzini:
> Otherwise, Windows fails with a deadlock.
>
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu-char.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 2e50a10..17bd360 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -94,6 +94,7 @@ static QTAILQ_HEAD(CharDriverStateHead, CharDriverState) chardevs =
>  CharDriverState *qemu_chr_alloc(void)
>  {
>      CharDriverState *chr = g_malloc0(sizeof(CharDriverState));
> +    qemu_mutex_init(&chr->chr_write_lock);
>      return chr;
>  }
>  


Thanks, this fixes the problem with QEMU for Windows.

Tested-by: Stefan Weil <sw@weilnetz.de>

Re: [Qemu-devel] [PATCH for 2.1] qemu-char: initialize out_lock

[Peter Maydell]

On 25 June 2014 08:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Otherwise, Windows fails with a deadlock.
>
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Applied to master (with s/out_lock/chr_write_lock/ in the subject);
thanks.

-- PMM