All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: sameo@linux.intel.com, linus.walleij@linaro.org,
	Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 10/12] mfd: aat2870-core: Stop using obsolte simple_strtoul()
Date: Wed,  2 Jul 2014 16:28:42 +0100	[thread overview]
Message-ID: <1404314924-23564-11-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1404314924-23564-1-git-send-email-lee.jones@linaro.org>

Soothes checkpatch warning:

    WARNING: simple_strtoul is obsolete, use kstrtoul instead
    #306: FILE: drivers/mfd/aat2870-core.c:306:
    +	addr = simple_strtoul(start, &start, 16);

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/aat2870-core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
index 14d9542..4e6e03d 100644
--- a/drivers/mfd/aat2870-core.c
+++ b/drivers/mfd/aat2870-core.c
@@ -303,7 +303,10 @@ static ssize_t aat2870_reg_write_file(struct file *file,
 	while (*start == ' ')
 		start++;
 
-	addr = simple_strtoul(start, &start, 16);
+	ret = kstrtoul(start, 16, &addr);
+	if (ret)
+		return ret;
+
 	if (addr >= AAT2870_REG_NUM) {
 		dev_err(aat2870->dev, "Invalid address, 0x%lx\n", addr);
 		return -EINVAL;
-- 
1.8.3.2


WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/12] mfd: aat2870-core: Stop using obsolte simple_strtoul()
Date: Wed,  2 Jul 2014 16:28:42 +0100	[thread overview]
Message-ID: <1404314924-23564-11-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1404314924-23564-1-git-send-email-lee.jones@linaro.org>

Soothes checkpatch warning:

    WARNING: simple_strtoul is obsolete, use kstrtoul instead
    #306: FILE: drivers/mfd/aat2870-core.c:306:
    +	addr = simple_strtoul(start, &start, 16);

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/aat2870-core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
index 14d9542..4e6e03d 100644
--- a/drivers/mfd/aat2870-core.c
+++ b/drivers/mfd/aat2870-core.c
@@ -303,7 +303,10 @@ static ssize_t aat2870_reg_write_file(struct file *file,
 	while (*start == ' ')
 		start++;
 
-	addr = simple_strtoul(start, &start, 16);
+	ret = kstrtoul(start, 16, &addr);
+	if (ret)
+		return ret;
+
 	if (addr >= AAT2870_REG_NUM) {
 		dev_err(aat2870->dev, "Invalid address, 0x%lx\n", addr);
 		return -EINVAL;
-- 
1.8.3.2

  parent reply	other threads:[~2014-07-02 15:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 15:28 [PATCH 01/12] mfd: Bunch of clean-ups and checkpatch fixes Lee Jones
2014-07-02 15:28 ` Lee Jones
2014-07-02 15:28 ` [PATCH 01/12] mfd: ab8500-core: Remove pointless else in if statement Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-04 19:54   ` Linus Walleij
2014-07-04 19:54     ` Linus Walleij
2014-07-02 15:28 ` [PATCH 02/12] mfd: ab8500-debugfs: Simplify invalid debugfs data checking Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-04 19:55   ` Linus Walleij
2014-07-04 19:55     ` Linus Walleij
2014-07-02 15:28 ` [PATCH 03/12] mfd: intel_soc_pmic: Rid compiler working for unused ACPI match table Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-02 15:28 ` [PATCH 04/12] mfd: stmpe: Rid data size incompatibility warn when building for 64bit Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-04 19:57   ` Linus Walleij
2014-07-04 19:57     ` Linus Walleij
2014-07-02 15:28 ` [PATCH 05/12] mfd: arizona: " Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-02 15:28 ` [PATCH 06/12] mfd: tps65910: " Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-02 15:28 ` [PATCH 07/12] mfd: 88pm805: msleep(1ms ~ 20ms) may not do what the caller intends Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-02 15:28 ` [PATCH 08/12] mfd: 88pm860x-core: Repair formatting issues Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-02 15:28 ` [PATCH 09/12] mfd: 88pm860x-i2c: Repair 'space before tab' warning Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-02 15:28 ` Lee Jones [this message]
2014-07-02 15:28   ` [PATCH 10/12] mfd: aat2870-core: Stop using obsolte simple_strtoul() Lee Jones
2014-07-02 15:28 ` [PATCH 11/12] mfd: ab3100-core: Correct code sytle problems Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-04 19:58   ` Linus Walleij
2014-07-04 19:58     ` Linus Walleij
2014-07-07 12:50     ` Lee Jones
2014-07-07 12:50       ` Lee Jones
2014-07-02 15:28 ` [PATCH 12/12] mfd: ab8500-core: Resolve code style issues Lee Jones
2014-07-02 15:28   ` Lee Jones
2014-07-04 19:58   ` Linus Walleij
2014-07-04 19:58     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404314924-23564-11-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.