From: Lee Jones <lee.jones@linaro.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: sameo@linux.intel.com, linus.walleij@linaro.org, Lee Jones <lee.jones@linaro.org> Subject: [PATCH 02/12] mfd: ab8500-debugfs: Simplify invalid debugfs data checking Date: Wed, 2 Jul 2014 16:28:34 +0100 [thread overview] Message-ID: <1404314924-23564-3-git-send-email-lee.jones@linaro.org> (raw) In-Reply-To: <1404314924-23564-1-git-send-email-lee.jones@linaro.org> Noticed during a coding review, if we reorganised the checking a little, we can rid the code of a pointless 'else'. Whilst looking for this particular code hunk I noticed another pointless 'else', which I've subsequently fixed in this patch. Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/ab8500-debugfs.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index e23fcba..f7f271c 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -2503,14 +2503,14 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file, if (err) return err; - if (user_trig_timer <= 255) { - trig_timer = (u8) user_trig_timer; - } else { - dev_err(dev, "debugfs error input: " - "should be beetween 0 to 255\n"); + if (user_trig_timer & ~0xFF) { + dev_err(dev, + "debugfs error input: should be beetween 0 to 255\n"); return -EINVAL; } + trig_timer = (u8) user_trig_timer; + return count; } @@ -2764,8 +2764,8 @@ static ssize_t show_irq(struct device *dev, irq_index = name - irq_first; if (irq_index >= num_irqs) return -EINVAL; - else - return sprintf(buf, "%u\n", irq_count[irq_index]); + + return sprintf(buf, "%u\n", irq_count[irq_index]); } static ssize_t ab8500_subscribe_write(struct file *file, -- 1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/12] mfd: ab8500-debugfs: Simplify invalid debugfs data checking Date: Wed, 2 Jul 2014 16:28:34 +0100 [thread overview] Message-ID: <1404314924-23564-3-git-send-email-lee.jones@linaro.org> (raw) In-Reply-To: <1404314924-23564-1-git-send-email-lee.jones@linaro.org> Noticed during a coding review, if we reorganised the checking a little, we can rid the code of a pointless 'else'. Whilst looking for this particular code hunk I noticed another pointless 'else', which I've subsequently fixed in this patch. Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/ab8500-debugfs.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index e23fcba..f7f271c 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -2503,14 +2503,14 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file, if (err) return err; - if (user_trig_timer <= 255) { - trig_timer = (u8) user_trig_timer; - } else { - dev_err(dev, "debugfs error input: " - "should be beetween 0 to 255\n"); + if (user_trig_timer & ~0xFF) { + dev_err(dev, + "debugfs error input: should be beetween 0 to 255\n"); return -EINVAL; } + trig_timer = (u8) user_trig_timer; + return count; } @@ -2764,8 +2764,8 @@ static ssize_t show_irq(struct device *dev, irq_index = name - irq_first; if (irq_index >= num_irqs) return -EINVAL; - else - return sprintf(buf, "%u\n", irq_count[irq_index]); + + return sprintf(buf, "%u\n", irq_count[irq_index]); } static ssize_t ab8500_subscribe_write(struct file *file, -- 1.8.3.2
next prev parent reply other threads:[~2014-07-02 15:32 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-02 15:28 [PATCH 01/12] mfd: Bunch of clean-ups and checkpatch fixes Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 01/12] mfd: ab8500-core: Remove pointless else in if statement Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-04 19:54 ` Linus Walleij 2014-07-04 19:54 ` Linus Walleij 2014-07-02 15:28 ` Lee Jones [this message] 2014-07-02 15:28 ` [PATCH 02/12] mfd: ab8500-debugfs: Simplify invalid debugfs data checking Lee Jones 2014-07-04 19:55 ` Linus Walleij 2014-07-04 19:55 ` Linus Walleij 2014-07-02 15:28 ` [PATCH 03/12] mfd: intel_soc_pmic: Rid compiler working for unused ACPI match table Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 04/12] mfd: stmpe: Rid data size incompatibility warn when building for 64bit Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-04 19:57 ` Linus Walleij 2014-07-04 19:57 ` Linus Walleij 2014-07-02 15:28 ` [PATCH 05/12] mfd: arizona: " Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 06/12] mfd: tps65910: " Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 07/12] mfd: 88pm805: msleep(1ms ~ 20ms) may not do what the caller intends Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 08/12] mfd: 88pm860x-core: Repair formatting issues Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 09/12] mfd: 88pm860x-i2c: Repair 'space before tab' warning Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 10/12] mfd: aat2870-core: Stop using obsolte simple_strtoul() Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-02 15:28 ` [PATCH 11/12] mfd: ab3100-core: Correct code sytle problems Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-04 19:58 ` Linus Walleij 2014-07-04 19:58 ` Linus Walleij 2014-07-07 12:50 ` Lee Jones 2014-07-07 12:50 ` Lee Jones 2014-07-02 15:28 ` [PATCH 12/12] mfd: ab8500-core: Resolve code style issues Lee Jones 2014-07-02 15:28 ` Lee Jones 2014-07-04 19:58 ` Linus Walleij 2014-07-04 19:58 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1404314924-23564-3-git-send-email-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.