All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com,
	sven@narfation.org, mathias.kretschmer@fokus.fraunhofer.de,
	Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCHv3 0/2] ath10k spectral scan support
Date: Wed, 23 Jul 2014 17:53:55 +0200	[thread overview]
Message-ID: <1406130837-10353-1-git-send-email-sw@simonwunderlich.de> (raw)

This is the third "PATCH" patchset iteration for the ath10k spectral
scan feature. It includes quite a few style fixes, the compile issues
were fixed when debugfs were disabled, and sending WMI commands after
a firmware crash should not happen any more. Thanks to Michal, Chun-Yeow
and Kalle for reviewing!

To view the samples, please have a look at the fft_eval tool [1] which
now supports both ath9k and ath10k formats.

The count issue is still open: Even when a count is specified, the
hardware seems to send endless samples. It seems to work most of the
time in VHT80 mode though, but in HT20 and HT40 the count value seems
to be ignored. To reproduce this, start hostapd with the desired
channel width and do:

echo 8 > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_count
echo manual > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan_ctl
echo trigger > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan_ctl
cat /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan0 >> /tmp/fft.dump

Repeating the last line and checking the filesize will easily show
whether ath10k still sends samples or not. We would expect 8 samples in
this configuration.

Please see the patches for more information on the changes.

Cheers,
    Simon

[1] https://github.com/simonwunderlich/FFT_eval

Simon Wunderlich (1):
  ath10k: add spectral scan feature

Sven Eckelmann (1):
  ath: Move spectral debugfs structs to shared header

 drivers/net/wireless/ath/ath10k/Kconfig    |   1 +
 drivers/net/wireless/ath/ath10k/Makefile   |   1 +
 drivers/net/wireless/ath/ath10k/core.c     |   7 +-
 drivers/net/wireless/ath/ath10k/core.h     |  10 +
 drivers/net/wireless/ath/ath10k/debug.c    |   3 +
 drivers/net/wireless/ath/ath10k/mac.c      |   7 +
 drivers/net/wireless/ath/ath10k/spectral.c | 557 +++++++++++++++++++++++++++++
 drivers/net/wireless/ath/ath10k/spectral.h |  82 +++++
 drivers/net/wireless/ath/ath10k/wmi.c      | 104 +++++-
 drivers/net/wireless/ath/ath10k/wmi.h      |  97 +++++
 drivers/net/wireless/ath/ath9k/spectral.h  |  71 +---
 drivers/net/wireless/ath/spectral_common.h | 113 ++++++
 12 files changed, 982 insertions(+), 71 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath10k/spectral.c
 create mode 100644 drivers/net/wireless/ath/ath10k/spectral.h
 create mode 100644 drivers/net/wireless/ath/spectral_common.h

-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Simon Wunderlich <sw@simonwunderlich.de>
To: ath10k@lists.infradead.org
Cc: mathias.kretschmer@fokus.fraunhofer.de, kgiori@qca.qualcomm.com,
	linux-wireless@vger.kernel.org, sven@narfation.org,
	Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCHv3 0/2] ath10k spectral scan support
Date: Wed, 23 Jul 2014 17:53:55 +0200	[thread overview]
Message-ID: <1406130837-10353-1-git-send-email-sw@simonwunderlich.de> (raw)

This is the third "PATCH" patchset iteration for the ath10k spectral
scan feature. It includes quite a few style fixes, the compile issues
were fixed when debugfs were disabled, and sending WMI commands after
a firmware crash should not happen any more. Thanks to Michal, Chun-Yeow
and Kalle for reviewing!

To view the samples, please have a look at the fft_eval tool [1] which
now supports both ath9k and ath10k formats.

The count issue is still open: Even when a count is specified, the
hardware seems to send endless samples. It seems to work most of the
time in VHT80 mode though, but in HT20 and HT40 the count value seems
to be ignored. To reproduce this, start hostapd with the desired
channel width and do:

echo 8 > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_count
echo manual > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan_ctl
echo trigger > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan_ctl
cat /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan0 >> /tmp/fft.dump

Repeating the last line and checking the filesize will easily show
whether ath10k still sends samples or not. We would expect 8 samples in
this configuration.

Please see the patches for more information on the changes.

Cheers,
    Simon

[1] https://github.com/simonwunderlich/FFT_eval

Simon Wunderlich (1):
  ath10k: add spectral scan feature

Sven Eckelmann (1):
  ath: Move spectral debugfs structs to shared header

 drivers/net/wireless/ath/ath10k/Kconfig    |   1 +
 drivers/net/wireless/ath/ath10k/Makefile   |   1 +
 drivers/net/wireless/ath/ath10k/core.c     |   7 +-
 drivers/net/wireless/ath/ath10k/core.h     |  10 +
 drivers/net/wireless/ath/ath10k/debug.c    |   3 +
 drivers/net/wireless/ath/ath10k/mac.c      |   7 +
 drivers/net/wireless/ath/ath10k/spectral.c | 557 +++++++++++++++++++++++++++++
 drivers/net/wireless/ath/ath10k/spectral.h |  82 +++++
 drivers/net/wireless/ath/ath10k/wmi.c      | 104 +++++-
 drivers/net/wireless/ath/ath10k/wmi.h      |  97 +++++
 drivers/net/wireless/ath/ath9k/spectral.h  |  71 +---
 drivers/net/wireless/ath/spectral_common.h | 113 ++++++
 12 files changed, 982 insertions(+), 71 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath10k/spectral.c
 create mode 100644 drivers/net/wireless/ath/ath10k/spectral.h
 create mode 100644 drivers/net/wireless/ath/spectral_common.h

-- 
1.9.1


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

             reply	other threads:[~2014-07-23 15:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 15:53 Simon Wunderlich [this message]
2014-07-23 15:53 ` [PATCHv3 0/2] ath10k spectral scan support Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 1/2] ath: Move spectral debugfs structs to shared header Simon Wunderlich
2014-07-23 15:53   ` Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 15:53   ` Simon Wunderlich
2014-07-23 17:14 ` [PATCHv3 0/2] ath10k spectral scan support Kalle Valo
2014-07-23 17:14   ` Kalle Valo
2014-07-23 17:32   ` [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 17:32     ` Simon Wunderlich
2014-07-24  9:29     ` Kalle Valo
2014-07-24  9:29       ` Kalle Valo
2014-07-24  9:34       ` Michal Kazior
2014-07-24  9:34         ` Michal Kazior
2014-07-24  9:45         ` Kalle Valo
2014-07-24  9:45           ` Kalle Valo
2014-07-24  9:36       ` Simon Wunderlich
2014-07-24  9:36         ` Simon Wunderlich
2014-07-24  9:40         ` Michal Kazior
2014-07-24  9:40           ` Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406130837-10353-1-git-send-email-sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=ath10k@lists.infradead.org \
    --cc=kgiori@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mathias.kretschmer@fokus.fraunhofer.de \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.