From: Michal Kazior <michal.kazior@tieto.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
"Giori, Kathy" <kgiori@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Sven Eckelmann <sven@narfation.org>
Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature
Date: Thu, 24 Jul 2014 11:40:39 +0200 [thread overview]
Message-ID: <CA+BoTQn13tktL9eZi8UD+=WR8fS+FFHML2ab8huvb1QdS49tiQ@mail.gmail.com> (raw)
In-Reply-To: <201407241136.08090.sw@simonwunderlich.de>
On 24 July 2014 11:36, Simon Wunderlich <sw@simonwunderlich.de> wrote:
>> > @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar)
>> >
>> > else
>> >
>> > ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
>> >
>> > - INIT_LIST_HEAD(&ar->arvifs);
>> > -
>> >
>> > if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
>> >
>> > ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
>> >
>> > ar->hw_params.name,
>> >
>> > @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv,
>> > struct device *dev,
>> >
>> > INIT_WORK(&ar->register_work, ath10k_core_register_work);
>> > INIT_WORK(&ar->restart_work, ath10k_core_restart);
>> >
>> > + INIT_LIST_HEAD(&ar->arvifs);
>>
>> I'm a bit suspicious about this, why is it needed?
>
> ath10k_spectral_init() clears the spectral_enabled bit for each vif, and
> therefore needs the list to be initialized ... it is also called on firmware
> crash by ath10k_halt, where checking the list is more useful.
You don't really need to clear arvif->spectral_enabled on crash.
arvif's are re-inserted by mac80211 via ath10k_add_interface which
uses memset() to clear everything before adding to ar->arvifs.
Michał
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
"Giori, Kathy" <kgiori@qca.qualcomm.com>,
Sven Eckelmann <sven@narfation.org>
Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature
Date: Thu, 24 Jul 2014 11:40:39 +0200 [thread overview]
Message-ID: <CA+BoTQn13tktL9eZi8UD+=WR8fS+FFHML2ab8huvb1QdS49tiQ@mail.gmail.com> (raw)
In-Reply-To: <201407241136.08090.sw@simonwunderlich.de>
On 24 July 2014 11:36, Simon Wunderlich <sw@simonwunderlich.de> wrote:
>> > @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar)
>> >
>> > else
>> >
>> > ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
>> >
>> > - INIT_LIST_HEAD(&ar->arvifs);
>> > -
>> >
>> > if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
>> >
>> > ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
>> >
>> > ar->hw_params.name,
>> >
>> > @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv,
>> > struct device *dev,
>> >
>> > INIT_WORK(&ar->register_work, ath10k_core_register_work);
>> > INIT_WORK(&ar->restart_work, ath10k_core_restart);
>> >
>> > + INIT_LIST_HEAD(&ar->arvifs);
>>
>> I'm a bit suspicious about this, why is it needed?
>
> ath10k_spectral_init() clears the spectral_enabled bit for each vif, and
> therefore needs the list to be initialized ... it is also called on firmware
> crash by ath10k_halt, where checking the list is more useful.
You don't really need to clear arvif->spectral_enabled on crash.
arvif's are re-inserted by mac80211 via ath10k_add_interface which
uses memset() to clear everything before adding to ar->arvifs.
Michał
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-07-24 9:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 15:53 [PATCHv3 0/2] ath10k spectral scan support Simon Wunderlich
2014-07-23 15:53 ` Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 1/2] ath: Move spectral debugfs structs to shared header Simon Wunderlich
2014-07-23 15:53 ` Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 15:53 ` Simon Wunderlich
2014-07-23 17:14 ` [PATCHv3 0/2] ath10k spectral scan support Kalle Valo
2014-07-23 17:14 ` Kalle Valo
2014-07-23 17:32 ` [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 17:32 ` Simon Wunderlich
2014-07-24 9:29 ` Kalle Valo
2014-07-24 9:29 ` Kalle Valo
2014-07-24 9:34 ` Michal Kazior
2014-07-24 9:34 ` Michal Kazior
2014-07-24 9:45 ` Kalle Valo
2014-07-24 9:45 ` Kalle Valo
2014-07-24 9:36 ` Simon Wunderlich
2014-07-24 9:36 ` Simon Wunderlich
2014-07-24 9:40 ` Michal Kazior [this message]
2014-07-24 9:40 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+BoTQn13tktL9eZi8UD+=WR8fS+FFHML2ab8huvb1QdS49tiQ@mail.gmail.com' \
--to=michal.kazior@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=kgiori@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.