All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Hua <sdu.liu@huawei.com>
To: <Marc.Zyngier@arm.com>, <will.deacon@arm.com>
Cc: <nicolas.pitre@linaro.org>, <linux@arm.linux.org.uk>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <peifeiyue@huawei.com>,
	<liusdu@126.com>, <wangnan0@huawei.com>, <ebiederm@xmission.com>,
	Liu Hua <sdu.liu@huawei.com>
Subject: [PATCH V2 1/1] GIC: introduce method to deactive interupts
Date: Mon, 4 Aug 2014 12:17:40 +0800	[thread overview]
Message-ID: <1407125860-37718-2-git-send-email-sdu.liu@huawei.com> (raw)
In-Reply-To: <1407125860-37718-1-git-send-email-sdu.liu@huawei.com>

When using kdump on ARM platform, if kernel panics in interrupt handler
(maybe PPI), the capture kernel can not recive certain interrupt, and 
fails to boot.

On this situation, We have read register GICC_IAR. But we have no chance
to write relative bit to register GICC_EOIR (kernel paniced before). So
the state of this type interrupt remains active. And that makes gic not
deliver this type interrupt to cpu interface.

So we should not assume that all interrut states of GIC are inactive when
kernel inittailize the GIC. This patch will identify these type interrupts
and deactive them

Signed-off-by: Liu Hua <sdu.liu@huawei.com>
---
 drivers/irqchip/irq-gic.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index b2648fc..7708df1 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -351,12 +351,37 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
 	return mask;
 }
 
+void gic_eois(u32 active, int irq_off, void __iomem *cpu_base)
+{
+	int bit = -1;
+
+	for_each_set_bit(bit, (unsigned long *)&active, 32)
+		writel_relaxed(bit + irq_off, cpu_base + GIC_CPU_EOI);
+}
+
+void gic_dist_clear_active(void __iomem *dist_base,
+			void __iomem *cpu_base, int gic_irqs)
+{
+	int irq, offset;
+	u32 active;
+
+	for (irq = 0; irq < gic_irqs; irq += 32) {
+		offset = GIC_DIST_ACTIVE_SET + irq * 4 / 32;
+		active = readl_relaxed(dist_base + offset);
+		if (!active)
+			continue;
+		gic_eois(active, irq, cpu_base);
+	}
+}
+
+
 static void __init gic_dist_init(struct gic_chip_data *gic)
 {
 	unsigned int i;
 	u32 cpumask;
 	unsigned int gic_irqs = gic->gic_irqs;
 	void __iomem *base = gic_data_dist_base(gic);
+	void __iomem *cpu_base = gic_data_cpu_base(gic);
 
 	writel_relaxed(0, base + GIC_DIST_CTRL);
 
@@ -371,6 +396,7 @@ static void __init gic_dist_init(struct gic_chip_data *gic)
 
 	gic_dist_config(base, gic_irqs, NULL);
 
+	gic_dist_clear_active(base, cpu_base, gic_irqs);
 	writel_relaxed(1, base + GIC_DIST_CTRL);
 }
 
-- 
1.9.0


WARNING: multiple messages have this Message-ID (diff)
From: sdu.liu@huawei.com (Liu Hua)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/1] GIC: introduce method to deactive interupts
Date: Mon, 4 Aug 2014 12:17:40 +0800	[thread overview]
Message-ID: <1407125860-37718-2-git-send-email-sdu.liu@huawei.com> (raw)
In-Reply-To: <1407125860-37718-1-git-send-email-sdu.liu@huawei.com>

When using kdump on ARM platform, if kernel panics in interrupt handler
(maybe PPI), the capture kernel can not recive certain interrupt, and 
fails to boot.

On this situation, We have read register GICC_IAR. But we have no chance
to write relative bit to register GICC_EOIR (kernel paniced before). So
the state of this type interrupt remains active. And that makes gic not
deliver this type interrupt to cpu interface.

So we should not assume that all interrut states of GIC are inactive when
kernel inittailize the GIC. This patch will identify these type interrupts
and deactive them

Signed-off-by: Liu Hua <sdu.liu@huawei.com>
---
 drivers/irqchip/irq-gic.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index b2648fc..7708df1 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -351,12 +351,37 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
 	return mask;
 }
 
+void gic_eois(u32 active, int irq_off, void __iomem *cpu_base)
+{
+	int bit = -1;
+
+	for_each_set_bit(bit, (unsigned long *)&active, 32)
+		writel_relaxed(bit + irq_off, cpu_base + GIC_CPU_EOI);
+}
+
+void gic_dist_clear_active(void __iomem *dist_base,
+			void __iomem *cpu_base, int gic_irqs)
+{
+	int irq, offset;
+	u32 active;
+
+	for (irq = 0; irq < gic_irqs; irq += 32) {
+		offset = GIC_DIST_ACTIVE_SET + irq * 4 / 32;
+		active = readl_relaxed(dist_base + offset);
+		if (!active)
+			continue;
+		gic_eois(active, irq, cpu_base);
+	}
+}
+
+
 static void __init gic_dist_init(struct gic_chip_data *gic)
 {
 	unsigned int i;
 	u32 cpumask;
 	unsigned int gic_irqs = gic->gic_irqs;
 	void __iomem *base = gic_data_dist_base(gic);
+	void __iomem *cpu_base = gic_data_cpu_base(gic);
 
 	writel_relaxed(0, base + GIC_DIST_CTRL);
 
@@ -371,6 +396,7 @@ static void __init gic_dist_init(struct gic_chip_data *gic)
 
 	gic_dist_config(base, gic_irqs, NULL);
 
+	gic_dist_clear_active(base, cpu_base, gic_irqs);
 	writel_relaxed(1, base + GIC_DIST_CTRL);
 }
 
-- 
1.9.0

  reply	other threads:[~2014-08-04  4:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  4:17 [PATCH V2 0/1] irqchip: GIC: check and clear GIC interupt active state Liu Hua
2014-08-04  4:17 ` Liu Hua
2014-08-04  4:17 ` Liu Hua [this message]
2014-08-04  4:17   ` [PATCH V2 1/1] GIC: introduce method to deactive interupts Liu Hua
2014-08-04  9:43   ` Marc Zyngier
2014-08-04  9:43     ` Marc Zyngier
2014-08-06  8:43     ` Liu hua
2014-08-06  8:43       ` Liu hua
2014-08-06  9:46       ` Marc Zyngier
2014-08-06  9:46         ` Marc Zyngier
2014-08-06 12:18         ` Liu hua
2014-08-06 12:18           ` Liu hua
2014-08-06 16:01           ` Marc Zyngier
2014-08-06 16:01             ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407125860-37718-2-git-send-email-sdu.liu@huawei.com \
    --to=sdu.liu@huawei.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liusdu@126.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=peifeiyue@huawei.com \
    --cc=wangnan0@huawei.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.