[PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support
@ 2014-08-04  9:45 ` Jingchang Lu
  0 siblings, 0 replies; 6+ messages in thread
From: Jingchang Lu @ 2014-08-04  9:45 UTC (permalink / raw)
  To: mturquette; +Cc: linux-kernel, linux-arm-kernel, Jingchang Lu

Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
---
 drivers/clk/Kconfig           | 7 ++++---
 drivers/clk/clk-ppc-corenet.c | 5 +++++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index cfd3af7..8784704 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN
 	  FPGAs. It is commonly used in Analog Devices' reference designs.
 
 config CLK_PPC_CORENET
-	bool "Clock driver for PowerPC corenet platforms"
-	depends on PPC_E500MC && OF
+	bool "Clock driver for PowerPC corenet and compatible ARM-based platforms"
+	depends on (PPC_E500MC || ARM) && OF
 	---help---
 	  This adds the clock driver support for Freescale PowerPC corenet
-	  platforms using common clock framework.
+	  platforms and compatible Freescale ARM based platforms using common
+	  clock framework.
 
 config COMMON_CLK_XGENE
 	bool "Clock driver for APM XGene SoC"
diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
index 8e58edf..7692cac 100644
--- a/drivers/clk/clk-ppc-corenet.c
+++ b/drivers/clk/clk-ppc-corenet.c
@@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void)
 	return platform_driver_register(&ppc_corenet_clk_driver);
 }
 subsys_initcall(ppc_corenet_clk_init);
+
+CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init);
+CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init);
+CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init);
+CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init);
-- 
1.8.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support
@ 2014-08-04  9:45 ` Jingchang Lu
  0 siblings, 0 replies; 6+ messages in thread
From: Jingchang Lu @ 2014-08-04  9:45 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
---
 drivers/clk/Kconfig           | 7 ++++---
 drivers/clk/clk-ppc-corenet.c | 5 +++++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index cfd3af7..8784704 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN
 	  FPGAs. It is commonly used in Analog Devices' reference designs.
 
 config CLK_PPC_CORENET
-	bool "Clock driver for PowerPC corenet platforms"
-	depends on PPC_E500MC && OF
+	bool "Clock driver for PowerPC corenet and compatible ARM-based platforms"
+	depends on (PPC_E500MC || ARM) && OF
 	---help---
 	  This adds the clock driver support for Freescale PowerPC corenet
-	  platforms using common clock framework.
+	  platforms and compatible Freescale ARM based platforms using common
+	  clock framework.
 
 config COMMON_CLK_XGENE
 	bool "Clock driver for APM XGene SoC"
diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
index 8e58edf..7692cac 100644
--- a/drivers/clk/clk-ppc-corenet.c
+++ b/drivers/clk/clk-ppc-corenet.c
@@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void)
 	return platform_driver_register(&ppc_corenet_clk_driver);
 }
 subsys_initcall(ppc_corenet_clk_init);
+
+CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init);
+CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init);
+CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init);
+CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init);
-- 
1.8.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support
  2014-08-04  9:45 ` Jingchang Lu
@ 2014-08-21 11:28   ` Diana Craciun
  -1 siblings, 0 replies; 6+ messages in thread
From: Diana Craciun @ 2014-08-21 11:28 UTC (permalink / raw)
  To: Jingchang Lu; +Cc: mturquette, linux-kernel, linux-arm-kernel

I think you should cc also linuxppc-dev as it touches common code.

On 08/04/2014 12:45 PM, Jingchang Lu wrote:
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> ---
>   drivers/clk/Kconfig           | 7 ++++---
>   drivers/clk/clk-ppc-corenet.c | 5 +++++
>   2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index cfd3af7..8784704 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN
>   	  FPGAs. It is commonly used in Analog Devices' reference designs.
>   
>   config CLK_PPC_CORENET
> -	bool "Clock driver for PowerPC corenet platforms"
> -	depends on PPC_E500MC && OF
> +	bool "Clock driver for PowerPC corenet and compatible ARM-based platforms"
> +	depends on (PPC_E500MC || ARM) && OF
>   	---help---
>   	  This adds the clock driver support for Freescale PowerPC corenet
> -	  platforms using common clock framework.
> +	  platforms and compatible Freescale ARM based platforms using common
> +	  clock framework.
>   
>   config COMMON_CLK_XGENE
>   	bool "Clock driver for APM XGene SoC"
> diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c

Can't this file be renamed in order to reflect that is common between 
PPC and ARM? It is strange to be named ppc_xxx and to be used by ARM kernel.

> index 8e58edf..7692cac 100644
> --- a/drivers/clk/clk-ppc-corenet.c
> +++ b/drivers/clk/clk-ppc-corenet.c
> @@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void)
>   	return platform_driver_register(&ppc_corenet_clk_driver);
>   }
>   subsys_initcall(ppc_corenet_clk_init);
> +
> +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init);
> +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init);
> +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init);
> +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init);

Diana


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support
@ 2014-08-21 11:28   ` Diana Craciun
  0 siblings, 0 replies; 6+ messages in thread
From: Diana Craciun @ 2014-08-21 11:28 UTC (permalink / raw)
  To: linux-arm-kernel

I think you should cc also linuxppc-dev as it touches common code.

On 08/04/2014 12:45 PM, Jingchang Lu wrote:
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> ---
>   drivers/clk/Kconfig           | 7 ++++---
>   drivers/clk/clk-ppc-corenet.c | 5 +++++
>   2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index cfd3af7..8784704 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN
>   	  FPGAs. It is commonly used in Analog Devices' reference designs.
>   
>   config CLK_PPC_CORENET
> -	bool "Clock driver for PowerPC corenet platforms"
> -	depends on PPC_E500MC && OF
> +	bool "Clock driver for PowerPC corenet and compatible ARM-based platforms"
> +	depends on (PPC_E500MC || ARM) && OF
>   	---help---
>   	  This adds the clock driver support for Freescale PowerPC corenet
> -	  platforms using common clock framework.
> +	  platforms and compatible Freescale ARM based platforms using common
> +	  clock framework.
>   
>   config COMMON_CLK_XGENE
>   	bool "Clock driver for APM XGene SoC"
> diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c

Can't this file be renamed in order to reflect that is common between 
PPC and ARM? It is strange to be named ppc_xxx and to be used by ARM kernel.

> index 8e58edf..7692cac 100644
> --- a/drivers/clk/clk-ppc-corenet.c
> +++ b/drivers/clk/clk-ppc-corenet.c
> @@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void)
>   	return platform_driver_register(&ppc_corenet_clk_driver);
>   }
>   subsys_initcall(ppc_corenet_clk_init);
> +
> +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init);
> +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init);
> +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init);
> +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init);

Diana

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support
  2014-08-21 11:28   ` Diana Craciun
@ 2014-08-22 10:14     ` Jingchang Lu
  -1 siblings, 0 replies; 6+ messages in thread
From: Jingchang Lu @ 2014-08-22 10:14 UTC (permalink / raw)
  To: Diana.Craciun; +Cc: mturquette, linux-kernel, linux-arm-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 664 bytes --]

>-----Original Message-----
>From: Diana Craciun [mailto:diana.craciun@freescale.com]
>Sent: Thursday, August 21, 2014 7:28 PM
>To: Lu Jingchang-B35083
>Cc: mturquette@linaro.org; linux-kernel@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org
>Subject: Re: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms
>CLK_OF_DECLARE support
>
>I think you should cc also linuxppc-dev as it touches common code.
>
Ok, thanks, I will resend the patch and cc linuppc-dev.



Best Regards,
Jingchang


ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support
@ 2014-08-22 10:14     ` Jingchang Lu
  0 siblings, 0 replies; 6+ messages in thread
From: Jingchang Lu @ 2014-08-22 10:14 UTC (permalink / raw)
  To: linux-arm-kernel

>-----Original Message-----
>From: Diana Craciun [mailto:diana.craciun at freescale.com]
>Sent: Thursday, August 21, 2014 7:28 PM
>To: Lu Jingchang-B35083
>Cc: mturquette at linaro.org; linux-kernel at vger.kernel.org; linux-arm-
>kernel at lists.infradead.org
>Subject: Re: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms
>CLK_OF_DECLARE support
>
>I think you should cc also linuxppc-dev as it touches common code.
>
Ok, thanks, I will resend the patch and cc linuppc-dev.



Best Regards,
Jingchang

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-08-22 10:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-04  9:45 [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support Jingchang Lu
2014-08-04  9:45 ` Jingchang Lu
2014-08-21 11:28 ` Diana Craciun
2014-08-21 11:28   ` Diana Craciun
2014-08-22 10:14   ` Jingchang Lu
2014-08-22 10:14     ` Jingchang Lu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.