[PATCH 1/2] drm/ast: open key before detect chips

[PATCH 1/2] drm/ast: open key before detect chips

[Y.C. Chen]

From: "Y.C. Chen" <yc_chen@aspeedtech.com>

Some config settings like 3rd TX chips will not get correctly
if the extended reg is protected

Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
---
 drivers/gpu/drm/ast/ast_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index a2cc6be..b027e33 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -67,6 +67,7 @@ static int ast_detect_chip(struct drm_device *dev)
 {
 	struct ast_private *ast = dev->dev_private;
 	uint32_t data, jreg;
+	ast_open_key(ast);
 
 	if (dev->pdev->device == PCI_CHIP_AST1180) {
 		ast->chip = AST1100;
-- 
1.8.3.1

[PATCH 2/2] drm/ast: AST2000 cannot be detected correctly

[Y.C. Chen]

From: "Y.C. Chen" <yc_chen@aspeedtech.com>

Type error and cause AST2000 cannot be detected correctly

Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
---
 drivers/gpu/drm/ast/ast_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index b027e33..b792194 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -105,7 +105,7 @@ static int ast_detect_chip(struct drm_device *dev)
 			}
 			ast->vga2_clone = false;
 		} else {
-			ast->chip = 2000;
+			ast->chip = AST2000;
 			DRM_INFO("AST 2000 detected\n");
 		}
 	}
-- 
1.8.3.1

Re: [PATCH 2/2] drm/ast: AST2000 cannot be detected correctly

[Egbert Eich]

Y.C. Chen writes:
 > From: "Y.C. Chen" <yc_chen@aspeedtech.com>
 > 
 > Type error and cause AST2000 cannot be detected correctly
 > 
 > Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
 > ---
 >  drivers/gpu/drm/ast/ast_main.c | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)
 > 
 > diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
 > index b027e33..b792194 100644
 > --- a/drivers/gpu/drm/ast/ast_main.c
 > +++ b/drivers/gpu/drm/ast/ast_main.c
 > @@ -105,7 +105,7 @@ static int ast_detect_chip(struct drm_device *dev)
 >  			}
 >  			ast->vga2_clone = false;
 >  		} else {
 > -			ast->chip = 2000;
 > +			ast->chip = AST2000;
 >  			DRM_INFO("AST 2000 detected\n");
 >  		}
 >  	}
 > -- 
 > 1.8.3.1
 > 

Reviewed-by: Egbert Eich <eich@suse.de>

Re: [PATCH 1/2] drm/ast: open key before detect chips

[Egbert Eich]

Y.C. Chen writes:
 > From: "Y.C. Chen" <yc_chen@aspeedtech.com>
 > 
 > Some config settings like 3rd TX chips will not get correctly
 > if the extended reg is protected
 > 
 > Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
 > ---
 >  drivers/gpu/drm/ast/ast_main.c | 1 +
 >  1 file changed, 1 insertion(+)
 > 
 > diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
 > index a2cc6be..b027e33 100644
 > --- a/drivers/gpu/drm/ast/ast_main.c
 > +++ b/drivers/gpu/drm/ast/ast_main.c
 > @@ -67,6 +67,7 @@ static int ast_detect_chip(struct drm_device *dev)
 >  {
 >  	struct ast_private *ast = dev->dev_private;
 >  	uint32_t data, jreg;
 > +	ast_open_key(ast);
 >  
 >  	if (dev->pdev->device == PCI_CHIP_AST1180) {
 >  		ast->chip = AST1100;
 > -- 
 > 1.8.3.1
 > 

Reviewed-by: Egbert Eich <eich@suse.de>