All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/5] ath9k patches
@ 2014-10-01  3:04 Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 1/5] ath: Add support for tracing Sujith Manoharan
                   ` (4 more replies)
  0 siblings, 5 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-10-01  3:04 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

For -next.

Sujith Manoharan (5):
  ath: Add support for tracing
  ath9k: Print RoC expiration
  ath9k: Check pending frames properly
  ath9k: Fix pending frame check
  ath9k: Remove duplicate code

 drivers/net/wireless/ath/Kconfig         |  8 ++++
 drivers/net/wireless/ath/Makefile        |  4 ++
 drivers/net/wireless/ath/ath.h           |  1 +
 drivers/net/wireless/ath/ath9k/channel.c |  7 ++++
 drivers/net/wireless/ath/ath9k/main.c    | 18 +++-----
 drivers/net/wireless/ath/main.c          |  3 ++
 drivers/net/wireless/ath/trace.c         | 20 +++++++++
 drivers/net/wireless/ath/trace.h         | 71 ++++++++++++++++++++++++++++++++
 8 files changed, 119 insertions(+), 13 deletions(-)
 create mode 100644 drivers/net/wireless/ath/trace.c
 create mode 100644 drivers/net/wireless/ath/trace.h

-- 
2.1.1


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 1/5] ath: Add support for tracing
  2014-10-01  3:04 [PATCH 0/5] ath9k patches Sujith Manoharan
@ 2014-10-01  3:04 ` Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 2/5] ath9k: Print RoC expiration Sujith Manoharan
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-10-01  3:04 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/Kconfig  |  8 +++++
 drivers/net/wireless/ath/Makefile |  4 +++
 drivers/net/wireless/ath/ath.h    |  1 +
 drivers/net/wireless/ath/main.c   |  3 ++
 drivers/net/wireless/ath/trace.c  | 20 +++++++++++
 drivers/net/wireless/ath/trace.h  | 71 +++++++++++++++++++++++++++++++++++++++
 6 files changed, 107 insertions(+)
 create mode 100644 drivers/net/wireless/ath/trace.c
 create mode 100644 drivers/net/wireless/ath/trace.h

diff --git a/drivers/net/wireless/ath/Kconfig b/drivers/net/wireless/ath/Kconfig
index c63d115..ce78260 100644
--- a/drivers/net/wireless/ath/Kconfig
+++ b/drivers/net/wireless/ath/Kconfig
@@ -25,6 +25,14 @@ config ATH_DEBUG
 	  Say Y, if you want to debug atheros wireless drivers.
 	  Right now only ath9k makes use of this.
 
+config ATH_TRACEPOINTS
+       bool "Atheros wireless tracing"
+       depends on ATH_DEBUG
+       depends on EVENT_TRACING
+       ---help---
+         This option enables tracepoints for atheros wireless drivers.
+	 Currently, ath9k makes use of this facility.
+
 config ATH_REG_DYNAMIC_USER_REG_HINTS
 	bool "Atheros dynamic user regulatory hints"
 	depends on CFG80211_CERTIFICATION_ONUS
diff --git a/drivers/net/wireless/ath/Makefile b/drivers/net/wireless/ath/Makefile
index 7d023b0..89f8d59 100644
--- a/drivers/net/wireless/ath/Makefile
+++ b/drivers/net/wireless/ath/Makefile
@@ -17,4 +17,8 @@ ath-objs :=	main.o \
 		dfs_pri_detector.o
 
 ath-$(CONFIG_ATH_DEBUG) += debug.o
+ath-$(CONFIG_ATH_TRACEPOINTS) += trace.o
+
 ccflags-y += -D__CHECK_ENDIAN__
+
+CFLAGS_trace.o := -I$(src)
diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
index a3b6e27..e5ba6fa 100644
--- a/drivers/net/wireless/ath/ath.h
+++ b/drivers/net/wireless/ath/ath.h
@@ -268,6 +268,7 @@ enum ATH_DEBUG {
 };
 
 #define ATH_DBG_DEFAULT (ATH_DBG_FATAL)
+#define ATH_DBG_MAX_LEN 512
 
 #ifdef CONFIG_ATH_DEBUG
 
diff --git a/drivers/net/wireless/ath/main.c b/drivers/net/wireless/ath/main.c
index 8b0ac14..83f47af 100644
--- a/drivers/net/wireless/ath/main.c
+++ b/drivers/net/wireless/ath/main.c
@@ -20,6 +20,7 @@
 #include <linux/module.h>
 
 #include "ath.h"
+#include "trace.h"
 
 MODULE_AUTHOR("Atheros Communications");
 MODULE_DESCRIPTION("Shared library for Atheros wireless LAN cards.");
@@ -84,6 +85,8 @@ void ath_printk(const char *level, const struct ath_common* common,
 	else
 		printk("%sath: %pV", level, &vaf);
 
+	trace_ath_log(common->hw->wiphy, &vaf);
+
 	va_end(args);
 }
 EXPORT_SYMBOL(ath_printk);
diff --git a/drivers/net/wireless/ath/trace.c b/drivers/net/wireless/ath/trace.c
new file mode 100644
index 0000000..18fb3a0
--- /dev/null
+++ b/drivers/net/wireless/ath/trace.c
@@ -0,0 +1,20 @@
+/*
+ * Copyright (c) 2014 Qualcomm Atheros, Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include <linux/module.h>
+
+#define CREATE_TRACE_POINTS
+#include "trace.h"
diff --git a/drivers/net/wireless/ath/trace.h b/drivers/net/wireless/ath/trace.h
new file mode 100644
index 0000000..ba71164
--- /dev/null
+++ b/drivers/net/wireless/ath/trace.h
@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) 2014 Qualcomm Atheros, Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#if !defined(_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_H
+
+#include <linux/tracepoint.h>
+#include "ath.h"
+
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM ath
+
+#if !defined(CONFIG_ATH_TRACEPOINTS)
+
+#undef TRACE_EVENT
+#define TRACE_EVENT(name, proto, ...) static inline void trace_ ## name(proto) {}
+
+#endif /* CONFIG_ATH_TRACEPOINTS */
+
+TRACE_EVENT(ath_log,
+
+	    TP_PROTO(struct wiphy *wiphy,
+		     struct va_format *vaf),
+
+	    TP_ARGS(wiphy, vaf),
+
+	    TP_STRUCT__entry(
+		    __string(device, wiphy_name(wiphy))
+		    __string(driver, KBUILD_MODNAME)
+		    __dynamic_array(char, msg, ATH_DBG_MAX_LEN)
+	    ),
+
+	    TP_fast_assign(
+		    __assign_str(device, wiphy_name(wiphy));
+		    __assign_str(driver, KBUILD_MODNAME);
+		    WARN_ON_ONCE(vsnprintf(__get_dynamic_array(msg),
+					   ATH_DBG_MAX_LEN,
+					   vaf->fmt,
+					   *vaf->va) >= ATH_DBG_MAX_LEN);
+	    ),
+
+	    TP_printk(
+		    "%s %s %s",
+		    __get_str(driver),
+		    __get_str(device),
+		    __get_str(msg)
+	    )
+);
+
+#endif /* _TRACE_H || TRACE_HEADER_MULTI_READ */
+
+#undef TRACE_INCLUDE_PATH
+#define TRACE_INCLUDE_PATH .
+#undef TRACE_INCLUDE_FILE
+#define TRACE_INCLUDE_FILE trace
+
+/* This part must be outside protection */
+#include <trace/define_trace.h>
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/5] ath9k: Print RoC expiration
  2014-10-01  3:04 [PATCH 0/5] ath9k patches Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 1/5] ath: Add support for tracing Sujith Manoharan
@ 2014-10-01  3:04 ` Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 3/5] ath9k: Check pending frames properly Sujith Manoharan
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-10-01  3:04 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/channel.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c
index b93f83c..d088f06 100644
--- a/drivers/net/wireless/ath/ath9k/channel.c
+++ b/drivers/net/wireless/ath/ath9k/channel.c
@@ -761,6 +761,13 @@ void ath_offchannel_next(struct ath_softc *sc)
 
 void ath_roc_complete(struct ath_softc *sc, bool abort)
 {
+	struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+
+	if (abort)
+		ath_dbg(common, CHAN_CTX, "RoC aborted\n");
+	else
+		ath_dbg(common, CHAN_CTX, "RoC expired\n");
+
 	sc->offchannel.roc_vif = NULL;
 	sc->offchannel.roc_chan = NULL;
 	if (!abort)
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 3/5] ath9k: Check pending frames properly
  2014-10-01  3:04 [PATCH 0/5] ath9k patches Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 1/5] ath: Add support for tracing Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 2/5] ath9k: Print RoC expiration Sujith Manoharan
@ 2014-10-01  3:04 ` Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 4/5] ath9k: Fix pending frame check Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 5/5] ath9k: Remove duplicate code Sujith Manoharan
  4 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-10-01  3:04 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

There is no need to check if the current
channel context has active ACs queued up
if the TX queue is not empty.

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/main.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index ae7c6ee..84c0cd4 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -60,8 +60,10 @@ static bool ath9k_has_pending_frames(struct ath_softc *sc, struct ath_txq *txq)
 
 	spin_lock_bh(&txq->axq_lock);
 
-	if (txq->axq_depth)
+	if (txq->axq_depth) {
 		pending = true;
+		goto out;
+	}
 
 	if (txq->mac80211_qnum >= 0) {
 		struct list_head *list;
@@ -70,6 +72,7 @@ static bool ath9k_has_pending_frames(struct ath_softc *sc, struct ath_txq *txq)
 		if (!list_empty(list))
 			pending = true;
 	}
+out:
 	spin_unlock_bh(&txq->axq_lock);
 	return pending;
 }
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 4/5] ath9k: Fix pending frame check
  2014-10-01  3:04 [PATCH 0/5] ath9k patches Sujith Manoharan
                   ` (2 preceding siblings ...)
  2014-10-01  3:04 ` [PATCH 3/5] ath9k: Check pending frames properly Sujith Manoharan
@ 2014-10-01  3:04 ` Sujith Manoharan
  2014-10-01  3:04 ` [PATCH 5/5] ath9k: Remove duplicate code Sujith Manoharan
  4 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-10-01  3:04 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Checking for the queue depth outside of
the TX queue lock is incorrect and in this
case, is not required since it is done inside
ath9k_has_pending_frames().

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 84c0cd4..73a4438 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1974,9 +1974,6 @@ static bool ath9k_has_tx_pending(struct ath_softc *sc)
 		if (!ATH_TXQ_SETUP(sc, i))
 			continue;
 
-		if (!sc->tx.txq[i].axq_depth)
-			continue;
-
 		npend = ath9k_has_pending_frames(sc, &sc->tx.txq[i]);
 		if (npend)
 			break;
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 5/5] ath9k: Remove duplicate code
  2014-10-01  3:04 [PATCH 0/5] ath9k patches Sujith Manoharan
                   ` (3 preceding siblings ...)
  2014-10-01  3:04 ` [PATCH 4/5] ath9k: Fix pending frame check Sujith Manoharan
@ 2014-10-01  3:04 ` Sujith Manoharan
  4 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-10-01  3:04 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

ath9k_has_tx_pending() can be used to
check if there are pending frames instead
of having duplicate code.

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/main.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 73a4438..65ca7ac 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -2039,16 +2039,8 @@ void __ath9k_flush(struct ieee80211_hw *hw, u32 queues, bool drop)
 static bool ath9k_tx_frames_pending(struct ieee80211_hw *hw)
 {
 	struct ath_softc *sc = hw->priv;
-	int i;
-
-	for (i = 0; i < ATH9K_NUM_TX_QUEUES; i++) {
-		if (!ATH_TXQ_SETUP(sc, i))
-			continue;
 
-		if (ath9k_has_pending_frames(sc, &sc->tx.txq[i]))
-			return true;
-	}
-	return false;
+	return ath9k_has_tx_pending(sc);
 }
 
 static int ath9k_tx_last_beacon(struct ieee80211_hw *hw)
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2015-03-14  4:35     ` Felix Fietkau
@ 2015-03-14  5:56       ` Sujith Manoharan
  0 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2015-03-14  5:56 UTC (permalink / raw)
  To: Felix Fietkau; +Cc: Kalle Valo, linux-wireless

Felix Fietkau wrote:
> It's probably enough to just change struct ath_aic_sram_info to make it
> fit: Just put the bool fields together and make them single-bit.
> This should save more than 300 bytes.

Yes, that works too. Thanks.

Sujith

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2015-03-14  0:21   ` Sujith Manoharan
@ 2015-03-14  4:35     ` Felix Fietkau
  2015-03-14  5:56       ` Sujith Manoharan
  0 siblings, 1 reply; 23+ messages in thread
From: Felix Fietkau @ 2015-03-14  4:35 UTC (permalink / raw)
  To: Sujith Manoharan, Kalle Valo; +Cc: linux-wireless

On 2015-03-14 01:21, Sujith Manoharan wrote:
> Kalle Valo wrote:
>> With these patches I got a new warning:
>> 
>> drivers/net/wireless/ath/ath9k/ar9003_aic.c: In function 'ar9003_aic_cal_post_process':
>> drivers/net/wireless/ath/ath9k/ar9003_aic.c:431:1: warning: the frame size of 1312 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>> 
>> Is it a valid warning?
> 
> When CONFIG_FRAME_WARN is set to 1024, this will be hit.
> On my machine, the value is 2048, so the stack doesn't overflow.
> 
> But, 1024 could be a valid limit in some architectures, so I'll
> rework ar9003_aic_cal_post_process() to avoid using the stack
> excessively and post another series.
It's probably enough to just change struct ath_aic_sram_info to make it
fit: Just put the bool fields together and make them single-bit.
This should save more than 300 bytes.

- Felix

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2015-03-13 13:31 ` Kalle Valo
@ 2015-03-14  0:21   ` Sujith Manoharan
  2015-03-14  4:35     ` Felix Fietkau
  0 siblings, 1 reply; 23+ messages in thread
From: Sujith Manoharan @ 2015-03-14  0:21 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless

Kalle Valo wrote:
> With these patches I got a new warning:
> 
> drivers/net/wireless/ath/ath9k/ar9003_aic.c: In function 'ar9003_aic_cal_post_process':
> drivers/net/wireless/ath/ath9k/ar9003_aic.c:431:1: warning: the frame size of 1312 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> Is it a valid warning?

When CONFIG_FRAME_WARN is set to 1024, this will be hit.
On my machine, the value is 2048, so the stack doesn't overflow.

But, 1024 could be a valid limit in some architectures, so I'll
rework ar9003_aic_cal_post_process() to avoid using the stack
excessively and post another series.

Sujith

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2015-03-09  8:50 [PATCH 0/5] ath9k patches Sujith Manoharan
@ 2015-03-13 13:31 ` Kalle Valo
  2015-03-14  0:21   ` Sujith Manoharan
  0 siblings, 1 reply; 23+ messages in thread
From: Kalle Valo @ 2015-03-13 13:31 UTC (permalink / raw)
  To: Sujith Manoharan; +Cc: linux-wireless

Sujith Manoharan <sujith@msujith.org> writes:

> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> For -next.
>
> Sujith Manoharan (5):
>   ath9k: Add PCIE powersave macros
>   ath9k: Fix PLL powersave for AR9485
>   ath9k: Initialize pll_pwrsave for AR9462/AR9565
>   ath9k: Check allowed PCIE powersave configuration
>   ath9k: Fix RTT chainmask usage

With these patches I got a new warning:

drivers/net/wireless/ath/ath9k/ar9003_aic.c: In function 'ar9003_aic_cal_post_process':
drivers/net/wireless/ath/ath9k/ar9003_aic.c:431:1: warning: the frame size of 1312 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Is it a valid warning?

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] ath9k patches
@ 2015-03-09  8:50 Sujith Manoharan
  2015-03-13 13:31 ` Kalle Valo
  0 siblings, 1 reply; 23+ messages in thread
From: Sujith Manoharan @ 2015-03-09  8:50 UTC (permalink / raw)
  To: linux-wireless

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

For -next.

Sujith Manoharan (5):
  ath9k: Add PCIE powersave macros
  ath9k: Fix PLL powersave for AR9485
  ath9k: Initialize pll_pwrsave for AR9462/AR9565
  ath9k: Check allowed PCIE powersave configuration
  ath9k: Fix RTT chainmask usage

 drivers/net/wireless/ath/ath9k/ar9003_hw.c  | 83 +++++++++++++++++++++--------
 drivers/net/wireless/ath/ath9k/ar9003_rtt.c |  6 +--
 drivers/net/wireless/ath/ath9k/hw.c         |  3 ++
 drivers/net/wireless/ath/ath9k/hw.h         |  8 ++-
 drivers/net/wireless/ath/ath9k/init.c       |  9 +++-
 5 files changed, 83 insertions(+), 26 deletions(-)

-- 
2.3.1


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2014-12-19  1:03 Sujith Manoharan
  2015-01-06 18:01 ` Kalle Valo
@ 2015-01-15 12:29 ` Kalle Valo
  1 sibling, 0 replies; 23+ messages in thread
From: Kalle Valo @ 2015-01-15 12:29 UTC (permalink / raw)
  To: Sujith Manoharan; +Cc: linux-wireless, ath9k-devel

Sujith Manoharan <sujith@msujith.org> writes:

> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> Pending patches for ath9k, rebased over wireless-drivers-next.
> All of these are for -next.
>
> The patch "ath9k: Fix no-ack frame status" depends on two commits
> that have been merged in mac80211-next, so it needs to be pulled
> into wireless-drivers-next.
>
> Sujith
>
> Miaoqing Pan (4):
>   ath9k: Add HW IDs for QCA956x
>   ath9k: Add initvals for QCA956x
>   ath9k: Fix register definitions for QCA956x
>   ath9k: Add QCA956x HW support

I have applied these patches.

> Sujith Manoharan (1):
>   ath9k: Fix no-ack frame status

This patch is still pending for the mac80211 patch.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2015-01-07  0:46   ` Sujith Manoharan
@ 2015-01-07  7:14     ` Kalle Valo
  0 siblings, 0 replies; 23+ messages in thread
From: Kalle Valo @ 2015-01-07  7:14 UTC (permalink / raw)
  To: Sujith Manoharan; +Cc: linux-wireless, ath9k-devel

Sujith Manoharan <sujith@msujith.org> writes:

> Kalle Valo wrote:
>> What are the dependency patches exactly?
>
> commit 5cf16616e152dd5c274a65954c77f64892d025a8
> Author: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> Date:   Wed Dec 10 21:26:11 2014 +0530
>
>     mac80211: Fix accounting of multicast frames
>
> commit 6b127c71fbdd3daacfd8b9f80b8e6ebfb70a889e
> Author: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> Date:   Wed Dec 10 21:26:10 2014 +0530
>
>     mac80211: Move IEEE80211_TX_CTL_PS_RESPONSE

Ok, I don't have these yet so I'll wait more.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2015-01-06 18:01 ` Kalle Valo
@ 2015-01-07  0:46   ` Sujith Manoharan
  2015-01-07  7:14     ` Kalle Valo
  0 siblings, 1 reply; 23+ messages in thread
From: Sujith Manoharan @ 2015-01-07  0:46 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, ath9k-devel

Kalle Valo wrote:
> What are the dependency patches exactly?

commit 5cf16616e152dd5c274a65954c77f64892d025a8
Author: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Date:   Wed Dec 10 21:26:11 2014 +0530

    mac80211: Fix accounting of multicast frames

commit 6b127c71fbdd3daacfd8b9f80b8e6ebfb70a889e
Author: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Date:   Wed Dec 10 21:26:10 2014 +0530

    mac80211: Move IEEE80211_TX_CTL_PS_RESPONSE

Sujith

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2014-12-19  1:03 Sujith Manoharan
@ 2015-01-06 18:01 ` Kalle Valo
  2015-01-07  0:46   ` Sujith Manoharan
  2015-01-15 12:29 ` Kalle Valo
  1 sibling, 1 reply; 23+ messages in thread
From: Kalle Valo @ 2015-01-06 18:01 UTC (permalink / raw)
  To: Sujith Manoharan; +Cc: linux-wireless, ath9k-devel

Sujith Manoharan <sujith@msujith.org> writes:

> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> Pending patches for ath9k, rebased over wireless-drivers-next.
> All of these are for -next.
>
> The patch "ath9k: Fix no-ack frame status" depends on two commits
> that have been merged in mac80211-next, so it needs to be pulled
> into wireless-drivers-next.

What are the dependency patches exactly?

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] ath9k patches
@ 2014-12-19  1:03 Sujith Manoharan
  2015-01-06 18:01 ` Kalle Valo
  2015-01-15 12:29 ` Kalle Valo
  0 siblings, 2 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-12-19  1:03 UTC (permalink / raw)
  To: linux-wireless; +Cc: ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Pending patches for ath9k, rebased over wireless-drivers-next.
All of these are for -next.

The patch "ath9k: Fix no-ack frame status" depends on two commits
that have been merged in mac80211-next, so it needs to be pulled
into wireless-drivers-next.

Sujith

Miaoqing Pan (4):
  ath9k: Add HW IDs for QCA956x
  ath9k: Add initvals for QCA956x
  ath9k: Fix register definitions for QCA956x
  ath9k: Add QCA956x HW support

Sujith Manoharan (1):
  ath9k: Fix no-ack frame status

 drivers/net/wireless/ath/ath9k/ahb.c             |    4 +
 drivers/net/wireless/ath/ath9k/ani.c             |    3 +-
 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c   |   15 +-
 drivers/net/wireless/ath/ath9k/ar9003_hw.c       |   61 +-
 drivers/net/wireless/ath/ath9k/ar9003_phy.c      |   47 +-
 drivers/net/wireless/ath/ath9k/ar9003_phy.h      |   19 +-
 drivers/net/wireless/ath/ath9k/ar956x_initvals.h | 1046 ++++++++++++++++++++++
 drivers/net/wireless/ath/ath9k/hw.c              |   41 +-
 drivers/net/wireless/ath/ath9k/hw.h              |    1 +
 drivers/net/wireless/ath/ath9k/mac.c             |    3 +-
 drivers/net/wireless/ath/ath9k/recv.c            |    3 +-
 drivers/net/wireless/ath/ath9k/reg.h             |    4 +
 drivers/net/wireless/ath/ath9k/xmit.c            |    9 +-
 13 files changed, 1212 insertions(+), 44 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath9k/ar956x_initvals.h

-- 
2.1.3


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] ath9k patches
@ 2014-10-09  8:12 Sujith Manoharan
  0 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-10-09  8:12 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

MCC fixes for -next.

Sujith Manoharan (5):
  ath9k: Clear NoA schedule properly
  ath9k: Use configurable timeout for flush
  ath9k: Fix MCC flush timeout
  ath9k: Fix offchannel flush timeout
  ath9k: Check for pending frames properly

 drivers/net/wireless/ath/ath9k/ath9k.h   |  4 ++-
 drivers/net/wireless/ath/ath9k/channel.c | 57 ++++++++++++++++++++++++++++++--
 drivers/net/wireless/ath/ath9k/main.c    | 30 ++++++++++++-----
 3 files changed, 79 insertions(+), 12 deletions(-)

-- 
2.1.2


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] ath9k patches
@ 2014-09-24  6:18 Sujith Manoharan
  0 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-09-24  6:18 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

MCC fixes for 3.18. This includes the two patches that were posted earlier.

Sujith Manoharan (5):
  ath9k: Cache BSS information
  ath9k: Fix p2p address management
  ath9k: Fix queue management
  ath9k: Use normal queues for offchannel frames
  ath9k: Fix offchannel queuing

 drivers/net/wireless/ath/ath9k/ath9k.h   |  6 ++++
 drivers/net/wireless/ath/ath9k/channel.c |  6 ++--
 drivers/net/wireless/ath/ath9k/main.c    | 49 +++++++++++++++++++++++++++++---
 drivers/net/wireless/ath/ath9k/xmit.c    | 17 ++++-------
 4 files changed, 60 insertions(+), 18 deletions(-)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] ath9k patches
@ 2014-09-15  5:55 Sujith Manoharan
  0 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-09-15  5:55 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

MCC fixes for 3.18

Sujith Manoharan (5):
  ath9k: Remove unnecessary tbtt assignment
  ath9k: Check beaconing mode properly
  ath9k: Set offchannel state properly
  ath9k: Remove useless opmode check
  ath9k: Fix primary station configuration

 drivers/net/wireless/ath/ath9k/ath9k.h   |  4 +-
 drivers/net/wireless/ath/ath9k/channel.c |  8 ++--
 drivers/net/wireless/ath/ath9k/main.c    | 70 ++++++++++++++++++++------------
 drivers/net/wireless/ath/ath9k/recv.c    |  2 +-
 4 files changed, 51 insertions(+), 33 deletions(-)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] ath9k patches
@ 2014-09-10 13:45 Sujith Manoharan
  0 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-09-10 13:45 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

MCC fixes for 3.18.

Sujith Manoharan (5):
  ath9k: Assign offchannel duration properly
  ath9k: Fix Notice of Absence issues
  ath9k: Clear offchannel duration properly
  ath9k: Fix channel switch time duration
  ath9k: Fix beacon miss handling

 drivers/net/wireless/ath/ath9k/ath9k.h   |   8 +-
 drivers/net/wireless/ath/ath9k/channel.c | 143 ++++++++++++++++++++++---------
 2 files changed, 109 insertions(+), 42 deletions(-)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2014-09-04 17:24 ` John W. Linville
@ 2014-09-05  0:48   ` Sujith Manoharan
  0 siblings, 0 replies; 23+ messages in thread
From: Sujith Manoharan @ 2014-09-05  0:48 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-wireless, ath9k-devel

John W. Linville wrote:
> I am having a lot of trouble determining which of your series are
> intended as fixes for the current release (3.17) or updates for the
> next release (3.18).  In this series, several seem like fixes but
> "ath9k: Fix ath_startrecv" seems like a cleanup.
> 
> Would you like to reorganize your patch submissions as fixes
> vs. features?  Or do you want them all to be merged as features
> for 3.18?

All these patches are meant for 3.18. I usually mark immediate
fixes as stable candidates.

I'll be more explicit about this in future.

thanks,
Sujith

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/5] ath9k patches
  2014-09-03  7:55 Sujith Manoharan
@ 2014-09-04 17:24 ` John W. Linville
  2014-09-05  0:48   ` Sujith Manoharan
  0 siblings, 1 reply; 23+ messages in thread
From: John W. Linville @ 2014-09-04 17:24 UTC (permalink / raw)
  To: Sujith Manoharan; +Cc: linux-wireless, ath9k-devel

I am having a lot of trouble determining which of your series are
intended as fixes for the current release (3.17) or updates for the
next release (3.18).  In this series, several seem like fixes but
"ath9k: Fix ath_startrecv" seems like a cleanup.

Would you like to reorganize your patch submissions as fixes
vs. features?  Or do you want them all to be merged as features
for 3.18?

John

On Wed, Sep 03, 2014 at 01:25:24PM +0530, Sujith Manoharan wrote:
> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> 
> Various fixes for MCC.
> 
> Sujith Manoharan (5):
>   ath9k: Fix RX filter calculation
>   ath9k: Fix ath_startrecv()
>   ath9k: Fix COMP_BAR filter
>   ath9k: Fix RX filters in channel contexts
>   ath9k: Fix interface accounting
> 
>  drivers/net/wireless/ath/ath9k/ath9k.h  |  7 ++++---
>  drivers/net/wireless/ath/ath9k/beacon.c |  2 +-
>  drivers/net/wireless/ath/ath9k/debug.c  |  2 +-
>  drivers/net/wireless/ath/ath9k/main.c   | 20 +++++++++-----------
>  drivers/net/wireless/ath/ath9k/recv.c   | 31 +++++++++++++++++++------------
>  drivers/net/wireless/ath/ath9k/tx99.c   |  2 +-
>  drivers/net/wireless/ath/ath9k/wow.c    |  2 +-
>  7 files changed, 36 insertions(+), 30 deletions(-)
> 
> -- 
> 2.1.0
> 
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0/5] ath9k patches
@ 2014-09-03  7:55 Sujith Manoharan
  2014-09-04 17:24 ` John W. Linville
  0 siblings, 1 reply; 23+ messages in thread
From: Sujith Manoharan @ 2014-09-03  7:55 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, ath9k-devel

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Various fixes for MCC.

Sujith Manoharan (5):
  ath9k: Fix RX filter calculation
  ath9k: Fix ath_startrecv()
  ath9k: Fix COMP_BAR filter
  ath9k: Fix RX filters in channel contexts
  ath9k: Fix interface accounting

 drivers/net/wireless/ath/ath9k/ath9k.h  |  7 ++++---
 drivers/net/wireless/ath/ath9k/beacon.c |  2 +-
 drivers/net/wireless/ath/ath9k/debug.c  |  2 +-
 drivers/net/wireless/ath/ath9k/main.c   | 20 +++++++++-----------
 drivers/net/wireless/ath/ath9k/recv.c   | 31 +++++++++++++++++++------------
 drivers/net/wireless/ath/ath9k/tx99.c   |  2 +-
 drivers/net/wireless/ath/ath9k/wow.c    |  2 +-
 7 files changed, 36 insertions(+), 30 deletions(-)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2015-03-14  5:53 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-01  3:04 [PATCH 0/5] ath9k patches Sujith Manoharan
2014-10-01  3:04 ` [PATCH 1/5] ath: Add support for tracing Sujith Manoharan
2014-10-01  3:04 ` [PATCH 2/5] ath9k: Print RoC expiration Sujith Manoharan
2014-10-01  3:04 ` [PATCH 3/5] ath9k: Check pending frames properly Sujith Manoharan
2014-10-01  3:04 ` [PATCH 4/5] ath9k: Fix pending frame check Sujith Manoharan
2014-10-01  3:04 ` [PATCH 5/5] ath9k: Remove duplicate code Sujith Manoharan
  -- strict thread matches above, loose matches on Subject: below --
2015-03-09  8:50 [PATCH 0/5] ath9k patches Sujith Manoharan
2015-03-13 13:31 ` Kalle Valo
2015-03-14  0:21   ` Sujith Manoharan
2015-03-14  4:35     ` Felix Fietkau
2015-03-14  5:56       ` Sujith Manoharan
2014-12-19  1:03 Sujith Manoharan
2015-01-06 18:01 ` Kalle Valo
2015-01-07  0:46   ` Sujith Manoharan
2015-01-07  7:14     ` Kalle Valo
2015-01-15 12:29 ` Kalle Valo
2014-10-09  8:12 Sujith Manoharan
2014-09-24  6:18 Sujith Manoharan
2014-09-15  5:55 Sujith Manoharan
2014-09-10 13:45 Sujith Manoharan
2014-09-03  7:55 Sujith Manoharan
2014-09-04 17:24 ` John W. Linville
2014-09-05  0:48   ` Sujith Manoharan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.