From: Amit Daniel Kachhap <amit.daniel@samsung.com> To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: kgene.kim@samsung.com, linux-kernel@vger.kernel.org, s.nawrocki@samsung.com, pankaj.dubey@samsung.com, ulf.hansson@linaro.org, khilman@kernel.org, linux-pm@vger.kernel.org, geert@linux-m68k.org, rjw@rjwysocki.net, devicetree@vger.kernel.org, Amit Daniel Kachhap <amit.daniel@samsung.com> Subject: [PATCH RFC v2 01/12] arm: exynos: Add platform driver support for power domain driver Date: Mon, 24 Nov 2014 18:34:05 +0530 [thread overview] Message-ID: <1416834256-11225-1-git-send-email-amit.daniel@samsung.com> (raw) In-Reply-To: <1416833572-6880-1-git-send-email-amit.daniel@samsung.com> This patch modifies Exynos Power Domain driver initialization implementation in following way: - Added platform driver support and probe function where Exynos PM Domain driver will finally register itself as MFD PMU client driver. In this way,all the Exynos power domains are probed once and registered with the power domain subsystem. - Existing DT bindings are used. Cc: Kukjin Kim <kgene.kim@samsung.com> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com> --- arch/arm/mach-exynos/pm_domains.c | 40 +++++++++++++++++++++++-------------- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 20f2671..5cb5440 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -105,25 +105,17 @@ static int exynos_pd_power_off(struct generic_pm_domain *domain) return exynos_pd_power(domain, false); } -static __init int exynos4_pm_init_power_domain(void) +static int exynos_power_domain_probe(struct platform_device *pdev) { - struct platform_device *pdev; struct device_node *np; for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { struct exynos_pm_domain *pd; int on, i; - struct device *dev; - pdev = of_find_device_by_node(np); - dev = &pdev->dev; - - pd = kzalloc(sizeof(*pd), GFP_KERNEL); - if (!pd) { - pr_err("%s: failed to allocate memory for domain\n", - __func__); + pd = devm_kzalloc(&pdev->dev, sizeof(*pd), GFP_KERNEL); + if (!pd) return -ENOMEM; - } pd->pd.name = kstrdup(np->name, GFP_KERNEL); pd->name = pd->pd.name; @@ -131,7 +123,7 @@ static __init int exynos4_pm_init_power_domain(void) pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on; - pd->oscclk = clk_get(dev, "oscclk"); + pd->oscclk = of_clk_get_by_name(np, "oscclk"); if (IS_ERR(pd->oscclk)) goto no_clk; @@ -139,11 +131,11 @@ static __init int exynos4_pm_init_power_domain(void) char clk_name[8]; snprintf(clk_name, sizeof(clk_name), "clk%d", i); - pd->clk[i] = clk_get(dev, clk_name); + pd->clk[i] = of_clk_get_by_name(np, clk_name); if (IS_ERR(pd->clk[i])) break; snprintf(clk_name, sizeof(clk_name), "pclk%d", i); - pd->pclk[i] = clk_get(dev, clk_name); + pd->pclk[i] = of_clk_get_by_name(np, clk_name); if (IS_ERR(pd->pclk[i])) { clk_put(pd->clk[i]); pd->clk[i] = ERR_PTR(-EINVAL); @@ -163,4 +155,22 @@ no_clk: return 0; } -arch_initcall(exynos4_pm_init_power_domain); + +static const struct platform_device_id exynos_power_domain_id[] = { + { "exynos-pmu-pd"}, + { }, +}; + +static struct platform_driver exynos_power_domain_driver = { + .driver = { + .name = "exynos-pd", + }, + .probe = exynos_power_domain_probe, + .id_table = exynos_power_domain_id, +}; + +static int __init exynos_power_domain_init(void) +{ + return platform_driver_register(&exynos_power_domain_driver); +} +postcore_initcall(exynos_power_domain_init); -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: amit.daniel@samsung.com (Amit Daniel Kachhap) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RFC v2 01/12] arm: exynos: Add platform driver support for power domain driver Date: Mon, 24 Nov 2014 18:34:05 +0530 [thread overview] Message-ID: <1416834256-11225-1-git-send-email-amit.daniel@samsung.com> (raw) In-Reply-To: <1416833572-6880-1-git-send-email-amit.daniel@samsung.com> This patch modifies Exynos Power Domain driver initialization implementation in following way: - Added platform driver support and probe function where Exynos PM Domain driver will finally register itself as MFD PMU client driver. In this way,all the Exynos power domains are probed once and registered with the power domain subsystem. - Existing DT bindings are used. Cc: Kukjin Kim <kgene.kim@samsung.com> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com> --- arch/arm/mach-exynos/pm_domains.c | 40 +++++++++++++++++++++++-------------- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 20f2671..5cb5440 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -105,25 +105,17 @@ static int exynos_pd_power_off(struct generic_pm_domain *domain) return exynos_pd_power(domain, false); } -static __init int exynos4_pm_init_power_domain(void) +static int exynos_power_domain_probe(struct platform_device *pdev) { - struct platform_device *pdev; struct device_node *np; for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { struct exynos_pm_domain *pd; int on, i; - struct device *dev; - pdev = of_find_device_by_node(np); - dev = &pdev->dev; - - pd = kzalloc(sizeof(*pd), GFP_KERNEL); - if (!pd) { - pr_err("%s: failed to allocate memory for domain\n", - __func__); + pd = devm_kzalloc(&pdev->dev, sizeof(*pd), GFP_KERNEL); + if (!pd) return -ENOMEM; - } pd->pd.name = kstrdup(np->name, GFP_KERNEL); pd->name = pd->pd.name; @@ -131,7 +123,7 @@ static __init int exynos4_pm_init_power_domain(void) pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on; - pd->oscclk = clk_get(dev, "oscclk"); + pd->oscclk = of_clk_get_by_name(np, "oscclk"); if (IS_ERR(pd->oscclk)) goto no_clk; @@ -139,11 +131,11 @@ static __init int exynos4_pm_init_power_domain(void) char clk_name[8]; snprintf(clk_name, sizeof(clk_name), "clk%d", i); - pd->clk[i] = clk_get(dev, clk_name); + pd->clk[i] = of_clk_get_by_name(np, clk_name); if (IS_ERR(pd->clk[i])) break; snprintf(clk_name, sizeof(clk_name), "pclk%d", i); - pd->pclk[i] = clk_get(dev, clk_name); + pd->pclk[i] = of_clk_get_by_name(np, clk_name); if (IS_ERR(pd->pclk[i])) { clk_put(pd->clk[i]); pd->clk[i] = ERR_PTR(-EINVAL); @@ -163,4 +155,22 @@ no_clk: return 0; } -arch_initcall(exynos4_pm_init_power_domain); + +static const struct platform_device_id exynos_power_domain_id[] = { + { "exynos-pmu-pd"}, + { }, +}; + +static struct platform_driver exynos_power_domain_driver = { + .driver = { + .name = "exynos-pd", + }, + .probe = exynos_power_domain_probe, + .id_table = exynos_power_domain_id, +}; + +static int __init exynos_power_domain_init(void) +{ + return platform_driver_register(&exynos_power_domain_driver); +} +postcore_initcall(exynos_power_domain_init); -- 1.7.9.5
next prev parent reply other threads:[~2014-11-24 13:11 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-24 12:52 [PATCH RFC v2 00/12] soc: samsung: Modify and enhance power domain driver Amit Daniel Kachhap 2014-11-24 12:52 ` Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap [this message] 2014-11-24 13:04 ` [PATCH RFC v2 01/12] arm: exynos: Add platform driver support for " Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 02/12] soc: exynos: Move exynos power domain file to driver/soc/samsung folder Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 03/12] soc: samsung: exynos-pmu: Register exynos pd driver as a mfd client Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 04/12] soc: samsung: Re-structure PMU driver to create pd on/off handlers Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 05/12] soc: samsung: pm_domain: Use unique compatible name for power domain Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 06/12] driver: soc: exynos-pmu: Add exynos7 power domain on/off ops Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-25 7:30 ` Ulf Hansson 2014-11-25 7:30 ` Ulf Hansson 2014-11-25 7:30 ` Ulf Hansson 2014-11-25 8:33 ` amit daniel kachhap 2014-11-25 8:33 ` amit daniel kachhap 2014-11-25 8:33 ` amit daniel kachhap 2014-11-24 13:04 ` [PATCH RFC v2 07/12] PM / Domains: export pm_genpd_lookup_name Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-25 7:35 ` Ulf Hansson 2014-11-25 7:35 ` Ulf Hansson 2014-11-25 7:35 ` Ulf Hansson 2014-11-25 8:48 ` amit daniel kachhap 2014-11-25 8:48 ` amit daniel kachhap 2014-11-25 8:48 ` amit daniel kachhap 2014-11-27 14:20 ` Ulf Hansson 2014-11-27 14:20 ` Ulf Hansson 2014-11-27 14:20 ` Ulf Hansson 2014-11-28 8:52 ` amit daniel kachhap 2014-11-28 8:52 ` amit daniel kachhap 2014-11-28 8:52 ` amit daniel kachhap 2014-11-24 13:04 ` [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-25 7:59 ` Ulf Hansson 2014-11-25 7:59 ` Ulf Hansson 2014-11-25 7:59 ` Ulf Hansson 2014-11-25 8:57 ` amit daniel kachhap 2014-11-25 8:57 ` amit daniel kachhap 2014-11-25 8:57 ` amit daniel kachhap 2014-11-25 9:19 ` Geert Uytterhoeven 2014-11-25 9:19 ` Geert Uytterhoeven 2014-11-25 9:19 ` Geert Uytterhoeven 2014-12-03 8:36 ` Marek Szyprowski 2014-12-03 8:36 ` Marek Szyprowski 2014-12-03 8:36 ` Marek Szyprowski 2014-11-24 13:04 ` [PATCH RFC v2 09/12] drivers: soc: pm_domain: Modify the parent clocks bindings Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 10/12] drivers: soc: samsung: Add support for clock enabling in power domain Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 11/12] drivers: soc: samsung: Add support for clock rate save/restore " Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 12/12] arm64: Kconfig: Enable PM_GENERIC_DOMAINS for exynos7 Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1416834256-11225-1-git-send-email-amit.daniel@samsung.com \ --to=amit.daniel@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=kgene.kim@samsung.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=pankaj.dubey@samsung.com \ --cc=rjw@rjwysocki.net \ --cc=s.nawrocki@samsung.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.