From: Marek Szyprowski <m.szyprowski@samsung.com> To: Geert Uytterhoeven <geert@linux-m68k.org>, amit daniel kachhap <amit.daniel@samsung.com> Cc: Ulf Hansson <ulf.hansson@linaro.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Kukjin Kim <kgene.kim@samsung.com>, Kevin Hilman <khilman@kernel.org>, Pankaj Dubey <pankaj.dubey@samsung.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain Date: Wed, 03 Dec 2014 09:36:27 +0100 [thread overview] Message-ID: <547ECB8B.3040905@samsung.com> (raw) In-Reply-To: <CAMuHMdX+rcmUM+_4c72b16Zs_c5KMhO3bYSH5-AUp087cwGdeA@mail.gmail.com> Hello, On 2014-11-25 10:19, Geert Uytterhoeven wrote: > On Tue, Nov 25, 2014 at 9:57 AM, amit daniel kachhap > <amit.daniel@samsung.com> wrote: >>>> diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >>>> index 00ebda1..0160bdc 100644 >>>> --- a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >>>> +++ b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >>>> @@ -24,6 +24,7 @@ Optional Properties: >>>> - pclkN, clkN: Pairs of parent of input clock and input clock to the >>>> devices in this power domain. Maximum of 4 pairs (N = 0 to 3) >>>> are supported currently. >>>> +- parents: phandle of parent power domains. > Why not using just "power-domains = <&pd_top>"? > This is consistent with how clocks refer to their parent clocks. I agree. The only question is weather exynos dts should keep using samsung,power-domain property, or switch to generic 'power-domains' approach. I assume that exynos-pm driver should support both. >>>> Node of a device using power domains must have a samsung,power-domain property >>>> defined with a phandle to respective power domain. >>>> @@ -48,6 +49,7 @@ Example: >>>> mfc_pd: power-domain@10044060 { >>>> compatible = "samsung,exynos4210-pd", "samsung,exynos7-pd-mfc"; >>>> reg = <0x10044060 0x20>; >>>> + parents = <&pd_top>; >>>> #power-domain-cells = <0>; >>>> }; >>> This seems like a good and generic approach to describe that a PM >>> domain could have a parent. I would suggest to rename it, such it >>> reflects its a PM domain binding though. >> I am not sure if this is generic. I guess PD's represented like below >> are more generic. >> PD1 { >> PD2 { >> PD3 { >> }; >> }; >> }; > Such a representation is not always possible. > If you have one power-controller for a hierarchy of PM domains, you can > use it. > If you have multiple power-controllers, the power controller nodes are at the > same level in DT, so you'll have to use "power-domains" properties to link > them together. I agree. I will send updated patch for this purpose for existing exynos4 power domain driver. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: m.szyprowski@samsung.com (Marek Szyprowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain Date: Wed, 03 Dec 2014 09:36:27 +0100 [thread overview] Message-ID: <547ECB8B.3040905@samsung.com> (raw) In-Reply-To: <CAMuHMdX+rcmUM+_4c72b16Zs_c5KMhO3bYSH5-AUp087cwGdeA@mail.gmail.com> Hello, On 2014-11-25 10:19, Geert Uytterhoeven wrote: > On Tue, Nov 25, 2014 at 9:57 AM, amit daniel kachhap > <amit.daniel@samsung.com> wrote: >>>> diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >>>> index 00ebda1..0160bdc 100644 >>>> --- a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >>>> +++ b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >>>> @@ -24,6 +24,7 @@ Optional Properties: >>>> - pclkN, clkN: Pairs of parent of input clock and input clock to the >>>> devices in this power domain. Maximum of 4 pairs (N = 0 to 3) >>>> are supported currently. >>>> +- parents: phandle of parent power domains. > Why not using just "power-domains = <&pd_top>"? > This is consistent with how clocks refer to their parent clocks. I agree. The only question is weather exynos dts should keep using samsung,power-domain property, or switch to generic 'power-domains' approach. I assume that exynos-pm driver should support both. >>>> Node of a device using power domains must have a samsung,power-domain property >>>> defined with a phandle to respective power domain. >>>> @@ -48,6 +49,7 @@ Example: >>>> mfc_pd: power-domain at 10044060 { >>>> compatible = "samsung,exynos4210-pd", "samsung,exynos7-pd-mfc"; >>>> reg = <0x10044060 0x20>; >>>> + parents = <&pd_top>; >>>> #power-domain-cells = <0>; >>>> }; >>> This seems like a good and generic approach to describe that a PM >>> domain could have a parent. I would suggest to rename it, such it >>> reflects its a PM domain binding though. >> I am not sure if this is generic. I guess PD's represented like below >> are more generic. >> PD1 { >> PD2 { >> PD3 { >> }; >> }; >> }; > Such a representation is not always possible. > If you have one power-controller for a hierarchy of PM domains, you can > use it. > If you have multiple power-controllers, the power controller nodes are at the > same level in DT, so you'll have to use "power-domains" properties to link > them together. I agree. I will send updated patch for this purpose for existing exynos4 power domain driver. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
next prev parent reply other threads:[~2014-12-03 8:36 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-24 12:52 [PATCH RFC v2 00/12] soc: samsung: Modify and enhance power domain driver Amit Daniel Kachhap 2014-11-24 12:52 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 01/12] arm: exynos: Add platform driver support for " Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 02/12] soc: exynos: Move exynos power domain file to driver/soc/samsung folder Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 03/12] soc: samsung: exynos-pmu: Register exynos pd driver as a mfd client Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 04/12] soc: samsung: Re-structure PMU driver to create pd on/off handlers Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 05/12] soc: samsung: pm_domain: Use unique compatible name for power domain Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 06/12] driver: soc: exynos-pmu: Add exynos7 power domain on/off ops Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-25 7:30 ` Ulf Hansson 2014-11-25 7:30 ` Ulf Hansson 2014-11-25 7:30 ` Ulf Hansson 2014-11-25 8:33 ` amit daniel kachhap 2014-11-25 8:33 ` amit daniel kachhap 2014-11-25 8:33 ` amit daniel kachhap 2014-11-24 13:04 ` [PATCH RFC v2 07/12] PM / Domains: export pm_genpd_lookup_name Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-25 7:35 ` Ulf Hansson 2014-11-25 7:35 ` Ulf Hansson 2014-11-25 7:35 ` Ulf Hansson 2014-11-25 8:48 ` amit daniel kachhap 2014-11-25 8:48 ` amit daniel kachhap 2014-11-25 8:48 ` amit daniel kachhap 2014-11-27 14:20 ` Ulf Hansson 2014-11-27 14:20 ` Ulf Hansson 2014-11-27 14:20 ` Ulf Hansson 2014-11-28 8:52 ` amit daniel kachhap 2014-11-28 8:52 ` amit daniel kachhap 2014-11-28 8:52 ` amit daniel kachhap 2014-11-24 13:04 ` [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-25 7:59 ` Ulf Hansson 2014-11-25 7:59 ` Ulf Hansson 2014-11-25 7:59 ` Ulf Hansson 2014-11-25 8:57 ` amit daniel kachhap 2014-11-25 8:57 ` amit daniel kachhap 2014-11-25 8:57 ` amit daniel kachhap 2014-11-25 9:19 ` Geert Uytterhoeven 2014-11-25 9:19 ` Geert Uytterhoeven 2014-11-25 9:19 ` Geert Uytterhoeven 2014-12-03 8:36 ` Marek Szyprowski [this message] 2014-12-03 8:36 ` Marek Szyprowski 2014-12-03 8:36 ` Marek Szyprowski 2014-11-24 13:04 ` [PATCH RFC v2 09/12] drivers: soc: pm_domain: Modify the parent clocks bindings Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 10/12] drivers: soc: samsung: Add support for clock enabling in power domain Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 11/12] drivers: soc: samsung: Add support for clock rate save/restore " Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap 2014-11-24 13:04 ` [PATCH RFC v2 12/12] arm64: Kconfig: Enable PM_GENERIC_DOMAINS for exynos7 Amit Daniel Kachhap 2014-11-24 13:04 ` Amit Daniel Kachhap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=547ECB8B.3040905@samsung.com \ --to=m.szyprowski@samsung.com \ --cc=amit.daniel@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=kgene.kim@samsung.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=pankaj.dubey@samsung.com \ --cc=rjw@rjwysocki.net \ --cc=s.nawrocki@samsung.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.