From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Rob Herring <robherring2@gmail.com>,
Rob Herring <robh@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
x86@kernel.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH 7/8] tty/serial: add arm64 semihosting earlycon
Date: Sun, 23 Mar 2014 21:23:23 +0100 [thread overview]
Message-ID: <14193198.1gAJ7xnz7b@wuerfel> (raw)
In-Reply-To: <alpine.LFD.2.11.1403231559160.1291@knanqh.ubzr>
On Sunday 23 March 2014 16:04:41 Nicolas Pitre wrote:
> On Fri, 21 Mar 2014, Rob Herring wrote:
>
> > From: Rob Herring <robh@kernel.org>
> >
> > Add earlycon support for the arm64 semihosting debug serial interface.
> > This allows enabling a debug console when early_params are processed.
> > This is based on the arm64 earlyprintk smh support and is intended to
> > replace it.
> >
> > This is named arm rather than arm64 in hopes it will be used for both,
> > but only arm64 is supported ATM.
>
> It can't be used for both as the semihosting calls themselves need
> assembly code and this is not compatible with the equivalent ARM32
> calls. So I'd suggest naming this "arm64" to avoid potential confusion.
How about using an compile-time conditional to put both inline assemblies
in there? While the driver is rather trivial to start with, I don't see
a point in duplicating it either.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] tty/serial: add arm64 semihosting earlycon
Date: Sun, 23 Mar 2014 21:23:23 +0100 [thread overview]
Message-ID: <14193198.1gAJ7xnz7b@wuerfel> (raw)
In-Reply-To: <alpine.LFD.2.11.1403231559160.1291@knanqh.ubzr>
On Sunday 23 March 2014 16:04:41 Nicolas Pitre wrote:
> On Fri, 21 Mar 2014, Rob Herring wrote:
>
> > From: Rob Herring <robh@kernel.org>
> >
> > Add earlycon support for the arm64 semihosting debug serial interface.
> > This allows enabling a debug console when early_params are processed.
> > This is based on the arm64 earlyprintk smh support and is intended to
> > replace it.
> >
> > This is named arm rather than arm64 in hopes it will be used for both,
> > but only arm64 is supported ATM.
>
> It can't be used for both as the semihosting calls themselves need
> assembly code and this is not compatible with the equivalent ARM32
> calls. So I'd suggest naming this "arm64" to avoid potential confusion.
How about using an compile-time conditional to put both inline assemblies
in there? While the driver is rather trivial to start with, I don't see
a point in duplicating it either.
Arnd
next prev parent reply other threads:[~2014-03-23 20:41 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 21:08 [PATCH 0/8] Generic serial earlycon Rob Herring
2014-03-21 21:08 ` Rob Herring
[not found] ` < 201403221054.39799.arnd@arndb.de>
[not found] ` < CAL_JsqKjGjyYypwneCmNc1qeKe0ZOG9gz3QSJ37-HwHXKu3iRA@mail.gmail.com>
[not found] ` < 20140329001732.BECE2C41FF4@trevor.secretlab.ca>
2014-03-21 21:08 ` [PATCH 1/8] x86: move FIX_EARLYCON_MEM kconfig into x86 Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-21 21:08 ` [PATCH 2/8] arm64: add FIXMAP_PAGE_NOCACHE definition Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-24 11:13 ` Catalin Marinas
2014-03-24 11:13 ` Catalin Marinas
2014-03-24 11:13 ` Catalin Marinas
2014-03-21 21:08 ` [PATCH 3/8] arm64: enable FIX_EARLYCON_MEM kconfig Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-24 11:38 ` Catalin Marinas
2014-03-24 11:38 ` Catalin Marinas
2014-03-24 11:38 ` Catalin Marinas
2014-03-21 21:08 ` [PATCH 4/8] tty/serial: add generic serial earlycon Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-24 11:22 ` Catalin Marinas
2014-03-24 11:22 ` Catalin Marinas
2014-03-24 11:22 ` Catalin Marinas
2014-03-24 11:29 ` Arnd Bergmann
2014-03-24 11:29 ` Arnd Bergmann
2014-03-24 13:36 ` Rob Herring
2014-03-24 13:36 ` Rob Herring
2014-03-24 13:36 ` Rob Herring
2014-03-24 15:42 ` Arnd Bergmann
2014-03-24 15:42 ` Arnd Bergmann
2014-03-24 15:42 ` Arnd Bergmann
2014-04-17 18:27 ` Rob Herring
2014-04-17 18:27 ` Rob Herring
2014-04-17 18:27 ` Rob Herring
2014-04-17 20:16 ` Alan Cox
2014-04-17 20:16 ` Alan Cox
2014-04-17 20:16 ` Alan Cox
2014-04-19 11:32 ` Arnd Bergmann
2014-04-19 11:32 ` Arnd Bergmann
2014-04-19 11:32 ` Arnd Bergmann
2014-03-21 21:08 ` [PATCH 5/8] tty/serial: convert 8250 to generic earlycon Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-21 21:08 ` [PATCH 6/8] tty/serial: pl011: add generic earlycon support Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-24 11:28 ` Catalin Marinas
2014-03-24 11:28 ` Catalin Marinas
2014-03-24 11:28 ` Catalin Marinas
2014-04-16 22:14 ` Rob Herring
2014-04-16 22:14 ` Rob Herring
2014-04-16 22:14 ` Rob Herring
2014-04-23 16:39 ` Catalin Marinas
2014-04-23 16:39 ` Catalin Marinas
2014-04-23 16:39 ` Catalin Marinas
2014-03-21 21:08 ` [PATCH 7/8] tty/serial: add arm64 semihosting earlycon Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-23 20:04 ` Nicolas Pitre
2014-03-23 20:04 ` Nicolas Pitre
2014-03-23 20:23 ` Arnd Bergmann [this message]
2014-03-23 20:23 ` Arnd Bergmann
2014-03-23 21:48 ` Nicolas Pitre
2014-03-23 21:48 ` Nicolas Pitre
2014-03-24 11:38 ` Catalin Marinas
2014-03-24 11:38 ` Catalin Marinas
2014-03-24 11:38 ` Catalin Marinas
2014-03-24 11:48 ` Catalin Marinas
2014-03-24 11:48 ` Catalin Marinas
2014-03-24 11:48 ` Catalin Marinas
2014-03-21 21:08 ` [PATCH 8/8] arm64: remove arch specific earlyprintk Rob Herring
2014-03-21 21:08 ` Rob Herring
2014-03-22 9:54 ` [PATCH 0/8] Generic serial earlycon Arnd Bergmann
2014-03-22 9:54 ` Arnd Bergmann
2014-03-22 9:54 ` Arnd Bergmann
2014-03-22 14:14 ` Rob Herring
2014-03-22 14:14 ` Rob Herring
2014-03-22 14:14 ` Rob Herring
2014-03-22 22:01 ` Arnd Bergmann
2014-03-22 22:01 ` Arnd Bergmann
2014-03-22 22:01 ` Arnd Bergmann
2014-03-23 15:09 ` Rob Herring
2014-03-23 15:09 ` Rob Herring
2014-03-23 15:09 ` Rob Herring
2014-03-23 19:49 ` Arnd Bergmann
2014-03-23 19:49 ` Arnd Bergmann
2014-03-23 19:49 ` Arnd Bergmann
2014-03-29 0:17 ` Grant Likely
2014-03-29 0:17 ` Grant Likely
2014-03-29 0:17 ` Grant Likely
2014-03-29 14:33 ` Rob Herring
2014-03-29 14:33 ` Rob Herring
2014-03-29 14:33 ` Rob Herring
2014-03-29 15:34 ` Grant Likely
2014-03-29 15:34 ` Grant Likely
2014-03-29 15:34 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14193198.1gAJ7xnz7b@wuerfel \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=robh@kernel.org \
--cc=robherring2@gmail.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.